Question

我在asp.net 2005和SQL Server 2008 R2的类型化数据集中有这个SQL查询。即我在Typed Dataset中使用 - “添加查询” - “使用Sql语句”并使用下面的脚本，然后我返回了一个Datatable。（“填写数据表”复选框未选中“）

SELECT DISTINCT
ISNULL(Projects.ProjectID,'0') as 
ProjectID,Messages.MessageID, Projects.ProjectName, Customers.CustomerName as 
CustomerName, Regions.RegionName,
(select U.firstName + ' ' + U.LastName 
 from Users U inner join Projects P on P.ProjectManagerId = U.UserID inner join   
 Messages M on M.ProjectId = P.ProjectID
 where M.MessageID =  Messages.MessageID) as ProjectManagerName,
 dbo.phases.TagName as Phase,
(select U.firstName + ' ' + U.LastName 
from Users U inner join  Messages M on M.CreatedBy = U.UserID Where M.MessageID =   
Messages.MessageID) as CreatedBy,
Messages.DateCreated as EmailCreatedDate,
Messages.MessageSubject as MessageSubject,
Users.Email as [From],
**(stuff((select ','+U.EMAIL
FROM USERS U INNER JOIN Recipients R ON U.USERID = R.USERID INNER JOIN MESSAGES M   
ON  R.MESSAGEID = M.MESSAGEID
          WHERE m.MessageID=Messages.MessageID AND R.RecipientTypeID=1
          for xml path(''), type).value('.', 'nvarchar(max)'), 1, 1, '')) as [TO],**

  **(stuff((select ','+U.EMAIL 
          FROM USERS U INNER JOIN Recipients R ON U.USERID = R.USERID INNER JOIN    
MESSAGES M ON R.MESSAGEID = M.MESSAGEID
          WHERE m.MessageID=Messages.MessageID AND R.RecipientTypeID=2
          for xml path(''), type).value('.', 'nvarchar(max)'), 1, 1, '')) as CC** 


FROM     Messages INNER JOIN  Users 
              ON Messages.Sender = Users.UserID
              INNER JOIN Recipients
              ON Messages.MessageID = Recipients.MessageID
              LEFT OUTER JOIN dbo.Projects 
              ON dbo.Messages.ProjectID = dbo.Projects.ProjectID                      
              Left OUTER JOIN dbo.Customers on dbo.Projects.CustomerId =  
dbo.Customers.CustomerID 
              Left outer join dbo.regions on dbo.Customers.RegionID =  
dbo.Regions.RegionID
              left outer join dbo.Phases on messages.phaseid = dbo.phases.phaseid

where (Messages.MessageTypeID=1)
and Projects.ProjectID <> '0' 
order by Projects.ProjectName

但是点击下一步，就会出现如下错误：

'（'。附近的WHERE子句出错无法解析查询文本。

但是，如果我在SQL Server 2008 R2 Management Studio中运行相同的上述查询，它运行正常并返回结果。

请说明我做错了什么。

由于

嗨，我已经使用了一种方法来实现这个..我使用这个查询（经过轻微修改）作为.cs代码后面的内联查询文件..但现在又出现了另一个问题....即。现在它需要花费太多时间来返回结果..是因为我在查询中使用的函数？请为此建议一些解决方法..

 SELECT DISTINCT
   ISNULL(Projects.ProjectID,'0') as 
   ProjectID,Messages.MessageID, Projects.ProjectName, Customers.CustomerName as  CustomerName, Regions.RegionName,  
   (select U.firstName + ' ' + U.LastName 
     from Users U inner join Projects P on P.ProjectManagerId = U.UserID inner join Messages M on M.ProjectId = P.ProjectID
     where M.MessageID =  Messages.MessageID) as ProjectManagerName,
     dbo.phases.TagName as Phase,
     (select U.firstName + ' ' + U.LastName 
     from Users U inner join  Messages M on M.CreatedBy = U.UserID Where M.MessageID = Messages.MessageID) as CreatedBy,
     Messages.DateCreated as EmailCreatedDate,
     Messages.MessageSubject as MessageSubject,
     Users.Email as [From],

    (select [dbo].[fn_ForEmailReport](Messages.MessageID,1)) as [TO],
    (select [dbo].[fn_ForEmailReport](Messages.MessageID,2)) as [CC]

    FROM     Messages INNER JOIN  Users 
                      ON Messages.Sender = Users.UserID
                      INNER JOIN Recipients
                      ON Messages.MessageID = Recipients.MessageID
                      LEFT OUTER JOIN dbo.Projects 
                      ON dbo.Messages.ProjectID = dbo.Projects.ProjectID                      
                      Left OUTER JOIN dbo.Customers on dbo.Projects.CustomerId = dbo.Customers.CustomerID 
                      Left outer join dbo.regions on dbo.Customers.RegionID = dbo.Regions.RegionID
                      left outer join dbo.Phases on messages.phaseid = dbo.phases.phaseid

    where (Messages.MessageTypeID=1)
    and Projects.ProjectID <> '0' 
    order by Projects.ProjectName


-- FUNCTION "fn_ForEmailReport" used in above query.

ALTER FUNCTION [dbo].[fn_ForEmailReport]
(
    @MessageID int,
    @RecipientTypeID int
)
RETURNS NVARCHAR(MAX)        
AS
BEGIN
    DECLARE @List VARCHAR(8000)
    set @List = (stuff((select ','+U.EMAIL 
    FROM USERS U inner JOIN Recipients R ON R.USERID = U.USERID inner JOIN 
            MESSAGES M ON R.MESSAGEID = M.MESSAGEID
    WHERE m.MessageID=@MessageID AND R.RecipientTypeID=@RecipientTypeID
    for xml path(''), type).value('.', 'nvarchar(max)'), 1, 1, ''))

  RETURN @List;

END

Answer 1

我相信有太多的联接。例如，下面的查询

(select U.firstName + ' ' + U.LastName 
from Users U inner join Projects P 
on P.ProjectManagerId = U.UserID 
inner join Messages M on M.ProjectId = P.ProjectID
where M.MessageID =  Messages.MessageID) as ProjectManagerName,

只获取名字和姓氏，一个单元格，它不需要是一个连接查询。另外，您已经在最后加入了Projects表。您可以为外部查询提供别名，并使内部查询更简单：

SELECT DISTINCT
   ISNULL(Projects.ProjectID,'0') as 
   ProjectID,Messages.MessageID, Projects.ProjectName, Customers.CustomerName as  CustomerName, Regions.RegionName,  
   (select U.firstName + ' ' + U.LastName 
     from Users WHERE P.ProjectManagerId = UserID) as ProjectManagerName,
     dbo.phases.TagName as Phase,
     (select U.firstName + ' ' + U.LastName 
     from Users WHERE M.CreatedBy = UserID) as CreatedBy,
     Messages.DateCreated as EmailCreatedDate,
     Messages.MessageSubject as MessageSubject,
     Users.Email as [From],

    (select [dbo].[fn_ForEmailReport](Messages.MessageID,1)) as [TO],
    (select [dbo].[fn_ForEmailReport](Messages.MessageID,2)) as [CC]

    FROM     Messages M INNER JOIN  Users 
                      ON Messages.Sender = Users.UserID
                      INNER JOIN Recipients
                      ON Messages.MessageID = Recipients.MessageID
                      LEFT OUTER JOIN dbo.Projects P
                      ON dbo.Messages.ProjectID = dbo.Projects.ProjectID                      
                      Left OUTER JOIN dbo.Customers on dbo.Projects.CustomerId = dbo.Customers.CustomerID 
                      Left outer join dbo.regions on dbo.Customers.RegionID = dbo.Regions.RegionID
                      left outer join dbo.Phases on messages.phaseid = dbo.phases.phaseid

    where (Messages.MessageTypeID=1)
    and Projects.ProjectID <> '0' 
    order by Projects.ProjectName

最后，如果您没有从Customers表中检索任何信息，则可以省略以下行：

Left OUTER JOIN dbo.Customers on dbo.Projects.CustomerId = dbo.Customers.CustomerID

类型化数据集中的Sql查询导致分析器错误

1 个答案: