Question

我需要一些帮助来重新构建我在程序中的if-else条件。这是一个微不足道的问题，但我一直在长时间工作，似乎无法找到一个好的解决方案。

如果我必须说明这些条件：

 This method should be executed for type 'A' objects iff `newValue` is 0, 
 otherwise it should be run only for type 'B' objects.

我想避免使用此代码中的嵌套ifs。

 public static void someMethod(final Object object) {

    if (MyObjects.getType(object) == ObjectType.A) {
        if (newValue != 0) {
            throw new IllegalStateException("newValue for A can only be 0");
        }
    } else if (MyObjects.getType(object) != ObjectType.B) {
        throw new IllegalStateException("Invalid object type received.");
    }

    // More code here
 }

Answer 1

如果您只需删除内部if，则将newValue != 0添加到第一个条件..

public static void someMethod(final Object object) {

   if (MyObjects.getType(object) == ObjectType.A && newValue != 0) {
           throw new IllegalStateException("newValue for A can only be 0");
   } else if (MyObjects.getType(object) != ObjectType.B) {
       throw new IllegalStateException("Invalid object type received.");
   }

   // More code here
}

这是你想要做的吗？

Answer 2

if ((MyObjects.getType(object) == ObjectType.A) && (newValue != 0)) {
        throw new IllegalStateException("newValue for A can only be 0");
} else if (MyObjects.getType(object) != ObjectType.B) {
    throw new IllegalStateException("Invalid object type received.");
}

Answer 3

 public static void someMethod(final Object object) {

    if ((object instanceof A && newValue==0)) || object instanceof B) {
        //then execute.
    }

 }

Answer 4

public static void someMethod(final Object object) {

    if ((MyObjects.getType(object) == ObjectType.A && newValue != 0) || (MyObjects.getType(object) != ObjectType.B)) {
            throw new IllegalStateException("newValue for A can only be 0 OR Invalid object type received.");
        }
    // More code here
 }

如果可能，重新构建if else条件

4 个答案: