MPI程序空指针

时间:2013-11-09 15:06:29

标签: c pointers nullpointerexception segmentation-fault mpi

我正在尝试创建一个mpi程序,它将运行我的bellard函数来计算pi到一万个小数位。当我运行该程序时,我遇到以下错误,我已经在线进行了一些搜索,在openMpi网站上,问题似乎是一个空指针,但我已经查看了代码,似乎无法找到它。

错误是: 信号:分段错误(11) 信号:未映射的地址(1) 地址失败:(无)

任何人都可以看到空指针吗?

#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <mpi/mpi.h>

#define PRECISION 10000


float minus_one,one,two,three,four,five,six,seven,eight,nine,ten,   
    thirty_two,sixty_four,two_five_six,one_zero_two_four,
    two_pow_six,recip_two_pow_six;


float *pi;
int rank,size;

void init(){
    printf("\nstarted init function");
    minus_one = -1.0;
    one = 1.0;
    two = 2.0;
    three = 3.0;
    four = 4.0;
    five = 5.0;
    six = 6.0;
    seven = 7.0;
    eight = 8.0;
    nine = 9.0;
    ten = 10.0;
    thirty_two = 32.0;
    sixty_four = 64.0;
    two_five_six = 256.0;
    one_zero_two_four = 1024.0;
    two_pow_six = pow(two,6);
    recip_two_pow_six = one/two_pow_six;

    pi = 0;
    printf("\nended init function");
    return;
}

float *bellard(int start, int end,int rank){
    float *terms;
    float t,t1,t2,t3,t4,t5,t6,t7,t8,t9,t10,t11,t12,
        t13,t14,t15,t16,t17,tx,ty,tz;

    int offset = rank;
    double start_k = start;
    double end_k = end;
    start_k = offset * (PRECISION /size);
    end_k = (offset+1) * (PRECISION/size);
    terms=0;

    int k = start_k;

    while( (k<PRECISION) && (k<end_k)){
        t1 = k;
        t2 = t1*ten;
        t3 = t2+one;
        t4 = two_five_six/t3;
        t5 = t2+nine;
        t6 = one/t5;
        t7 = t2+three;
        t8 = sixty_four/t7;
        t9 = four*t1;
        t10 = t9+one;
        t11 = thirty_two/t10;
        t12 = t2+five;
        t13 = four/t12;
        t14 = t2+seven;
        t15 = four/t14;
        t16 = t9+three;
        t17 = one+t16;

        t = t4+t6;
        t = t-t8;
        t = t-t11;
        t = t-t13;
        t = t-t15;
        t = t-t17;

        tx = pow(minus_one,k);
        ty = pow(one_zero_two_four,k);
        tz = tx/ty;
        *terms = tz*t;

        //pi = pi+terms;
        k = k+1;
    }
        return terms;
}

int main(int argc, char** argv){


    int i;
    MPI_Status status;
    MPI_Init(&argc, &argv);
    MPI_Comm_size(MPI_COMM_WORLD, &size);
    MPI_Comm_rank(MPI_COMM_WORLD, &rank);
    int elementsCount = 10000/(size-1);
    float *workerPi;
    float *tmpPi=0;

    init(); //initialise variables
    printf("\nim here 1");
    if(rank == 0)
    {
        for(i=1; i < size; i++){
            printf("\nin recv loop");           
            MPI_Recv(tmpPi,PRECISION,MPI_FLOAT,i,1,MPI_COMM_WORLD,&status);
            *pi=*pi+*tmpPi;
        }
    }else{

        //int i;

        int start,end,slice,workers;
        workerPi = malloc(sizeof(int)*elementsCount);
        workers = size-1;
        slice = 10000/workers;
        start = (rank-1)*slice;
        end = start+slice;

        printf("\nWorker %d processing data %d to %d\n",rank,start,end);

        workerPi = bellard(start,end,rank);
        printf("\nworker finished pi");

        MPI_Send(workerPi,slice,MPI_FLOAT,0,1,MPI_COMM_WORLD);
        printf("\nworker sent stuff");

    }

    MPI_Finalize();

    return 0;
}

1 个答案:

答案 0 :(得分:2)

bellard函数中,terms被声明为指向float的指针

float *terms;

并初始化为零(又名null)几行

terms=0;

在while循环结束时,它被解除引用:

*terms = tz*t;

语句*terms是一个空指针取消引用并将崩溃。它本质上是要求将tz*t的结果存储到内存地址零,这不是一个有效的内存地址。

修复可能是声明并使用terms作为float,而不是指向浮动(float*)的指针。