Question

我的sql数据库的delete方法不会从数据库中删除该条目。它给出了一个空指针异常：

10-18 00：44：25.069：E / AndroidRuntime（17968）：java.lang.NullPointerException 10-18 00：44：25.069：E / AndroidRuntime（17968）：at com.weather.app.LocationDB.deleteLocation（LocationDB.java:98）

public class LocationDB extends SQLiteOpenHelper {

private static final int DATABASE_VERSION = 1;

// Database Name
private static final String DATABASE_NAME = "locationManager";

private static final String TABLE_LOCATIONS = "locations";
private static final String KEY_ID = "id";
private static final String KEY_LOCATION = "location";
private static final String KEY_COUNTRY = "country";
private SQLiteDatabase db;

public LocationDB(Context context) {
    super(context, DATABASE_NAME, null, DATABASE_VERSION);
}

@Override
public void onCreate(SQLiteDatabase db) {

    String sql = "CREATE TABLE IF NOT EXISTS " + TABLE_LOCATIONS + " ( "
            + KEY_ID + " INTEGER PRIMARY KEY AUTOINCREMENT, " + KEY_LOCATION
            + " TEXT, " + KEY_COUNTRY
            + " TEXT, " + " INTEGER)";
    db.execSQL(sql);
}

@Override
public void onUpgrade(SQLiteDatabase db, int oldV, int newV) {
    db.execSQL("DROP TABLE IF EXISTS " + TABLE_LOCATIONS);
    onCreate(db);
}
public void addLocation(LocationName location) {
    SQLiteDatabase db = this.getWritableDatabase();

    ContentValues values = new ContentValues();
    values.put(KEY_LOCATION, location.getTaskName());
    values.put(KEY_COUNTRY, location.getTaskCountry());

    db.insert(TABLE_LOCATIONS, null, values);
}

public List<LocationName> getAllLocations() {
    List<LocationName> locList = new ArrayList<LocationName>();
    // Select All Query
    String selectQuery = "SELECT  * FROM " + TABLE_LOCATIONS;

    SQLiteDatabase db = this.getWritableDatabase();
    Cursor cursor = db.rawQuery(selectQuery, null);

    // looping through all rows and adding to list
    if (cursor.moveToFirst()) {
        do {
            LocationName task = new LocationName();
            task.setId(cursor.getInt(0));
            task.setTaskName(cursor.getString(1));
            task.setTaskCountry(cursor.getString(2));
            // Adding contact to list
            locList.add(task);
        } while (cursor.moveToNext());
    }
    return locList;
}
public boolean deleteLocation(long rowId) {
    return db.delete(TABLE_LOCATIONS, KEY_ID + "=" + rowId, null) > 0;
}

}

即使重新启动应用程序，也不会删除条目，添加行的addLocation方法可以正常工作。

LocationSettings活动：

public class LocationSettings extends Activity {
protected static LocationDB db;
static List<LocationName> list;
MyAdapter adapt;
private static TextView name;
private ListView listView;
private static final int DLG_EXAMPLE1 = 0;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_location_settings);
    getActionBar().setDisplayHomeAsUpEnabled(true);
    getActionBar().setHomeButtonEnabled(true);
    db = new LocationDB(this);
    list = db.getAllTasks();
    adapt = new MyAdapter(this, R.layout.drawer_list_item, list);
    listView = (ListView) findViewById(R.id.left_drawer);
    listView.setAdapter(adapt);
    SwipeDismissListViewTouchListener touchListener =
            new SwipeDismissListViewTouchListener(
                    listView,
                    new SwipeDismissListViewTouchListener.DismissCallbacks() {
                        @Override
                        public boolean canDismiss(int position) {
                            return true;
                        }

                        @Override
                        public void onDismiss(ListView listView, int[] reverseSortedPositions) {
                            for (int position : reverseSortedPositions) {
                                db.deleteTask(position);
                                adapt.remove(adapt.getItem(position));
                            }
                        }
                    });

    listView.setOnItemClickListener(new DrawerItemClickListener());
    listView.setOnTouchListener(touchListener);

}
public class DrawerItemClickListener implements ListView.OnItemClickListener {
    @Override
    public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
        db.deleteTask(position);
        adapt.notifyDataSetChanged();
    }
}
private class MyAdapter extends ArrayAdapter<LocationName> {

    Context context;
    List<LocationName> taskList = new ArrayList<LocationName>();
    int layoutResourceId;

    public MyAdapter(Context context, int layoutResourceId,
            List<LocationName> objects) {
        super(context, layoutResourceId, objects);
        this.layoutResourceId = layoutResourceId;
        this.taskList = objects;
        this.context = context;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        if (convertView == null) {
            LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
            convertView = inflater.inflate(R.layout.drawer_list_item,parent, false);
            name = (TextView) convertView.findViewById(R.id.text1);
        } 
        LocationName current = taskList.get(position);
        name.setText(current.getTaskName());
        return convertView;
    }

}

}

Answer 1

在db调用删除方法之前忘记初始化deleteLocation。

public int deleteLocation(long rowId) {
    SQLiteDatabase db = this.getWritableDatabase();
    return db.delete(TABLE_LOCATIONS, KEY_ID + " = ?", 
                             new String[] { String.valueOf(rowId) });
}

Answer 2

使用@ρяσѕρєяK中建议的以下代码片段：

public int deleteLocation(long rowId) {
    SQLiteDatabase db = this.getWritableDatabase();
    return db.delete(TABLE_LOCATIONS, KEY_ID + " = ?", 
                             new String[] { String.valueOf(rowId) });
}

更改了生成该错误的方法的签名。我想那个

public boolean deleteLocation(long rowId) {
    SQLiteDatabase db = this.getWritableDatabase();
    return db.delete(TABLE_LOCATIONS, KEY_ID + " = ?", 
                             new String[] { String.valueOf(rowId) }) > 0;
}

将解决您的问题。

从sql数据库中删除行

2 个答案: