我如何同时使用&&和||在if语句中

时间:2013-09-25 19:51:13

标签: java binary-operators

我正在研究一种石头剪刀gui应用程序,我一直坚持如何让它工作。我发现在第49行我得到了一个非法的表达错误开始。虽然我意识到这是一项任务,但我不确定是什么引发了错误:

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;

public class Rps extends JFrame
 implements ActionListener
{
private final char moves[] = {'R', 'P', 'S'};
private JRadioButton rock, paper, scissors;
private JTextField display;

public Rps()
{
super("Rock, paper, Scissors");

rock = new JRadioButton("   Rock   ", true);
paper = new JRadioButton("   Paper  ");
scissors = new JRadioButton(" Scissors ");

ButtonGroup rpsButtons = new ButtonGroup();
rpsButtons.add(rock);
rpsButtons.add(paper);
rpsButtons.add(scissors);

JButton go = new JButton("         Go         ");
go.addActionListener(this);

display = new JTextField(25);
display.setEditable(false);
display.setBackground(Color.yellow);

Container c = getContentPane();
c.setLayout(new FlowLayout());
c.add(rock);
c.add(paper);
c.add(scissors);
c.add(go);
c.add(display);
}

/**
*  returns -1 if the player wins,
*  0 if it's a tie, and 1 if the computer wins
*/
private int nextPlay(char computerMove, char playerMove)
{
if (computerMove == 'R'&&playerMove == 'S'||computerMove=='S'&&playerMove==='P'||computerMove=='P'&&playerMove=='R'){ //Where I get the error
 int r = 1;
 return r;
 }
else if (computerMove == 'R'&&playerMove == 'R'||computerMove=='S'&&playerMove=='S'||computerMove=='P'&&playerMove=='P'){
 int r = 0;
 return r;
}
else if (computerMove == 'S'&&playerMove == 'R'||computerMove=='P'&&playerMove=='S'||computerMove=='R'&&playerMove=='P'){
 int r = -1;
 return r;
}   

}

public void actionPerformed(ActionEvent e)
{
  char playerMove, computerMove;
  if (rock.isSelected())
    playerMove = 'R';
  else if (paper.isSelected())
    playerMove = 'P';
  else if (scissors.isSelected())
    playerMove = 'S';

 int k = (int)(Math.random() * 3);
computerMove = moves[k];
int result = nextPlay(computerMove, playerMove);

String msg = "  You said " + makeWord(playerMove) + ", I said " +
             makeWord(computerMove);
if (result < 0)
  msg += " -- you win.";
else if (result == 0)
  msg += " -- tie.";
else if (result > 0)
  msg += " -- I win.";
display.setText(msg);
}

private String makeWord(char move)
{
  String word = "";

switch (move)
{
  case 'R': word = "ROCK"; break;
  case 'P': word = "PAPER"; break;
  case 'S': word = "SCISSORS"; break;
}
return word;

}

public static void main(String[] args)
{
  Rps window = new Rps();
  window.setBounds(300, 300, 300, 140);
  window.setDefaultCloseOperation(EXIT_ON_CLOSE);
  window.setVisible(true);
}

}

3 个答案:

答案 0 :(得分:3)

您使用的是assignment运算符= 您需要在comparison块中使用==运算符if

if (computerMove == 'R'&& playerMove =='S'||computerMove=='S'&&playerMove=='P'|| computerMove=='P'&& playerMove=='R')

编辑:

有拼写错误

您的playerMove==='P'声明中的

if

答案 1 :(得分:0)

试试这个:

 if ((computerMove == 'R'&&playerMove == 'S')||(computerMove=='S'&&playerMove=='P')||(computerMove=='P'&&playerMove=='R')){
     int r = 1;
     return r;
     }
else if ((computerMove == 'R'&&playerMove = 'R')||(computerMove=='S'&&playerMove=='S')||(computerMove=='P'&&playerMove=='P')){
 int r = 0;
 return r;
}
else if ((computerMove == 'S'&&playerMove == 'R')||(computerMove=='P'&&playerMove=='S')||(computerMove=='R'&&playerMove=='P')){
 int r = -1;
 return r;

答案 2 :(得分:0)

除了其他人所说的使用==而不是=之外,我只会使用括号。不会伤害任何东西,并提高代码的可读性。所以你的陈述看起来像是:

if (
(computerMove == 'R'&&playerMove =='R') ||
(computerMove=='S'&&playerMove=='S') ||
(computerMove=='P'&&playerMove=='P')
)...