Question

我使用动态分配的数组在c ++中为一系列双精度编写了一个类。在运行程序时，它成功完成，但是valgrind发现了一个错误。调用调整大小函数时，我收到大小为8的无效读取。

  void sequence::resize(size_type new_capacity){
    if (new_capacity == capacity){
      return;
    }else {
      if (new_capacity < used)
          used = new_capacity;
      capacity = new_capacity;
      value_type* new_vals;
      new_vals = new value_type[capacity];
      for (int i=0;i<used;i++){
          new_vals[i] = data[i];
      }
      cout<<endl;
      delete [] data;
      data = new_vals;
    }
  }

附加调用调整大小：

  void sequence::attach(const value_type& entry){
    //Behaivoir for empty sequence
    if(used == 0){
      current_index = 0;
      used++;
      if (used > capacity)
        resize(capacity*2);
      data[current_index] = entry;     
    } 
    //Behaivoir for no current_index
    else if (!is_item()){
      current_index = used;
      used++;
      if (used > capacity)
        resize(capacity*2);
      data[current_index] = entry;
    }
    //Default behaivoir
    else {
      used++;
      if (used > capacity)
        resize(capacity*2);
      for(int i = used-1; i>current_index+1;i--)
        data[i] = data[i-1];
      advance();
      data[current_index] = entry;
    }
  }

以下是我在测试程序中收到的错误：

==1919== Invalid read of size 8
==1919==    at 0x400DB3: main_savitch_4::sequence::resize(unsigned long) (sequence2.cxx:44)
==1919==    by 0x401091: main_savitch_4::sequence::attach(double const&) (sequence2.cxx:95)
==1919==    by 0x403232: test5() (sequence_exam2.cxx:538)
==1919==    by 0x40414E: run_a_test(int, char const*, int (*)(), int) (sequence_exam2.cxx:744)
==1919==    by 0x404321: main (sequence_exam2.cxx:775)
==1919==  Address 0x5a1ae50 is 0 bytes after a block of size 240 alloc'd
==1919==    at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1919==    by 0x400C33: main_savitch_4::sequence::sequence(unsigned long) (sequence2.cxx:17)
==1919==    by 0x4030AC: test5() (sequence_exam2.cxx:520)
==1919==    by 0x40414E: run_a_test(int, char const*, int (*)(), int) (sequence_exam2.cxx:744)
==1919==    by 0x404321: main (sequence_exam2.cxx:775)
==1919==

我尝试使用--leak-check = full和--read-var-info = yes运行valgrind，但无法确定我收到此错误的原因。调整大小的第45行是：new_vals [i] = data [i];

感谢!!!

Answer 1

问题是你设置用于new_capacity而不检查它，所以如果它小于new_capacity则会导致问题。

Answer 2

if (used > capacity)
 resize(capacity*2);     //here current index=capacity i.e maxm size allocated to new_vals
  data[current_index] = entry; //current_index > capacity, this is out of reach memory for new vals and data(since data=new_vals), so you are getting invalid read.

读取大小为8无效

2 个答案: