数组不能在莫尔斯电码程序上打印

时间:2013-08-16 18:10:08

标签: java arrays converter

我是java的新手,我的摩尔斯电码程序遇到了麻烦。请耐心等待,但是当输入要从莫尔斯代码翻译成英文的文本时,它只会打印空格代替字母。任何帮助将不胜感激。

import java.util.Scanner;

public class MorseCode
{
    public static void main(String[] args)
    {
        Scanner Input = new Scanner(System.in);

        System.out.println("To convert English to Morse Code, type M. To convert Morse Code to English, type E.");

        String cType = Input.nextLine();

        String type = cType.toLowerCase();

        if("m".equals(type))
        {
            String eng;
            System.out.println("Please enter the English text to be translated.");
            eng = Input.nextLine();
            EToM(eng);
        }
        else
        {
            String morse;
            System.out.println("Please enter the Morse code text to be translated, with multiple words seperated by a |.");
            morse = Input.nextLine();
            MToE(morse);
        }
    }
    public static void EToM(String eng)
    {
        String EToMList[] = {".-", "-...", "-.-.", "-..", ".", "..-.", "--.", "....", "..", ".--", "-.-", ".-..", "--", "-.", "---", ".--.", "--.-", ".-.", "...", "-", "..-", "...-", ".--", "-..-", "-.--", "--..", ".----", "..---", "...--", "....-", ".....", "-....", "--...", "----.", "-----", "|"};
        String alphabet = "abcdefghijklmnopqrstuvwxyz123456789 ";
        String translation[] = new String[eng.length()];

        for(int x = 0; x < eng.length(); x++)
        {
            for(int y = 0; y < alphabet.length(); y++)
            {
                if(eng.charAt(x) == alphabet.charAt(y))
                {
                    translation[x] = EToMList[y];
                }
            }
        }

        System.out.println("Your translated message is:");

        for(int z = 0; z < eng.length(); z++)
        {
            System.out.println(translation[z]); 
        }
    }

    public static void MToE(String morse)
    {
        int arraySize = 0;
        String MToEList[] = {".-", "-...", "-.-.", "-..", ".", "..-.", "--.", "....", "..", ".--", "-.-", ".-..", "--", "-.", "---", ".--.", "--.-", ".-.", "...", "-", "..-", "...-", ".--", "-..-", "-.--", "--..", ".----", "..---", "...--", "....-", ".....", "-....", "--...", "----.", "-----", "|"};
        String alphabet = "abcdefghijklmnopqrstuvwxyz123456789 ";
        char space = '|';

        for(int x = 0; x < morse.length(); x++)
        {
            if(morse.charAt(x) == space)
            {
                arraySize += 1;
            }
        }

        String segmentedMessage[] = new String[arraySize];
        String translation[] = new String[arraySize];

        int a = 1;
        int counter = 0;

        for(int y = 0; y < morse.length(); y++)
        {
            if(morse.charAt(y) == space)
            {
                segmentedMessage[counter] = morse.substring((a - 1), (y + 1));
                a = y;
            }
        }

        for(int z = 0; z < segmentedMessage.length; z++)
        {
            for(int i = 0; i < alphabet.length(); i++)
            {
                if(segmentedMessage[z] == MToEList[i])
                {
                    translation[z] = alphabet.substring(i - 1, i + 1);
                }
            }
        }

        System.out.println("Your translated message is:");

        for(int j = 0; j < translation.length; j++)
        {
            System.out.println(translation[j]);
        }
    }
}       

2 个答案:

答案 0 :(得分:1)

我认为你的问题在于

if(segmentedMessage[z] == MToEList[i])

前面您要比较的是char类型,char是一种原始类型,这意味着您可以使用==来安全地比较值。在我提到的行上,你正在比较字符串类型。 String是一个java对象。

所有Java对象都应该使用.compare而不是==

实施例

char char1 = 'c';
char char2 = 'c';
char1 == char2 // true!

String str1 = "c";
String str2 = "c";
str1 == str2 // not always going to be true, even tho it would seem that way
str1.equals(str2) // true!

答案 1 :(得分:1)

我看到的第一个问题是在你的MToE方法中,在本节中:

int a = 1;
int counter = 0

for(int y = 0; y < morse.length(); y++)
{
    if(morse.charAt(y) == space)
    {
        segmentedMessage[counter] = morse.substring((a - 1), (y + 1));
        a = y;
    }
}

你永远不会增加计数器,所以只有segmentedMessage的第一个元素才能填充莫尔斯字符串。如果你得到一个字符,然后是一堆空字符,这可能是你的问题。

此外,在同一方法的这一行:

translation[z] = alphabet.substring(i - 1, i + 1);

您正在使用由i - 1和字母表的第i个字符组成的两个元素子字符串。看起来你的意思是使用alphabet.substring(i,i + 1)。特别是,如果i = 0,这将导致问题,因为您将尝试从-1开始获取子字符串。