INSERT语句的选择列表包含的项目少于插入列表。

时间:2013-07-30 15:56:59

标签: c# .net sql sql-server-2008

显然,插入列表包含的项目多于所选值的数量,但似乎无法查看情况。通过观察它们是相同的,除非我遗漏了什么?

   public static DateTime CreateMedicationDispenseLocationHistory( int medicationDispenseID, int locationID, int staffID, DateTime date )
    {
        SqlConnection connection = new SqlConnection( Utilities.DBConnectionString() );
        connection.Open();

        CreateMedicationDispenseLocationHistory( medicationDispenseID, locationID, staffID, date, connection, null );

        connection.Close();
        connection.Dispose();

        return date;
    }

    public static DateTime CreateMedicationDispenseLocationHistory( int medicationDispenseID, int locationID, int staffID, DateTime date, SqlConnection connection, SqlTransaction transaction )
    {
        Locations location = new Locations();
        MedicationList medication = new MedicationList();
        StringBuilder sqlString = new StringBuilder();

        SqlCommand command;

        sqlString.Append("INSERT INTO [MedicationDispenseLocationHistory] (");
        sqlString.Append("MedicationDispenseID, " );
        sqlString.Append("LocationID, " );
        sqlString.Append("StaffID, " );
        sqlString.Append("DateTimeStamp" );
        sqlString.Append(") SELECT SCOPE_IDENTITY();");

        command = new SqlCommand( sqlString.ToString(), connection );
        if( ( transaction != null ) ) command.Transaction = transaction;

        command.Parameters.Add( "@MedicationDispenseID", SqlDbType.Int ).Value = medication.MedicationDispenseID;
        command.Parameters.Add( "@LocationID", SqlDbType.Int ).Value = location.LocationID;
        command.Parameters.Add( "@StaffID", SqlDbType.Int, 500 ).Value = Helper.GetValue( GlobalVariables.loggedInStaff.StaffID );
        command.Parameters.Add( "@DateTimeStamp", SqlDbType.DateTime ).Value = Helper.GetDBDateValue(DateTime.Now);
        //command.Parameters.Add("@stopDate", SqlDbType.DateTime).Value = Helper.GetValue(medicationDispense.StopDate);
        medication.MedicationDispenseID = Convert.ToInt32( command.ExecuteScalar() );

        return date;
    }

1 个答案:

答案 0 :(得分:3)

在INSERT INTO语句的末尾添加分号

  sqlString.Append("); SELECT SCOPE_IDENTITY();");

否则以下 SELECT SCOPE_IDENTITY()将被解释为INSERT的SELECT值列表

INSERT INTO ....... SELECT

完成答案(对以下评论的作者表示赞赏)
不要忘记为参数添加值占位符

  sqlString.Append(") VALUES (@MedicationDispenseID,@LocationID,@StaffID,@DateTimeStamp);");
  sqlString.Append("SELECT SCOPE_IDENTITY();");