Question

我可以知道如何在控制器创建方法中使用存根方法吗？我需要为此编写规范但是我遇到了这些错误。我需要在模型中创建新公司记录之前检查控制器中的create方法必须执行validate_fbid方法。

错误：

1) Companies new company create with valid information#validate_fbid should have correct parameters and return value
 Failure/Error: CompaniesController.create.should_receive(:validates_fbid).with(company)
 NoMethodError:
   undefined method `create' for CompaniesController:Class
 # ./spec/requests/companies_spec.rb:38:in `block (5 levels) in <top (required)>'

  2) Companies new company create with valid information#validate_fbid should fbid validation passed
 Failure/Error: CompaniesController.create.stub(:validates_fbid).and_return('companyid')
 NoMethodError:
   undefined method `create' for CompaniesController:Class
 # ./spec/requests/companies_spec.rb:43:in `block (5 levels) in <top (required)>'

CompaniesController

def create 
company = Company.new(params[:company])
verifyfbid = validate_fbid(company)

if verifyfbid != false
    if company.fbid.downcase == verifyfbid.downcase
        if company.save 
            @message = "New company created."
            redirect_to root_path
        else 
            @message = "Company create attempt failed. Please try again."
            render 'new' 
        end 
    else 
        @message = "Company create attempt failed. Invalid facebook id."
        render 'new' 
    end
else  
    @message = "Company create attempt failed. No such facebook id."
    render 'new'            
    end             
 end 

  private  
  def validate_fbid(company)
   uri = URI("http://graph.facebook.com/" + company.fbid)
   data = Net::HTTP.get(uri)
   username = JSON.parse(data)['username']      
   if username.nil?
    return false 
   else
    "#{username}"
   end
 end

请求/ companies_spec.rb

context "#validate_fbid" do               
        #validate fbid
        let(:company){ Company.new(name:'Example Company', url: 'www.company.com', fbid: 'companyid', desc: 'Company desc' )}

        it "should have correct parameters and return value" do
            CompaniesController.create.should_receive(:validates_fbid).with(company)
                                .and_return('companyid')
        end

        it "should fbid validation passed" do               
            CompaniesController.create.stub(:validates_fbid).and_return('companyid')
            company.fbid.should_not be_nil
            company.fbid.should == 'companyid'
            company.save
            expect { click_button submit }.to change(Company, :count).by(1)
        end                                             
    end

Answer 1

当它是测试用例的主题

时，您不希望存根该方法

context "#validate_fbid" do
  #test the function here
  #don't stub
end

在控制器中测试创建操作时，可以存根“validate_fbid”

describe "post create" do
   ...
   CompaniesController.any_instance.stub(:validates_fbid).and_return('companyid')
   ...
end

希望它有所帮助。

Answer 2

当代码难以测试时，通常是因为它很复杂。

您应该以这种方式重构此代码：

将验证逻辑移至新的“服务类”中，该服务类在facebook上负责公司验证
这将使验证功能独立于Web层，更多更容易测试
为服务类制作规范，它将隔离测试此代码（无控制器）
清理逻辑控制器 - 您不希望控制器内部有逻辑（经验法则：最大嵌套级别）
控制器的规格也会更容易

控制器代码可能如下所示：

def create
  company = Company.new(params[:company])
  verified = FbCompanyVerifier.new.verify(company)

  if verified and company.save
    # success logic
  else
    # fail logic
  end
end

Answer 3

如果您正在测试控制器，则可以直接访问控制器：

controller.stub(:message) { 'this is the value to return' }

Answer 4

以下是Rspec 3（3.3）的推荐语法：

allow_any_instance_of(CompaniesController).to receive(:validates_fbid).and_return("companyid")

或

expect_any_instance_of(CompaniesController).to receive(:validates_fbid).and_return("companyid")

来源：https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance

Rspec：控制器中的Stub方法

4 个答案: