Question

我有这些if-else语句，我无法重构。我已经使用它们在服务器端使用asp.net进行验证。

有人请建议减少这些陈述的方法吗？此处，验证字段和验证类型为enum列表。

else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationFields.FO.ToString(), ValidationTypes.P.ToString()))
{
   BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
   args.IsValid = false;
}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationFields.FW.ToString(), ValidationTypes.P.ToString()))
{
   BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
   args.IsValid = false;
}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationFields.UF.ToString(), ValidationTypes.P.ToString()))
{
     BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
     args.IsValid = false;
}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationTypes.O.ToString(), ValidationTypes.P.ToString()))
{
      BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
      args.IsValid = false;
}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationTypes.W.ToString(), ValidationTypes.P.ToString()))
{
      BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
      args.IsValid = false;

}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationTypes.P.ToString(), ValidationTypes.C.ToString()))
{
      BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
      args.IsValid = false;

}
else if (CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), ValidationTypes.C.ToString(), ValidationTypes.U.ToString()))
{
      BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
      args.IsValid = false;

}

这是Checknextitem的方法：

 public static bool CheckNextItem(string Compareitem1, string comnpareitem2, string items1, string items2)
  {

        var listContains = Compareitem1 == items1 && comnpareitem2 != items2;
        return listContains;

  }

如果我使用此代码

 var invalidComparisons = new ValidationTypes[][] {
                      new[] { ValidationFields.FO, ValidationTypes.P },
                      new[] { ValidationFields.FW, ValidationTypes.P },
                      new[] { ValidationFields.UF, ValidationTypes.O },
                      new[] { ValidationTypes.O, ValidationTypes.P },
                      new[] { ValidationTypes.W, ValidationTypes.P },
                      new[] { ValidationTypes.P, ValidationTypes.C },
                      new[] { ValidationTypes.C, ValidationTypes.U },
                   };

我收到编译时错误：“找不到隐式类型数组的最佳类型”。

Answer 1

使用列表/数组存储要比较的验证类型：

var invalidComparisons = new string[][] {
        new[] { ValidationFields.FO.ToString(), ValidationTypes.P.ToString() },
        new[] { ValidationFields.FW.ToString(), ValidationTypes.P.ToString() },
        new[] { ValidationFields.UF.ToString(), ValidationTypes.O.ToString() },
        new[] { ValidationTypes.O.ToString(), ValidationTypes.P.ToString() },
        new[] { ValidationTypes.W.ToString(), ValidationTypes.P.ToString() },
        new[] { ValidationTypes.P.ToString(), ValidationTypes.C.ToString() },
        new[] { ValidationTypes.C.ToString(), ValidationTypes.U.ToString() },
};

if (invalidComparisons.Any(x => CheckNextItem(ddlBr1Type.SelectedValue.ToString(), ddlBr2Type.SelectedValue.ToString(), x[0], x[1]))
{
    BrkTypeValidator2.ErrorMessage = "'TOP0618 -Invalid combination of Bracket IDs'";
    args.IsValid = false;
}

如何使用此枚举列表减少代码

1 个答案: