Django没有提出任何错误问题

时间:2013-07-04 11:24:53

标签: django

我正在构建一个简单的消息传递应用程序,用户可以相互发送消息。 我正在使用一个功能,允许用户发送之前保存为草稿的消息。

问题是,当没有提交输入或用户名不存在时,它不会引发任何错误。我认为有些东西阻止它意味着,它不会创建发送给其他用户的消息

这是我的模特

class Thread(models.Model):
    subject = models.CharField(max_length=100, blank=True)
    user = models.ForeignKey(User)

class Message(models.Model):
    user = models.ForeignKey(User, related_name='sender')
    recipient = models.ForeignKey(User, related_name='recipient')
    created = models.DateTimeField(auto_now_add=True)
    body = models.CharField(max_length=1000)
    read = models.BooleanField(default=False)
    trash = models.BooleanField(default=False)
    sentmessage = models.BooleanField(default=False)
    thread = models.ForeignKey(Thread,blank=True,null=True)

    def __unicode__(self):
        return self.body

因为您需要主题,收件人和正文发送消息,并且他们每个都在不同的模型中,这是用户已经创建消息并将其保存为草稿的时间。我创建了两个表单,每个表单都有不同的模型,并使用它们的对象填充每个表单。

class DraftForm(forms.ModelForm):
    recipient = forms.CharField(required=True,max_length=2)
    body = forms.CharField(widget=forms.Textarea,required=True,max_length=1)
    hidden_field = forms.CharField(widget=forms.HiddenInput())       

    class Meta:
        model = Message 
        fields = ('body',)  

    def clean_recipient(self):
            recipient = self.cleaned_data['recipient']

            try:
                recipient = User.objects.get(username=recipient)
            except User.DoesNotExist:
                raise forms.ValidationError("This username does not exist")
            return recipient
class ThreadForm(forms.ModelForm):
    class Meta:
        model = Thread 
        fields = ('subject',)    

视图

@login_required
def ReadDraft(request,id):
    try:
        messages = Message.objects.get(pk=id,recipient=request.user,trash=True) 
    except Message.DoesNotExist:
        return HttpResponseRedirect(reverse('world:Display'))
    thread = Thread.objects.get(message=messages)
    initial = {}
    initial.update({'hidden_field': messages.id})
    draft = DraftForm(instance=messages,initial=initial)
    thread = ThreadForm(instance=thread)
    person = Person.objects.get(user=request.user)

    if request.method =='POST':
        id = request.POST.get('hidden_field', False)
        form = ThreadForm(request.POST)
        forms = DraftForm(request.POST)
        if form.is_valid and forms.is_valid():
            m = Message.objects.get(pk=id)
            recipient = form.cleaned_data['recipient']
            subject = form.cleaned_data['subject']
            body = form.cleaned_data['body']
            message =    Message.objects.create(user=request.user,recipient=recipient,body=message,thread=m.thread)

    return render(request,'create.html',{'DraftForm':draft,'ThreadForm':thread,'person':person})

形式

{% if DraftForm and ThreadForm %}

<form method="POST" >{% csrf_token %}

    {{DraftForm.recipient}}
    {{ThreadForm.subject}}
    {{DraftForm.body}}
    {{DraftForm.hidden_field}}
    <input type = "submit" value= "send" class="save" id="send"  />


</form>

{% endif %}

{{ThreadForm.subject.errors}}
{{DraftForm.recipient.errors}}
{{DraftForm.body.errors}}

2 个答案:

答案 0 :(得分:2)

当您执行POST请求并且验证失败时,您不会在模板上下文中包含表单。因此表单中没有错误消息。

您应该执行以下操作:

if request.method =='POST':
    # some more code here ...
    thread = ThreadForm(request.POST)
    draft = DraftForm(request.POST)

希望这有帮助。

编辑:还看看Burhans的答案,你忘记了大括号if forms.is_valid()

答案 1 :(得分:1)

它不起作用,因为在这里:

if form.is_valid and forms.is_valid()

一个是属性,一个是方法调用,其中只有一个实际上正在做任何事情(另一个是返回True)。

即使有任何错误,您也没有条件检查表单是否失败并返回模板(else检查没有if子句。

把所有这些放在一起,你应该有这样的东西:

if request.method =='POST':
   id = request.POST.get('hidden_field')  # get will return None as default value
   form = ThreadForm(request.POST)
   forms = DraftForm(request.POST)
   if form.is_valid() and forms.is_valid():
      # do stuff
      return redirect(reverse('some-url'))
   else:
      ctx = {'DraftForm': form, 'ThreadForm': forms}
      return render(request, 'forms.html', ctx)
else:
   return redirect(reverse('some-url'))

forms.html中,您应该:

{{ DraftForm.errors }}
{{ ThreadForm.errors }}