Question

我有以下代码：

public Expression FilterString(string property, string value, ParameterExpression parameter)
{
    //Create Message MemberExpression from parameter and properted eg/Message.Body
    var getname = Expression.Property(parameter, property);

    //Create expression for Not IsNullOrEmpty
    var isnullorempty = Expression.Not(Expression.Call(typeof(string), "IsNullOrEmpty", null, getname));

    //Create expression for member property equal to value eg/Message.Body = "hi"
    var toLower = Expression.Call(getname,
                         typeof(string).GetMethod("ToLower", System.Type.EmptyTypes));
    var compare = Expression.Equal(toLower, Expression.Constant(value));

    //Create expression combining Not IsNullOrEmpty AND Equal To
    var condition = Expression.And(isnullorempty, compare);

    return condition;
}

如果我运行以下测试，我得到一个NullReferenceException，我假设因为某些项目有一个空体，但这正是Expression应该测试的内容。

private IEnumerable<Message> GetMessages()
{
    var list = new List<Message>();

    var message = new Message() { Body = null, Properties = new Collection<MessageProperty>() };
    list.Add(message);

    message = new Message() { Body = "", Properties = new Collection<MessageProperty>() };
    list.Add(message);

    message = new Message() { Body = "Hello Everybody", Properties = new Collection<MessageProperty>() };
    list.Add(message);

    message = new Message() { Flag = 1, Properties = new Collection<MessageProperty>() };
    list.Add(message);

    message = new Message() { ChannelInt = 1,  Properties = new Collection<MessageProperty>() };
    list.Add(message);

    message = new Message() { Properties = new Collection<MessageProperty>(new[] { new MessageProperty() { Key = "Gender", Value = "male" } }) };
    list.Add(message);

    return list;
}

[Theory]
[InlineData("Hello Everybody")]
[InlineData("hello everybody")]
public void FilterString_NullAndEmptyMessages_Removed(string searchTerm)
{
    var messageList = GetMessages();

    var parameter = Expression.Parameter(typeof(Message), "message");

    var equalToFilterType = new EqualToFilterType();

    var filter = equalToFilterType.FilterString("Body", searchTerm, parameter);

    var lambda = Expression.Lambda(filter, parameter);

    //******EXCEPTION*******//
    var result = messageList.AsQueryable().Where((Expression<Func<Message, bool>>)lambda).ToList();

    Assert.Equal(1, result.Count);
}

我有什么想法可以让这个测试通过？（我的表达式代码也将用于命中SQL Server BTW）

Answer 1

我怀疑这是问题所在：

var condition = Expression.And(isnullorempty, compare);

我怀疑你想要AndAlso：

var condition = Expression.AndAlso(isnullorempty, compare);

实际上，目前你已经

了

x & y

而你想要

x && y

在列表上执行表达式ToLower会引发异常

1 个答案: