删除按钮不返回正确的值以删除查询

时间:2013-06-16 10:01:08

标签: php mysql database

我有一个表格,显示从mysql中的2个不同表格中提取的数据。该表格的每一行都有一个删除按钮,当按下该按钮时,会发送一个删除查询,该查询会删除该行,以及所有相关的数据来自数据库。

但是,无论我点击哪个删除按钮,它始终是表中删除的最后一行,而不是删除按钮所在的行。

我的表:

-------------------------------------------
|Username|Password|Branch Name|Branch Info|
----------------------------------------------------
|Sub1    |Pass1   |branch1    |1st branch |DELETE  |
----------------------------------------------------
|Sub2    |Pass2   |branch2    |2nd branch |DELETE  |<---this button is pressed
----------------------------------------------------
|Sub3    |Pass3   |branch3    |3rd branch |DELETE  |
----------------------------------------------------
|Sub4    |Pass4   |branch4    |4th branch |DELETE  |
----------------------------------------------------
|Sub5    |Pass5   |branch5    |5th branch |DELETE  |<---this row is deleted.
----------------------------------------------------

我的代码:

<?PHP
session_start();

if(@$_SESSION['Auth']!=="Yes" AND @$_SESSION['Type']!=="Admin")
{
echo"You are not authorised to view this page.Please click <a href='Login.php'>here</a> to login.";
exit();
}
?>

<?PHP

if(@$_POST['deluser']=="Delete")
{
include("cxn.inc");
print_r($_POST);
$id="$_POST[id]";
echo"$id";
if(empty($_POST["id"]))
echo"yep";
$deluser="DELETE FROM SubUsers WHERE SubUsers.id='$id'";
$delquery=mysqli_query($cxn,$deluser) or die (mysqli_error($cxn));
$delsuccess="Deletion successful";
}
>

<html>
<head><link rel="stylesheet" type="text/css" href="style.css" /></head>
<body>


<?PHP
include("cxn.inc");
//include("AdminNav.php");
$viewuser="SELECT SubUsers.Id,Username,Password,Name,Info FROM SubUsers,Branch WHERE SubUsers.id=Branch.id AND SubUsers.Userid='$_SESSION[UserId]'";
$runuser=mysqli_query($cxn,$viewuser) or die(mysqli_error($cxn));
$rows=array();
while($row=mysqli_fetch_assoc($runuser))
$rows[]=$row;
echo"<form action='$_SERVER[PHP_SELF]' name='DelUser' method='POST' >";
echo"<table border='1'>";
echo"<tr>";
echo"<td>";
echo"Username";
echo"</td>";
echo"<td>";
echo"Password";
echo"</td>";
echo"<td>";
echo"Branch Name";
echo"</td>";
echo"<td>";
echo"Branch Info";
echo"</td>";
echo"</tr>";
foreach($rows as $row)
{
$id=$row['Id'];
echo"$id";
echo"<tr>";
echo"<td>";
echo"$row[Username]";
echo"</td>";
echo"<td>";
echo"$row[Password]";
echo"</td>";
echo"<td>";
echo"$row[Name]";
echo"</td>";
echo"<td>";
echo"$row[Info]";
echo"</td>";
echo"<td>";
echo"<input type='hidden' name='id' value='$id' >";
echo"<input type='Submit' name='deluser' value='Delete' >";
echo"</td>";
echo"</tr>";
}
echo"<tr>";
echo"<td colspan='5'>";
if(isset($delsuccess))
{echo"$delsuccess";}

echo"</td>";
echo"</tr>";
echo"</table>";
echo"</form>";
?>
</body>
</html>

该行

回声 “$ ID”;

foreach循环下的

在每行输出到屏幕时成功正确返回每行的id。

按DELETE按钮,行

print_r($_POST);

输出$ _POST中的所有变量,得到结果

Array ( [id] => x [deluser] => Delete ) 

其中x是表格中最后一行的id(例如,如果表格中有5行,x = 5)

问题 的 为什么DELETE按钮只传递最后一行的id,而不是它所在的行的id?还有,我该如何以及如何做到这一点使得当按下删除按钮时,只有行删除按钮旁边是否已删除?

过去2个小时我一直在看这个,但仍然无法弄清楚我错在哪里;当按下删除按钮时,代码显然正在删除行,但只是删除了错误的行。

非常感谢任何帮助。 感谢

5 个答案:

答案 0 :(得分:1)

您永远不会关闭表单,因此会使用分配给ID的最后一个值。

每个删除按钮都需要是单独的表单

另请注意,echo可以使用多行

//Remove start of form from here.
echo"<table border='1'>";
echo"<tr>";
echo"<td>";
echo"Username";
echo"</td>";
echo"<td>";
echo"Password";
echo"</td>";
echo"<td>";
echo"Branch Name";
echo"</td>";
echo"<td>";
echo"Branch Info";
echo"</td>";
echo"</tr>";
foreach($rows as $row)
{
$id=$row['Id'];
echo"$id";
echo"<tr>";
echo"<td>";
echo"$row[Username]";
echo"</td>";
echo"<td>";
echo"$row[Password]";
echo"</td>";
echo"<td>";
echo"$row[Name]";
echo"</td>";
echo"<td>";
echo"$row[Info]";
echo"</td>";
echo"<td>";
    //form isnt needed till here.
    echo"<form action='$_SERVER[PHP_SELF]' name='DelUser' method='POST' >";
echo"<input type='hidden' name='id' value='$id' >";
    //Line below has changed.
echo"<input type='Submit' name='deluser' value='Delete' ></form>";
echo"</td>";
echo"</tr>";
}
echo"<tr>";
echo"<td colspan='5'>";

答案 1 :(得分:1)

提交按钮发送整个表单,而不仅仅是最近的输入。所以你发送表中的每个id和按下按钮的值。由于每个隐藏的输入都有一些名称,$_POST中的变量被覆盖并且等于最后一个值。

您要为每一行创建单独的表单,以确保只发送一个id(可能会使您的html更大),或者从隐藏的输入中退出并更改您的删除按钮名称以包含所需的ID:

echo "<input type='submit' name='deluser[$id]' value='Delete'>";

有了这个,你的帖子将如下所示:

$_POST['deluser'] = array(7 => 'Delete');

仅发送按下按钮的值。您可以在php中轻松访问此ID:

if (isset($_POST['deluser'])) {
    $id_to_delete = key($_POST['deluser']);
}

如果您不关心IE版本的用户,可以使用button元素而不是提交:

echo "<button type='submit' name='deluser' value='$id'>Delete</button>";

使用此功能,只需$_POST['deluser']即可访问ID。

答案 2 :(得分:0)

如果我理解正确,你将在隐藏字段id上有n(n是记录数)声明。这可能只需要最后一个。因此,为了使其正常工作,您需要确保选择了正确的隐藏字段。

将其添加到删除功能中,创建具有id incorperated的字段。

答案 3 :(得分:0)

你有一个表格用于所有id

<?PHP
include("cxn.inc");
//include("AdminNav.php");

?>


<table border='1'>
<tr>
<td>Username</td>
<td>Password</td>
<td>Branch Name</td>
<td>Branch Info</td>
</tr>


<?php
$viewuser="SELECT SubUsers.Id,Username,Password,Name,Info FROM SubUsers,Branch WHERE SubUsers.id=Branch.id AND SubUsers.Userid='$_SESSION[UserId]'";
$runuser=mysqli_query($cxn,$viewuser) or die(mysqli_error($cxn));
while($row=mysqli_fetch_assoc($runuser)){
$id=$row['Id'];

echo"<form action='$_SERVER[PHP_SELF]' name='DelUser' method='POST' >";
echo"<tr>";
echo"<td>";
echo"$row[Username]";
echo"</td>";
echo"<td>";
echo"$row[Password]";
echo"</td>";
echo"<td>";
echo"$row[Name]";
echo"</td>";
echo"<td>";
echo"$row[Info]";
echo"</td>";
echo"<td>";
echo"<input type='hidden' name='id' value='$id' >";
echo"<input type='Submit' name='deluser' value='Delete' >";
echo"</td>";
echo"</tr>";
echo"</form>";
echo"<tr>";
echo"<td colspan='5'>";
if(isset($delsuccess))
{echo"$delsuccess";}
echo"</td>";
echo"</tr>";
}
?>
</table>

答案 4 :(得分:0)

尝试根据所选的ID进行删除,这样可以解决您的问题。例如,如果要删除sub2,它将在db中具有id。例如: -

<form name="form3" id="form3" action="delete_xyz.php" method="get" onsubmit="return check();">
      <input type="image" src="../images/delete.png" type="submit" id="submit" value="Delete"  title="Deletes Selected Product" style="cursor:pointer" />
      <input type="hidden" name="delete" id="delete"  value="<?php echo $row['Complain_id']; ?>"/>
</form>