Android按钮不起作用

时间:2013-05-20 00:42:11

标签: android button android-activity

好吧所以我正在制作一个应用程序只是为了在屏幕上弹出一个随机数字的乐趣。如果您点击与随机数相同的数字按钮,您将得到一个点,如果您点击数字不正确的按钮,您将失去一个点。抓住你只有10秒的得分。无论如何,我有两个主要问题的应用程序。当您点击正确的按钮时,您的分数不会上升。但是,如果您点按不正确的按钮,分数将会下降。我发现这很奇怪。此外,我在计时器用完后设置内容视图时遇到问题,告诉玩家他/她是否赢了。我是否需要创建单独的活动来设置新的内容视图,或者我是否有其他错误?

感谢您的帮助!

这是我的活动类:

package ab.game.crazynumbers;

import java.util.Random;
import java.util.Timer;
import java.util.TimerTask;

import android.app.Activity;
import android.os.Bundle;
import android.os.Handler;
import android.view.MotionEvent;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;

public class Level1Activity extends Activity {

Random r;
Timer t;
int random;
double time;
boolean running = false;
TextView showingnumber;
TextView score;
TextView timer;
Handler handler;
Button b1;
Button b2;
Button b3;
Button b4;
Button b5;
Button b6;
Button b7;
Button b8;
Button b9;
Button b0;
int playerscore;
TextView finalscore;
TextView finalscore2;

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.level_1);

    playerscore = 0;

    showingnumber = (TextView) findViewById(R.id.game_number);
    score = (TextView) findViewById(R.id.game_score);
    timer = (TextView) findViewById(R.id.game_timer);
    finalscore = (TextView) findViewById(R.id.finalscore);
    finalscore2 = (TextView) findViewById(R.id.finalscore2);

    running = true;
    time = 10.0;

    b0 = (Button) findViewById(R.id.b1_0);
    b1 = (Button) findViewById(R.id.b1_1);
    b2 = (Button) findViewById(R.id.b1_2);
    b3 = (Button) findViewById(R.id.b1_3);
    b4 = (Button) findViewById(R.id.b1_4);
    b5 = (Button) findViewById(R.id.b1_5);
    b6 = (Button) findViewById(R.id.b1_6);
    b7 = (Button) findViewById(R.id.b1_7);
    b8 = (Button) findViewById(R.id.b1_8);
    b9 = (Button) findViewById(R.id.b1_9);

    randomnumber();

    b1.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (1 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (1 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;

        }
    });

    b2.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (2 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (2 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b3.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (3 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (3 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b4.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (4 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (4 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b5.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (5 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (5 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b6.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (6 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (6 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b7.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (7 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (7 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b8.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (8 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (8 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b9.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (9 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (9 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    b0.setOnTouchListener(new View.OnTouchListener() {

        public boolean onTouch(View v, MotionEvent e) {

            if (e.getAction() == android.view.MotionEvent.ACTION_UP) {

                if (0 == random) {
                    playerscore++;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }

                if (0 != random) {
                    playerscore--;
                    runOnUiThread(new Runnable() {
                        public void run() {
                            score.setText("Your Score Is " + playerscore);
                        }
                    });
                    randomnumber();
                }
            }

            return false;
        }
    });

    startTimer();

}

public void startTimer() {

    Timer t = new Timer("Game Timer");

    handler = new Handler();

    t.scheduleAtFixedRate(new TimerTask() {

        @Override
        public void run() {

            if (time > 0) {

                time -= 0.1;

                time = Math.round(time * 10.0) / 10.0;

                runOnUiThread(new Runnable() {
                    public void run() {
                        timer.setText("Seconds Remaining: " + time);
                    }
                });

            }

            if (time <= 0) {
                this.cancel();
                if (playerscore >= 10) {
                    setContentView(R.layout.win);
                    runOnUiThread(new Runnable() {
                        public void run() {
                            finalscore.setText("Your Final Score Is "
                                    + playerscore);
                        }
                    });
                    try {
                        Thread.sleep(1000);
                    } catch (InterruptedException e) {
                        e.printStackTrace();
                    }
                }
                if (playerscore < 10) {
                    setContentView(R.layout.lose);
                    runOnUiThread(new Runnable() {
                        public void run() {
                            finalscore2.setText("Your Final Score Is "
                                    + playerscore);
                        }
                    });
                    try {
                        Thread.sleep(1000);
                    } catch (InterruptedException e) {
                        e.printStackTrace();
                    }
                }
                finish();
            }

        }

    },

    // time before start of timer
            0,

            // time before it runs again
            100);

}

public void randomnumber() {

    r = new Random();
    random = r.nextInt(10);

    runOnUiThread(new Runnable() {
        public void run() {
            showingnumber.setText(String.valueOf(random));
        }
    });

}

}

这是我的XML:

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical" >

<TextView
    android:id="@+id/game_timer"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:gravity="center"
    android:text="Seconds Remaining: 0.0"
    android:textAppearance="?android:attr/textAppearanceLarge" />

<TextView
android:id="@+id/game_score"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:layout_alignParentBottom="true"
android:layout_alignParentLeft="true"
android:gravity="center"
android:text="Your Score Is 0"
android:textAppearance="?android:attr/textAppearanceLarge" />

<Button
    android:id="@+id/b1.4"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignLeft="@+id/b1.1"
    android:layout_alignTop="@+id/b1.1"
    android:layout_marginTop="73dp"
    android:text="4" />

<TextView
    android:id="@+id/game_number"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_below="@+id/game_timer"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="89dp"
    android:gravity="center"
    android:text="0"
    android:textAppearance="?android:attr/textAppearanceMedium" />

<Button
    android:id="@+id/b1.1"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignParentLeft="true"
    android:layout_below="@+id/game_number"
    android:layout_marginLeft="14dp"
    android:layout_marginTop="130dp"
    android:text="1" />

<Button
    android:id="@+id/b1.7"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_above="@+id/game_score"
    android:layout_alignLeft="@+id/b1.4"
    android:layout_marginBottom="15dp"
    android:text="7" />

<Button
    android:id="@+id/b1.2"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.1"
    android:layout_alignBottom="@+id/b1.1"
    android:layout_centerHorizontal="true"
    android:text="2" />

<Button
    android:id="@+id/b1.5"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.4"
    android:layout_alignBottom="@+id/b1.4"
    android:layout_centerHorizontal="true"
    android:text="5" />

<Button
    android:id="@+id/b1.8"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.7"
    android:layout_alignBottom="@+id/b1.7"
    android:layout_centerHorizontal="true"
    android:text="8" />

<Button
    android:id="@+id/b1.0"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_above="@+id/b1.2"
    android:layout_alignLeft="@+id/b1.2"
    android:layout_marginBottom="18dp"
    android:text="0" />

<Button
    android:id="@+id/b1.6"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.4"
    android:layout_alignBottom="@+id/b1.4"
    android:layout_alignParentRight="true"
    android:layout_marginRight="20dp"
    android:text="6" />

<Button
    android:id="@+id/b1.9"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.7"
    android:layout_alignBottom="@+id/b1.7"
    android:layout_alignLeft="@+id/b1.6"
    android:text="9" />

<Button
    android:id="@+id/b1.3"
    android:layout_width="80dp"
    android:layout_height="50dp"
    android:layout_alignBaseline="@+id/b1.1"
    android:layout_alignBottom="@+id/b1.1"
    android:layout_alignLeft="@+id/b1.6"
    android:text="3" />

</RelativeLayout>

3 个答案:

答案 0 :(得分:0)

我看到了你的代码,我在你的代码中发现了两个问题。  1.你应该提取监听器,为每个按钮编写它是非常愚蠢的。  2.在andoid中,不允许在其他线程中操作UI,你应该使用Handle

我是中国人,我的英语很差

答案 1 :(得分:0)

您的if使用错误。正确选择按钮后,您将生成下一个号码并再次检查是否random!=that_button_number。它几乎每次都会发生,所以它会降低你的分数。

     if (random == 3) {randomNumber()}else{}

if(random==3){
      randomNumber();
  };     
if(random!=3){};

您无法在应用程序的运行时调用setContentView。你会得到RuntimeException。你可以:

  • 隐藏一个布局,按setVisibility
  • 显示新内容
  • 使用Frame layout
  • 许多其他内容,例如片段交易或附加新视图

答案 2 :(得分:0)

您在分数增加后立即生成一个随机数,因此它会上升但在您点击下一个if

之后又会退回
if (1 == random) {
                playerscore++;
                runOnUiThread(new Runnable() {
                    public void run() {
                        score.setText("Your Score Is " + playerscore);
                    }
                });
                randomnumber();  // there is a new nunmber
            }

            if (1 != random) {  // this should be an else
                playerscore--;
                runOnUiThread(new Runnable() {
                    public void run() {
                        score.setText("Your Score Is " + playerscore);
                    }
                });
                randomnumber();

我已在您遇到问题的上述代码中添加了注释

  

此外,我在计时器用完后设置内容视图时遇到问题,告诉玩家他/她是否赢了。我是否需要创建单独的活动来设置新的内容视图,或者我是否有其他错误?

不知道你有什么问题很难说。但这可以做到。不过,我建议您使用AlertDialog,或者您可以Activity

theme Dialog创建一个单独的manifest

此外,你可以只为所有Buttons使用一个监听器,因为它们都做了几乎相同的事情,在xml中通过为所有这些设置onClick函数设置相同

<Button
    android:id="@+id/button1
    ...
    android:onClick="functionName"/>

然后在java

public void functionName(View v)
{
     // v is the button that was clicked
}

或在java中实现你的监听器,在这里onClick,用

button1.setOnClickListener(this);  // do this for each
public void onClick(View v)
{
    // v is still the button clicked
}

然后获取单击按钮的文本并将其与随机数

进行比较