如何从模型中删除验证重复?

时间:2013-05-15 13:31:28

标签: ruby-on-rails ruby refactoring duplicate-removal

如果没有将送货地址和帐单地址提取到地址模型中,我该如何删除此验证重复?

我只想验证帐单邮寄地址,如果它与送货地址不同。我该如何将其提取到模块中?一个例子真的很有帮助,因为我永远不知道在模块中包含什么,或者self指的是。

  validates :shipping_name, :shipping_address1, :shipping_street_number, :shipping_city, presence: true
  validates :shipping_state, inclusion: { in: Address.states.values }
  validates :shipping_post_code, length: { is: 5 }, numericality: { only_integer: true }

  validates :billing_name, :billing_address1, :billing_street_number, :billing_city, presence: true, unless: -> { self.bill_to_shipping_address? }
  validates :billing_state, inclusion: { in: Address.states.values }, unless: -> { self.bill_to_shipping_address? }
  validates :billing_post_code, length: { is: 5 }, numericality: { only_integer: true }, unless: -> { self.bill_to_shipping_address? }

1 个答案:

答案 0 :(得分:1)

您可以创建一个方法,然后传入两种类型地址之间不同的位。在这种情况下,差异是字段的前缀字和传递额外选项的能力。

module AddressValidator
  def validates_address(type, options = {})
    validates :"#{type}_name", :"#{type}_address1", :"#{type}_street_number", :"#{type}_city", {presence: true}.merge(options)
    validates :"#{type}_state", {inclusion: { in: Address.states.values }}.merge(options)
    validates :"#{type}_post_code", {length: { is: 5 }, numericality: { only_integer: true }}.merge(options)
  end
end

class MyModel < ActiveRecord::Base
  extend AddressValidator
  validates_address(:shipping)
  validates_address(:billing, unless: -> { self.bill_to_shipping_address? })
end