Question

正如标题所述，我第一次使用函数，我很难将它们应用到刽子手游戏中。根据我有限的知识，我假设我的变量范围是函数调用无法实现的。鉴于我完全没有书，我觉得我已经碰壁了。我在考虑可能会使用全局变量，但是再一次，我正在研究的这一章只给了我一些有限的理解。我也有srand问题（时间（0））;出于某种原因。任何帮助将不胜感激，并提前感谢。

// HangMan Game
// With Functions

#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <ctime>
#include <cctype>

using namespace std;

char playerGuess();
char guessInWord();

int main()
{
    //setup
    const int MAX_WRONG = 8;//max wrong will be set at 8

    vector<string> words; //collection of possible words to guess
    words.push_back ("DAFTPUNK");
    words.push_back ("ELSALVADOR");
    words.push_back ("HIPHOP");

    srand(time(0));
    random_shuffle(words.begin(), words.end());
    const string THE_WORD = words[0];            //word to guess
    int wrong = 0;                               //number of incorrect guesses
    string soFar(THE_WORD.size(), '-');          //word guessed so far
    string used = "";                            //letters already guessed

    cout << "Welcome to Hangmam. Good luck!\n";

    //main loop
    while ((wrong < MAX_WRONG) && (soFar != THE_WORD))
    {
        cout << "\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
        cout << "\nYou've used the following letters:\n" << used << endl;
        cout << "\nSo far, the word is:\n" << soFar << endl;

        char guess = playerGuess(); //call to function 1

        used += guess;

        guessInWord();              //call to function 2
    }

    //shut down
    if(wrong == MAX_WRONG)
        cout << "\nYou've been hanged!";
    else
        cout << "\nYou guessed it!";

    cout << "\nThe Word was " << THE_WORD << endl;

    return 0;
}

//function Definitions 1
char playerGuess()
{
    char letter;
    cout << "\n\nEnter your guess: ";
    cin >> letter;
    letter = toupper(letter); //makes uppercase of letter
    while (used.find(letter) != string::npos)
    {
        cout <<"\nYou've already guessed " << letter << endl;
        cout <<"Enter your guess: ";
        cin >> letter;
        letter = toupper(letter);
    }
    return letter;
}

//function Definitions 2
void guessInWord()
{
    if (THE_WORD.find(guess) != string::npos)
    {
        cout << "That's right! " << guess << " is in the word.\n";

        //update soFar to Include newly guessed letter
        for (int i = 0; i < THE_WORD.length(); ++i)
            if (THE_WORD[i] == guess)
                soFar[i] = guess;
    }
    else
    {
        cout << "Sorry, " << guess << " isn't in the word.\n";
        ++wrong;
    }
}

Answer 1

你的功能原型应该与它的实现不同：

void guessInWord();  ------> char guessInWord();
^^^^                         ^^^^

让这些全球化（我个人不喜欢全球化），因为你在其他功能中使用它们：

vector<string> words;
string used;
string THE_WORD;
int wrong;
string soFar;
char guess;

你肯定会遇到运行时错误或逻辑问题。继续......

char playerGuess();
char guessInWord();

vector<string> words;
string used = "";
string THE_WORD;
int wrong = 0;
string soFar(THE_WORD.size(), '-');
char guess;

int main()
{
    const int MAX_WRONG = 8;

    words.push_back("DAFTPUNK");
    words.push_back("ELSALVADOR");
    words.push_back("HIPHOP");

    THE_WORD = words[0];

    srand(time(0));
    random_shuffle(words.begin(), words.end());

    cout << "Welcome to Hangmam. Good luck!\n";

    while ((wrong < MAX_WRONG) && (soFar != THE_WORD))
    {
        cout << "\nYou have " << (MAX_WRONG - wrong) << " incorrect guesses left.\n";
        cout << "\nYou've used the following letters:\n" << used << endl;
        cout << "\nSo far, the word is:\n" << soFar << endl;

        guess = playerGuess();
        used += guess;
        guessInWord();
    }

    if (wrong == MAX_WRONG)
        cout << "\nYou've been hanged!";
    else
        cout << "\nYou guessed it!";

    cout << "\nThe Word was " << THE_WORD << endl;

    return 0;
}

char playerGuess()
{
    char letter;
    cout << "\n\nEnter your guess: ";
    cin >> letter;
    letter = toupper(letter); //makes uppercase of letter
    while (used.find(letter) != string::npos)
    {
        cout << "\nYou've already guessed " << letter << endl;
        cout << "Enter your guess: ";
        cin >> letter;
        letter = toupper(letter);
    }
    return letter;
}

char guessInWord()
{
    if (THE_WORD.find(guess) != string::npos)
    {
        cout << "That's right! " << guess << " is in the word.\n";

        for (int i = 0; i < THE_WORD.length(); ++i)
            if (THE_WORD[i] == guess)
                soFar[i] = guess;
    }
    else
    {
        cout << "Sorry, " << guess << " isn't in the word.\n";
        ++wrong;
    }
}

C ++第一次使用函数

1 个答案: