跟进:GitHub的礼仪贡献,拉请求与新问题

时间:2013-04-19 20:31:51

标签: github pull-request etiquette

作为Etiquette of GitHub Contributing, Pull Requests vs New Issue的后续内容:

将拉取请求提交给全部准备好的代码段的“礼仪”方法是什么?

考虑:

Author A - owns the repo for TowerApp.
Author B - forks TowerApp, creates a new feature - ElevatorModule, 
             then submits a pull request.    
Author A - likes the ElevatorModule pull request so he/she merges it
Author C - finds Author A's TowerApp and wants to update ElevatorMusic in 
             ElevatorModule that was recently merged from Author B's 
             pull request.

作者C做了什么?

  • Fork作者B的回购和'拉请求'对作者B的更新

  • Fork Author A的repo和'pull request'更新作者A

1 个答案:

答案 0 :(得分:1)

由于 B 最终向 A 提交了拉取请求, TowerApp 看起来像是主要的上游存储库。

我会选择 A 的回购并通知 B 拉取请求,以便让他保持在循环中。

例如:

"This adds ElevatorMusic feature to @B's awesome work with the ElevatorModule"

这将允许 B 加入并审核/评论拉取请求。