是一种写入记录器纯粹的方法吗?

时间:2013-04-15 07:21:46

标签: c# attributes

纯方法定义为“does not make any visible state changes”。

如果一个参数为null或抛出异常,我的方法是编写日志消息。它还是纯净的吗?写入记录器是否有明显的变化?

以下是代码:

    /// <summary>
    /// Formats with invariant culture - won't throw an exception.
    /// </summary>
    /// <param name="format">A composite format string.</param>
    /// <param name="args">An object array that contains zero or more objects to format.</param>
    /// <returns>A copy of format in which the format items have been replaced by the string representation of the corresponding objects in args.</returns>
    [SuppressMessage("Microsoft.Globalization", "CA1303:Do not pass literals as localized parameters", MessageId = "CyanCor.Core.Logging.Log.ExceptionPrevent(System.String,System.String,System.Int32,System.String)", Justification = "It is for the logger (riedl)")]
    [Pure - yes or no?]
    public static string FormatSafe(this string format, params object[] args)
    {
        if (format == null)
        {
            Log.ExceptionPrevent("Argument format is null");
            return NullFormat;
        }

        try
        {
            return string.Format(CultureInfo.InvariantCulture, format, args);
        }
        catch (ArgumentException exc)
        {
            Log.Exception(exc);
            return format;
        }
        catch (FormatException exc)
        {
            Log.Exception(exc);
            return format;
        }
    }

1 个答案:

答案 0 :(得分:5)

通常,“状态改变”意味着修改对象的状态,即。修改变量或更改复杂对象的结构。按照这个定义,你的方法似乎仍然是纯粹的。