创建操作中的ArgumentError,错误的参数数量(3表示1)

时间:2013-04-10 23:50:00

标签: ruby-on-rails ruby-on-rails-3

我正在使用omniauth gem来允许用户注册/登录我的rails应用程序

这是我的gemfile的一部分

gem 'omniauth'
gem 'omniauth-twitter'
gem 'twitter'

Omniauth =是v1.1.4, Omniauth-twtter是v0.0.16, Omniauth-oauth是v1.0.1, Twitter是4.6.2

我遇到了类似错误wrong number of arguments (3 for 1) after upgrading rails from 3.1.1 to 3.1.3的这个帖子,所以我尝试卸载Omniauth并降级到版本“〜> 0.2.6”,但我收到了这条消息:

该捆绑包目前已将omniauth锁定为1.1.4。 omn​​iauth版本是问题的原因还是其他什么?

当我尝试使用Twitter登录时,我正在尝试解决的错误消息

ArgumentError in AuthenticationsController#create
wrong number of arguments (3 for 1)

app/helpers/sessions_helper.rb:4:in `sign_in'
app/controllers/authentications_controller.rb:12:in `create'

这是我的authentications_controller.rb

class AuthenticationsController < InheritedResources::Base

def index
    @authentications = current_user.authentications if current_user
end

def create
  omniauth = request.env['omniauth.auth']
  authentication = Authentication.find_by_provider_and_uid(omniauth['provider'], omniauth['uid'])
  if authentication
     flash[:notice] = "Signed in successfully"
     sign_in_and_redirect(:user, authentication.user)
  elsif current_user
   token = omniauth['credentials'].token
   secret = omniauth['credentials'].token
   current_user.authentications.create!(:provider => omniauth['provider'], :uid => omniauth['uid'], :token => token, :secret => token_secret)
   flash[:notice] = "Authentication successful"
   redirect_to authentications_url
   else
    user = User.new
    user.apply_omniauth(omniauth)
    if user.save!
    flash[:notice] = "Signed in successfully"
     sign_in(:user, authentication.user)
   else
    session[:omniauth] = omniauth.except('extra')
    redirect_to '/signup'
   end
end
end

def destroy
    @authentication = current_user.authentications.find(params[:id])
    @authentication.destroy
    flash[:notice] = "Successfully destroyed authentication"
    redirect_to authentications_url

end
end

这是我的sessions_helper.rb

module SessionsHelper

  def sign_in(user)
    cookies.permanent[:remember_token] = user.remember_token
    current_user = user
  end

  def sign_in_and_redirect(user)
    redirect_to root_path
  end

这是我的sessions_controller.rb

class SessionsController < ApplicationController
  def create
    user = User.find_by_email(params[:session][:email])
    if user && user.authenticate(params[:session][:password])
      sign_in user
      redirect_to root_url
    else
      flash.now[:error] = "Invalid email/password combination"
      render 'new'
    end
  end

这是user.rb模型

class User < ActiveRecord::Base
  attr_accessible :name, :email, :password, :password_confirmation
  has_secure_password
  has_many :authentications

  before_save { |user| user.email = user.email.downcase }
  before_save :create_remember_token
  before_validation :no_password_omniauth
  validates_uniqueness_of :name, { case_sensitive: false }
  validates :name,  presence: true, length: { maximum: 50 }
  VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i
  validates :email, presence: true, format: { with: VALID_EMAIL_REGEX },
                    uniqueness: { case_sensitive: false }
  validates :password, length: { minimum: 6 }
  validates :password_confirmation, presence: true

  @called_omniauth = false

  def apply_omniauth(omniauth)
 authentications.build(:provider => omniauth['provider'],
 :uid => omniauth['uid'],
 :token => omniauth['credentials'].token,
 :secret => omniauth['credentials'].secret)
 @called_omniauth = true
 self.email = "test@example.com"
 self.name = omniauth['info']['name']
 self.password = self.password_confirmation = "password"
 end

  def password_required
    return false if @called_omniauth == true
    (authentications.empty? || !password.blank?)
end


  def twitter
unless @twitter_user
provider = self.authentications.find_by_provider('twitter')
@twitter_user = Twitter::Client.new(:oauth_token => provider.token, :oauth_token_secret => provider.secret) rescue nil
end
@twitter_user
end


  private

    def create_remember_token
      self.remember_token = SecureRandom.urlsafe_base64
    end

    def apply_twitter(omniauth)
if (extra = omniauth['extra']['user_hash'] rescue false)
# Example fetching extra data. Needs migration to User model:
# self.firstname = (extra['name'] rescue '')
end
end

def no_password_omniauth
  self.password_digest = SecureRandom.urlsafe_base64 unless password_required
end


def hash_from_omniauth(omniauth)
{
:provider => omniauth['provider'],
:uid => omniauth['uid'],
:token => omniauth['credentials']['token'],
:secret => omniauth['credentials']['secret']
}
end
end

最后,这是users_controller.rb

class UsersController < ApplicationController
  before_filter :signed_in_user,
                only: [:index, :edit, :update, :destroy]
  before_filter :correct_user,   only: [:edit, :update]
  before_filter :admin_user,     only: :destroy

def create
    @user = User.new(params[:user])
    if @user.save
      sign_in @user
      flash[:success] = "Welcome"
      redirect_to root_url
    else
      render 'new'
    end
  end

  def edit
  end

1 个答案:

答案 0 :(得分:0)

你已经定义了sign_in_and_redirect只接受一个参数 - 但是你传递了两个参数。

因此,控制器中的sign_in_and_redirect(:user, authentication.user)可能会变为sign_in_and_redirect(authentication.user)

但值得注意的是两件事:

  • 您的sign_in_and_redirect方法实际上并未对用户进行签名,只是重定向它们。
  • 如果您正在使用Devise,那么您将使用以下签名定义具有该名称的方法:sign_in_and_redirect(resource_or_scope, *args)。我建议使用他们的方法(如果你使用Devise与OmniAuth)或命名你的方法别的东西,以避免冲突和混乱。

[实际上,我的分析可能有点偏差,因为堆栈跟踪指向你的sign_in方法,而不是sign_in_and_redirect - 堆栈跟踪中的行号是否对你共享的代码是准确的,或者你删除了一些代码?]