调用mongoose save方法时挂起的async.js的瀑布方法

时间:2013-03-25 10:08:54

标签: javascript node.js asynchronous express mongoose

我正在尝试使用async waterfall method但是当它到达其中一个函数时,它会挂起。我怀疑这是因为save()操作对于执行上下文来说太慢了,但这就是为什么我开始使用async的瀑布,所以我可以等待返回的值,直到它转到系列中的下一个函数(传递使用它的正确数据,在我的情况下是counted。)

//在我的用户控制器中:

async.waterfall([
  function(callback) {
    getSubmission(id, function(submission) {
      if (submission) {
        callback(null, submission);
      }
    });
  },
  function(submission, callback) {
    var submissionId = submission._id;

    getViews(submissionId, ip, function(count) {
      if (count) {
        callback(null, count, submissionId);
      }
    });
  },
  // Those top two functions work perfectly passing what
  // I need to this one which is where I'm having trouble
  function(views, submissionId, callback) {
    // addView is called because it is actually
    // inserting a row in the db, but never returns from the caller
      addView(submissionId, ip, function(added) {
        // this callback doesn't fire
        if (added) {
          callback(null, added);
        }
      });
  },
  function(added, callback) {
    console.log(added);
  }
 ]);

这是addView()的内容(也在用户控制器中,也就是前一个async.waterfall代码所在的位置):

var addView = function(submissionId, ip, callback) {
  Submission.addView({
    submissionId : submissionId,
    ip: ip
  }, function(err, counted) {
    if (err) {
      throw err;
    }

    if (counted) {
      callback(counted);
    }
  });
};

这是它调用Submission.addView()时调用的内容(在我的Submission模型文件中):

exports.addView = function(obj, fn) {
  var ip = obj.ip,
      submissionId = obj.submissionId,
      submissionView = new SubmissionView(obj);
// it gets to this point

  submissionView.save({
    ip : ip,
    submission_id : submissionId
  }, function(err, counted) {
    fn(err, counted);
  });
};

1 个答案:

答案 0 :(得分:4)

每当异步"挂起"时,通常是因为没有调用回调。

您需要确保在所有代码路径中调用回调。我还建议你保留任何异步回调的第一个参数是一个错误,即使你不使用它,因为这是整个node.js使用的模式。有些模块依赖于这种模式。例如域。

如果您进行以下更改,那么我希望在某处出现一些错误:

getSubmission(id, function(submission) {
      if (submission) {
        callback(null, submission);
      }
    });

应该是这样的:

getSubmission(id, function(err, submission) {
      if(err){
        return callback(err);
      }
      if (!submission) {
        return callback('no submission found');
      }
      callback(null, submission);
    });
相关问题