方法不会从数组中提取正确的数据

时间:2013-03-24 22:12:22

标签: c# arrays for-loop

所以基本上发生了什么是我的代码编译并运行良好。但是当它运行时,为minScore和minName变量存储的值保持为0

static void Main(string[] args)
{
   int count = 0;
   string[] names = new string[MAX_SIZE];
   int[] scores = new int[MAX_SIZE];

   string name;
   int sum = 0;
   int minScore = 0;
   int maxScore = 0;
   string minName = string.Empty;
   string maxName = string.Empty;
   string input;
   int score;

   Console.WriteLine("===============Saturday Night Coders================");
   Console.WriteLine("===============Bowling Score Program================");

   for (int i = 0; i < MAX_SIZE; i++)
   {
      Console.WriteLine("\n Please Enter a name and a score separated by a space");
      Console.WriteLine("Enter a blank line when finished");

      input = Console.ReadLine();

      if (input == "")
      {
         count = i;
         Console.WriteLine("===========INPUT COMPLETE=========");
         break;
      }

      string[] splitInput = input.Split();

      name = splitInput[0];
      score = int.Parse(splitInput[1]);
      scores[i] = score;
      names[i] = name;
      sum += score;
      if (minScore >= score)
      {
         minScore = score;
         minName = name;
      }

      if (maxScore <= score)
      {
         maxScore = score;
         maxName = name;
      }
      count = i + 1;
    }

      double average = sum / count;
      Console.WriteLine("Here are the scores for this game");
      PrintScores(names, scores, count);
      Console.WriteLine("Congratulations {0}, your score of {1} was the highest",maxName, maxScore);
      Console.WriteLine("{0} , your score of {1} was the lowest, Maybe you should find a new hobby",minName, minScore);
      Console.WriteLine("\n The team average was {0:f2}", average);
      Console.WriteLine("Press any key to continue...");
      Console.ReadKey();
    }

    static void PrintScores(string[] names, int[] scores, int count)
    {
        for (int i = 0; i < count; i++)
        {
            Console.Write("{0} \t {1}", names[i], scores[i]);
            if (scores[i] == MAX_SCORE)
            {
                Console.WriteLine("*");
            }
            else
            {
                Console.WriteLine("");
            }
            Console.WriteLine();
        }
    }
}

我似乎无法弄清楚为什么for循环适用于maxName和maxScore语句,而不是minName和minScore语句。非常感谢任何帮助

2 个答案:

答案 0 :(得分:5)

而不是这段代码:

 int minScore = 0;
 int maxScore = 0;

使用

是一种更好的做法
 int minScore = int.MaxValue;
 int maxScore = int.MinValue;

因此任何值都小于初始最小值,任何值都大于初始最大值。

答案 1 :(得分:2)

我相信您可能在将默认minScore设置为0时出现了逻辑错误。 如果是这种情况,0永远不会高于或等于0以上的任何得分:

if (minScore >= score)

实际上是

if (0 >= score)

请尝试以下方法:

if (minScore == 0 || minScore >= score)