c ++使用*&作为参数(指针乐趣,叔树方法)

时间:2013-03-19 01:29:39

标签: c++ oop pointers methods

我正在尝试编写一个方法,将一个键值对添加到第三层树,但是当我到达标记的代码时,我显然做错了,因为我得到了一个段错误

void Tree::add(int k, Node *&r)
{
    cout<<"add"<<endl;
    if(r==NULL){
        r = new Node(k);
        //check(heap area);
    }

开始问题代码

    else if(r->keyCount == 1){
        cout<<"adding second key";
        if(r->getKey() < k){
            Node * temp = new Node(r->getKey(),k,r->data[0],0);
            delete r;
            r = temp;
            r->keyCount++;
            cout<<"test"<<endl;
        }
        else
        {
            Node * temp = new Node(k,r->getKey(),0,r->data[0]);
            delete r;
            r = temp;
            r->keyCount++;
            cout<<"test"<<endl;
    }

结束代码

    }
    else if(k < r->getKey())
    {
        cout<<"left"<<endl;
        add(k,r->child[Node::L]);
    }
    else if(r->keyCount > 1 && k < r->getKey(1))
    {
        cout<<"middle"<<endl;
        add(k,r->child[Node::M]);
    }
    else if(r->keyCount > 1 && k > r->getKey(1))
    {
        cout<<"right"<<endl;
        add(k,r->child[Node::R]);
    }
    else
        r = new Node(k);
}

我想要做的是,在这个特定节点中使用的2个密钥中只有1个,用一个新节点替换当前节点,该节点具有适当位置的密钥(较小的val)在key [0]中,key [1]中的val更大 我该怎么做呢?

我的代码显然删除了旧节点的地址和指针,但没有正确地将指针重新分配给新节点。

修改 更新的代码。输出如下:

% p4
Enter pairs consisting of an int and a double. I create a
ternary tree, keeping the data in order, by int. Finish entering
data by pressing ^d
2 2
add
Entering the pair: 2, 2
1 1
add
adding second key to current node
test
Entering the pair: 1, 1
-1 -1
add
left
add
Entering the pair: -1, -1
3 3
add
right
Segmentation Fault

编辑2 如果您想查看所有代码,可以使用包含整个项目的zip链接:http://sdrv.ms/WSrLfv

编辑3 更多错误数据 - 崩溃时从gdb输出

Program received signal SIGSEGV, Segmentation fault.
0x08051628 in getData (x=@0x8047554) at testTree.cc:26
26            x[k]=d;
Current language:  auto; currently c++

编辑4 单步执行gdb到segfault:

Breakpoint 1, Tree::add (this=0x8047554, k=3, r=@0x8047554) at tree.cc:58
58          cout<<"add"<<endl;
(gdb) n
add
61          if(r==NULL){
(gdb) n
65          else if(r->keyCount == 1){
(gdb) n
87          else if(k < r->getKey())
(gdb) n
92          else if(r->keyCount > 1 && k < r->getKey(1))
(gdb) n
97          else if(r->keyCount > 1 && k > r->getKey(1))
(gdb) n
99              cout<<"right"<<endl;
(gdb) n
right
100             add(k,r->child[Node::R]);
(gdb) n

Breakpoint 1, Tree::add (this=0x8047554, k=3, r=@0x806416c) at tree.cc:58
58          cout<<"add"<<endl;
(gdb) n
add
61          if(r==NULL){
(gdb) n
62              r = new Node(k);
(gdb) n
107     }
(gdb) n
107     }
(gdb) n
Tree::operator[] (this=0x8047554, index=3) at tree.cc:47
47          return *(locate(index,root)->data);
(gdb) n
48      }
(gdb) n

Program received signal SIGSEGV, Segmentation fault.
0x08051628 in getData (x=@0x8047554) at testTree.cc:26
26            x[k]=d;
(gdb)

1 个答案:

答案 0 :(得分:2)

这应该有效。

回应你的编辑:我注意到你的输出中有一些有趣的东西:

-1 -1
add
left
add
Entering the pair: -1, -1

注意它是如何说“左”然后由于递归调用而后面说“添加”。但是,在崩溃程序的输入中,您没有看到“添加”之后:

3 3
add
right
Segmentation Fault

如果您查看Tree::locate功能:

Node * Tree::locate(int k, Node *rt) const
{
if(rt==NULL)
    return rt;
if(k==rt->getKey())
    return rt;
if(rt->keyCount>1 && k==rt->getKey(1))
    return rt;
if(k < rt->getKey())
{
    return locate(k,rt->child[Node::L]);
}
else if(rt->keyCount>1 && k < rt->getKey(1))
{
    return locate(k,rt->child[Node::M]);
}
else if(rt->keyCount>1 && k<rt->getKey(1))
{
    return locate(k,rt->child[Node::R]);
}
else
    return NULL;
}

这一行:

else if(rt->keyCount>1 && k<rt->getKey(1))

与前一个条件相同,因此它被完全跳过。