无法更新CakePHP中的现有记录

时间:2013-03-17 08:15:09

标签: cakephp sql-update cakephp-2.0 cakephp-appmodel editmodel

我编写了一个编辑功能来更新用户的信息,我的代码:

if($this->request->is('post')){
                $this->request->data['User']['password']=Security::hash($this->request->data['User']['password'],'sha1', Configure::read('Security.salt'));
                $this->request->data['User']['type'] = '2';
                $this->request->data['User']['username'] = $username;
                //debug($this->request->data);
                if($this->User->validates()){
                    $this->User->set($this->request->data['User']);
                    if ($this->User->save($this->request->data,false)) {
                        $this->Session->setFlash(__('The user has been saved'));
                        $this->redirect($this->root.'index');
                    } else {
                        $this->Session->setFlash(__('The user could not be saved. Please, try again.'));
                    }
                }
            }

但是我检查了这个功能:$ this-> User-> exists()永远不会返回true,在我的情况下,User表键是用户名,当我编辑用户名时,这个功能可以将新信息保存为新记录,但是当我没有编辑用户名时,无法保存新信息,为什么它会像这样工作?如何更正我的功能来编辑记录?

3 个答案:

答案 0 :(得分:0)

相信我,你几乎总是想要在你的表中拥有id。添加它并将其作为主键。

现在它看起来像这样:

if($this->request->is('post')){

    // Think about using AuthComponent:
    // $this->request->data['User']['password'] = AuthComponent::password($this->request->data['User']['password']);
    $this->request->data['User']['password'] = Security::hash($this->request->data['User']['password'],'sha1', Configure::read('Security.salt'));
    $this->request->data['User']['type'] = '2';
    $this->request->data['User']['username'] = $username;
    $this->User->id = $id;

    // Checking if the user exists.
    if(!$this->User->exists()){
        // If not, tell it here.
    }

    if($this->User->validates()){
        if ($this->User->save($this->request->data, false)) {
            $this->Session->setFlash(__('The user has been saved'));
            $this->redirect($this->root.'index');
        } else {
            $this->Session->setFlash(__('The user could not be saved. Please, try again.'));
        }
    }else{
        // Something went wrong.
    }
}

如果您拥有主键的用户名,则每次不同时,CakePHP都会创建新记录。

现在,我将通过AJAX调用给你我的函数read,也许它会帮助你。

// Function for creating and updating users.
    public function update(){

        // If the request is AJAX (from Ext-JS).
        if($this->request->is('ajax')){

            // Prepare data for CakePHP. $this->request->data['ModelName'] => array of data.
            $this->request->data['User'] = $this->request->data;

            // If there is "id" in data, then it's "edit".
            // If there is no "id" in data, then it's "add".
            if($this->request->data['id'] != null){

                // Setting "id" for user so the CakePHP could use "save", "saveAll", "exits" or 
                // any other function for a particular user.
                $this->User->id = $this->request->data['id'];

                // Checking if the user exists.
                if (!$this->User->exists()) {

                    // If there is no user with a given "id", remove the data (security reasons).
                    // Put the "success" and "message" (message) properties.
                    $this->request->data = array();
                    $this->request->data['success'] = false;
                    $this->request->data['message'] = "No user with this id.";

                    // Return the message to Ext-JS.
                    return new CakeResponse(array('body' => json_encode($this->request->data)));
                }

                // List of fields to save.
                $fieldList = array('id', 'first_name', 'last_name', 'username', 'role_id', 'language_id', 'status', 'last_login', 'created', 'modified');

                // Only if there is an password provided by user, save it.
                if($this->request->data['User']['password'] != ''){
                    array_push($fieldList, 'password');
                }

                // If you are here, then there is a user with a given "id" and you are editing that user.
                if ($this->User->save($this->request->data, true, $fieldList)) {

                    // Remove any data except the "success" and "message" (message) properties (security reasons).
                    $this->request->data = array();
                    $this->request->data['success'] = true;
                    $this->request->data['message'] = "The user has been changed.";
                }else {

                    // If you are here, something went wrong with editing a user. Remove the data (security reasons).
                    // Put the "success" and "message" (message) properties.
                    $this->request->data = array();
                    $this->request->data['success'] = false;
                    $this->request->data['message'] = "Error with editing.";
                }
            }else{

                // If you are here, then you are adding a new user (because there is no "id" in data). Create a new row in table.
                $this->User->create();

                // Try to save the user with data from $this->request->data['User'].
                if ($this->User->save($this->request->data)) {

                    // If you are here, then everything is ok. Remove any data and tell that to Ext-JS with "success" and "message" (message) properties.
                    $this->request->data = array();
                    $this->request->data['success'] = true;
                    $this->request->data['message'] = "The user has been added.";
                }else{

                    // If you are here, something probably went wrong with $this->request->data['User'].
                    // Remove any data (security reasons) and tell that to Ext-JS with "success" and "message" (message) properties.
                    $this->request->data = array();
                    $this->request->data['success'] = false;
                    $this->request->data['message'] = "Something went wrong with adding a user.";
                }
            }

            // Return any data to Ext-JS, despite the success.
            // $this->request->data['success'] => (true | false).
            // $this->request->data['message'] => (message for Ext-JS).
            return new CakeResponse(array('body' => json_encode($this->request->data)));
        }
    }

现在,您将return new CakeResponse消息发送给用户,而不是Session

答案 1 :(得分:0)

调试代码

if($this->User->validates()){

在此之前的任何时候,问题中的代码都没有完成以下任何一项:

  • 致电create
  • 在模型上调用set

因此,这里发生的是代码尝试验证空模型对象。假设返回false(如问题所暗示的那样)保存"不工作的原因"是代码是而不是调用save

  

但我检查此功能:$ this-> User-> exists()永远不会返回true

预计,因为没有致电createset或设置User->id财产。

请参阅文档

明确调用validates没关系,但也没必要。 Save已经调用验证 - 因此,如果您的代码工作正常,您需要两次运行验证规则。

使用the book中的此示例作为参考:

public function edit($id) {
    if ($this->request->is('post')) {
        if ($this->Recipe->save($this->request->data)) {
            $this->Session->setFlash('Recipe Saved!');
            $this->redirect('/recipes');
        }
    }

    $this->set('recipe', $this->Recipe->findById($id));
}

答案 2 :(得分:0)

尝试以下步骤

if($ this-> User-> save($ this-> request-> data,false)){

        $this->Session->setFlash(__('Recipe Saved!'));

        return $this->redirect(array('action' => 'view_users'));

}