Question

根据找到的代码here，我正在查询AD组以填充联系人下拉列表。下面的代码大约需要30秒才能完成，所以我想确保我正在使用最好的代码吗？理想情况下，我希望它跑得更快，但欣赏大约1500人不会花费几秒钟。

            // define AD group to use for populating associate list...
        const string groupName = "Group-Name-X";

        // define array objects...
        var userIdLookup = new SortedList();
        var emailLookup = new SortedList();
        var listContents = new SortedList<string, string>();

        // initialise the AD tools class...
        var adm = new ADMethods();

        // get the members of the specified AD group...
        GroupPrincipal group = adm.GetGroup(groupName);

        // iterate over its members
        foreach (Principal p in group.Members)
        {
            // get the data for the user...
            var groupMember = adm.GetUser(p.SamAccountName);

            // if user account found...
            if (groupMember != null)
            {
                // get the user's mail address...
                string mailAddress = groupMember.EmailAddress ?? p.SamAccountName;

                // if domain extension present ...
                if (mailAddress.Contains("@"))
                {
                    // remove it...
                    mailAddress = mailAddress.Split('@')[0].Trim();
                }

                // create a name starting with surname...
                string associateName = string.Format("{0},", groupMember.Surname);

                // append the first name...
                associateName += string.Format(" {0}", groupMember.GivenName);

                // if the middle name is present...
                if (groupMember.MiddleName != string.Empty)
                {
                    // append it to the string...
                    associateName += string.Format(" {0}", groupMember.MiddleName);
                }

                // get the employee ID...
                string associateNumber = p.SamAccountName;

                // if associate already added...
                if (listContents.ContainsKey(associateName))
                {
                    // skip rest of code for this iteration...
                    continue;
                }

                // add to list that will populate dropdown...
                listContents.Add(associateName, mailAddress);

                // add to lookup collection of ccmail to userID
                userIdLookup.Add(mailAddress, associateNumber);

                // add associate name to list...
                emailLookup.Add(associateNumber, mailAddress);
            }
        }

Answer 1

您可以考虑为特定组的成员执行属性范围查询。由于目前已实施，因此减速很可能是您必须为每个成员执行新搜索（您需要使用类似秒表的内容来验证）。使用属性范围查询，您可以一次性加载所有用户，然后对它们进行处理。

我没有尝试使用System.DirectoryServices.AccountManagement，但我知道你可以使用System.DirectoryServices和System.DirectoryServices.Protocols完成它。

DirectorySearcher example

我可以改善AD查询时间吗？

1 个答案: