Question

我有一个与Cold Fusion集成的遗留JS函数，用于输出包含在if语句中的第n个ID表单字段。有时输出很高，看起来非常多余和繁琐。我认为for循环可以解决这个问题，但不确定正确的解决方法。以下是示例输出中的遗留代码。任何帮助表示赞赏：

function checkFinalDisposition(){
if (document.getElementById("mrostatus").value == "Completed"){


    var checkfinal = document.getElementById("finaldisposition").value
    if (checkfinal == 'NEGATIVE' || checkfinal == 'NEGATIVE DILUTE'){
        var checkfinalpass = 'Yes'

        if (document.getElementById("id4735721").value != 'NEGATIVE' || document.getElementById("id4735721").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735722").value != 'NEGATIVE' || document.getElementById("id4735722").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735723").value != 'NEGATIVE' || document.getElementById("id4735723").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735724").value != 'NEGATIVE' || document.getElementById("id4735724").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735725").value != 'NEGATIVE' || document.getElementById("id4735725").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735726").value != 'NEGATIVE' || document.getElementById("id4735726").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
        if (document.getElementById("id4735727").value != 'NEGATIVE' || document.getElementById("id4735727").value != 'NEGATIVE DILUTE'){
            var checkfinalpass = 'No'
        }
    }
    else{
        var checkfinalpass = 'No'
        //Multiple IF's from drug query

        if (document.getElementById("id4735721").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735722").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735723").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735724").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735725").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735726").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

        if (document.getElementById("id4735727").value == checkfinal){
            var checkfinalpass = 'Yes'
        }

    }

    if (checkfinalpass != 'Yes'){
        var inputfinaldisposition = 'NEGATIVE'
        //Multiple IF's from drug query

        if (document.getElementById("id4735721").value == ""){
            document.getElementById("id4735721").value = "POSITIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735721").value != 'NEGATIVE' || document.getElementById("id4735721").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735721").value
        }

        if (document.getElementById("id4735722").value == ""){
            document.getElementById("id4735722").value = "POSITIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735722").value != 'NEGATIVE' || document.getElementById("id4735722").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735722").value
        }

        if (document.getElementById("id4735723").value == ""){
            document.getElementById("id4735723").value = "NEGATIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735723").value != 'NEGATIVE' || document.getElementById("id4735723").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735723").value
        }

        if (document.getElementById("id4735724").value == ""){
            document.getElementById("id4735724").value = "NEGATIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735724").value != 'NEGATIVE' || document.getElementById("id4735724").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735724").value
        }

        if (document.getElementById("id4735725").value == ""){
            document.getElementById("id4735725").value = "NEGATIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735725").value != 'NEGATIVE' || document.getElementById("id4735725").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735725").value
        }

        if (document.getElementById("id4735726").value == ""){
            document.getElementById("id4735726").value = "NEGATIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735726").value != 'NEGATIVE' || document.getElementById("id4735726").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735726").value
        }

        if (document.getElementById("id4735727").value == ""){
            document.getElementById("id4735727").value = "NEGATIVE";
        }
        if ((inputfinaldisposition == 'NEGATIVE' || inputfinaldisposition == 'NEGATIVE DILUTE') && (document.getElementById("id4735727").value != 'NEGATIVE' || document.getElementById("id4735727").value != 'NEGATIVE DILUTE')){
        var inputfinaldisposition = document.getElementById("id4735727").value
        }

        var answer = confirm("Please advise the Final Disposition does not match your individual results!\n\nPress \"OK\" to change Final Disposition to "+inputfinaldisposition)

        if (answer){
            document.getElementById("finaldisposition").value = inputfinaldisposition;
            return true;
        }
        else{
            return false
        }
    }
}
}

Answer 1

我会检查你正在检查的js数组，

idToCheck = ['id4735721', 'id4735722', ...];

然后在for循环中比较它们。

for(id in idToCheck){
      if($('#'+idToCheck[id]).val() != 'NEGATIVE' || if($('#'+idToCheck[id]).val() != 'NEGATIVE DILUTE'){
            checkfinalpass = 'No';
      }
}

我没有重做你的整个代码，但希望这会指出你正确的方向。

可以在jQuery中重写这个Javascript函数吗？

1 个答案: