在同一个脚本中两次插入一个表?

时间:2013-02-05 15:42:57

标签: php mysql pdo insert

之前我曾问过这个问题,但之后我的代码已经改变了。我在使用此脚本时遇到问题,该脚本将表单数据插入表中。第一个插页创建一个预订,存储客户的联系方式。第二个插页将获取在第一个插页中创建的预订参考,并创建一个' JOB'为客户。最终的插页应该创造第二个“JOB”,即客户的回程。

前两个插件运行正常, 但它忽略了最后一个,即第二个JOB插入。

我检查了表结构,并且数据已经传递给脚本,一切正常,所以问题必须在脚本中(如下所示),非常感谢任何帮助。

使用一个脚本两次插入同一个表是否正确?

<?php

  $customer_title           =  $_POST['customer_title'];
  $customer_first_name      =  $_POST['customer_first_name'];
  $customer_last_name       =  $_POST['customer_last_name'];
  $billing_address          =  $_POST['billing_address'];
  $customer_tel             =  $_POST['customer_tel'];
  $customer_mobile          =  $_POST['customer_mobile'];
  $customer_email           =  $_POST['customer_email'];
  $passengers               =  $_POST['passengers'];
  $cases                    =  $_POST['cases'];
  $return_flight_number     =  $_POST['return_flight_number'];
  $price                    =  $_POST['price'];
  $pickup_date              =  $_POST['pickup_date'];
  $pickup_time              =  $_POST['pickup_time'];
  $pickup_address           =  $_POST['pickup_address'];
  $destination_address      =  $_POST['pickup_destination'];
  $return_date              =  $_POST['return_date'];
  $return_time              =  $_POST['return_time'];
  $return_pickup            =  $_POST['return_pickup'];
  $return_destination       =  $_POST['return_destination'];
  $booking_notes            =  $_POST['booking_notes'];

  $booking_status           =  "Confirmed";
  $authorised               =  "N";

  $booking_agent            =   "ROOT_TEST";
  $booking_date             =   date("Y/m/d");

if (isset($_POST['customer_title'])) {

  include('../assets/db_connection.php');

  $create_booking = $db->prepare("INSERT INTO bookings(customer_name, billing_address, contact_tel, contact_mob, contact_email, party_pax, party_cases, booking_notes, price, booking_agent, booking_date, booking_status, authorised)
                                      VALUES(:customer_name, :billing_address, :contact_tel, :contact_mob, :contact_email, :party_pax, :party_cases, :booking_notes, :price, :booking_agent, :booking_date, :booking_status, :authorised );");
  $create_booking->execute(array(
      ":customer_name"       =>   $customer_title  . ' ' .   $customer_first_name  . ' '  .   $customer_last_name,
      ":billing_address"     =>   $billing_address,
      ":contact_tel"         =>   $customer_tel,
      ":contact_mob"         =>   $customer_mobile,
      ":contact_email"       =>   $customer_email,
      ":party_pax"           =>   $passengers,
      ":party_cases"         =>   $cases,
      ":booking_notes"       =>   $booking_notes,
      ":price"               =>   $price,
      ":booking_agent"       =>   $booking_agent,
      ":booking_date"        =>   $booking_date,
      ":booking_status"      =>   $booking_status,
      ":authorised"          =>   $authorised    
    ));

  $booking_ref = $db->lastInsertId('booking_ref'); // Takes Booking Ref generated in $create_booking

  $scheduled   = "N";

  $create_job =  $db->prepare("INSERT INTO jobs(booking_ref, pickup_date, pickup_time, pickup_address, destination_address, scheduled) 
                              VALUES(:booking_ref, :pickup_date, :pickup_time, :pickup_address, :destination_address, :scheduled)");

  $create_job->execute(array(
      ":booking_ref"          =>  $booking_ref,
      ":pickup_date"          =>  $pickup_date,
      ":pickup_time"          =>  $pickup_time,
      ":pickup_address"       =>  $pickup_address,
      ":destination_address"  =>  $destination_address,
      ":scheduled"            =>  $scheduled  
  ));



  $return = "Y";


  $create_return  = $db->prepare("INSERT INTO jobs(booking_ref, pickup_date, pickup_time, pickup_address, destination_address, scheduled, return)
                                  VALUES(:booking_ref, :pickup_date, :pickup_time, :pickup_address, :destination_address, :scheduled, :return)");

  $create_return->execute(array(
      ":booking_ref"          =>  $booking_ref,
      ":pickup_date"          =>  $return_date,
      ":pickup_time"          =>  $return_time,
      ":pickup_address"       =>  $return_pickup,
      ":destination_address"  =>  $return_destination,
      ":scheduled"            =>  $scheduled,
      ":return"               =>  $return
  ));




}


?>

3 个答案:

答案 0 :(得分:1)

这是不正确的,因为两次插入相同的数据违反了最重要的数据库架构法之一 - Database Normalization原则

然而,它没有技术问题。使用mysql的错误消息,你必须抓住一些错误。要拥有它,请在连接到PDO后添加此行。

$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);

请注意,捕获实际错误是调试SQL查询的唯一方法。只是看代码没有任何意义也没有帮助。

return必须是mysql关键字。把它写成

`return`

顺便说一下,我无法忍受如此庞大的代码。

如果我是你,我会用10行而不是50行:

$allowed = array('customer_name', 'billing_address', 'contact_tel', 'contact_mob',
                 'contact_email', 'party_pax', 'party_cases', 'booking_notes', 'price'); 
$insert = $db->filterArray($_POST,$allowed);

$insert['booking_status'] =  "Confirmed";
$insert['authorised']     =  "N";
$insert['booking_agent']  =   "ROOT_TEST";
$insert['booking_date']   =   date("Y-m-d");

$db->query("INSERT INTO bookings SET ?u", $insert);

答案 1 :(得分:0)

看起来booking_refjobs表中的主键,您尝试插入相同的键两次,这就是最终查询失败的原因。

你应该有一个单独的字段,它是jobs上的主键,它只是一个自动递增的数字,然后在booking_ref上创建一个索引。

答案 2 :(得分:-1)

没有针对它的法律。您需要做的是检查上一次INSERT查询的返回值。我最好的猜测是jobs表上有一个唯一的索引,你用双插入违反了。

如果您在这里使用mySQLi或PDO并不明显,但两个执行函数都会在失败时返回false,因此您应该捕获它,然后调用相应对象的错误函数来解决问题。