崩溃,删除[] this-> str

时间:2013-01-06 12:13:51

标签: c++ string dynamic member

您好我有一些麻烦来删除我班级的成员字符串,该成员字符串不为空且指向正确的位置,因为我可以显示我的字符串“hello world “就在此之前。

我从另一个成员函数调用函数mystringclass :: alloc()之后这个 - > str应该让另一个字符串内容更大。

当我第一次以“你好”的方式重新调整“hello world”时,这个过程工作正常。但是现在我想再次放大它没有。所以我很困惑。

请帮帮我。

void mystringclass::alloc(long newsize) //newsize includes the +1 char
{   
   cout << "old size was: " << this->size << endl; //displays "12"
   if(this->str) cout << this->str << endl; //displays "hello world" all is right till here

   if(this->str) delete [] this->str ; //it crashes here

   cout << "str deleted\n"; //never show up on screen

   this->str = new char[newsize + 1];
   this->size = newsize;
   this->str[0] = 0;
}

感谢您的回答,我试图清除我的代码,将其发布在此处。我的错误消失了,但又出现了一个与三个规则有关的事情:

int main()
{
      stringclass str = "Hello";
      stringclass str2 = str;
      return 0;
}

我一直在显示信息所以问题是str2已经等于“hello”了,甚至在影响我的拷贝构造函数中str的内容之前。复制后是空的。有什么问题?有些人可能会说,我在魔术盒中学习了c ++。我正在使用代码块10.05

完整代码:

#include <fstream>
#include <iostream>
#include <vector>
using namespace std;

class stringclass
{
   protected :

      inline bool success()   { failbit = false;  return true; }
      inline bool fail()      { failbit = true; return false; }

   public :

      bool failbit;

      char * mystring;
      long memsize;
      long length;

      void alloc(long newsize);
      void reset();

      void copy(const stringclass & other);

      stringclass()                          {reset(); }
      stringclass(const stringclass & other) {copy(other); }
      stringclass(const char str[]);
      ~stringclass()                         {delete [] mystring;}

      inline long get_length()        { if(mystring) length = strlen(mystring); return length;}
      inline long get_memsize() const { return memsize; }

      friend ostream& operator << (ostream& out, stringclass & sc){out << sc.mystring; return out;}
      stringclass & operator = (stringclass & other)  { copy(other); return *this;}

};

void stringclass::reset()
{
   delete [] mystring;
   mystring = NULL;
   length = 0;
   memsize = 0;
}

void stringclass::alloc(long newsize)
{
   cout<< "\nalloc(long newsize)... \n" << endl;
   cout << "memsize was : " << memsize << endl;
   cout << "length was : " << length << endl;
   if(mystring) cout << "mystring = " << mystring << endl;

   delete [] mystring;

   cout << "mystring deleted...\n";

   mystring = new char[newsize];

   cout << "mystring has been resized\n";

   mystring[0] = 0;
   memsize = newsize;
   length = strlen(mystring);

   cout << "memsize is now : " << memsize << endl;
   cout << "length is now : " << length << endl;
   cout<< "\nend of alloc()... " << endl;
   cout << "\n";
}

void stringclass::copy(const stringclass & other)
{
   cout << "\n";
   cout << "copy(const stringclass & other)...\n" << endl;
   cout << "other.mystring = "<< other.mystring << endl;

   if(other.mystring == NULL || other.memsize == 0)
   {
      reset();
      return;
   }

   alloc(other.memsize);
   strcpy(mystring, other.mystring);

   cout << "mystring = "<< mystring;

   length = strlen(mystring);

   cout << "length: " << length << endl;
   cout<< "\nend of copy()... " << endl;
   cout << "\n";
}

stringclass::stringclass(const char str[]) : mystring(NULL), memsize(0), length(0)
{
   if(str == NULL) reset();
   else
   {
      alloc(strlen(str) + 1);
      strcpy(mystring, str);
      length = strlen(mystring);
   }
}

int main()
{
      stringclass str = "Hello";
      stringclass str2 = str;

      cout << "\nback to main()...\n";
      cout << "str = " << str << "\n";
      cout << "str2 = " << str2 << "\n";
      cout << endl;

      system("PAUSE");
      return 0;
}

屏幕上显示结果:

alloc(long newsize)...

memsize was : 0
length was : 0
mystring deleted...
mystring has been resized
memsize is now : 6
length is now : 0

end of alloc()...


copy(const stringclass & other)...

other.mystring = Hello

alloc(long newsize)...

memsize was : 3214960
length was : 2293560
mystring = Hello
mystring deleted...
mystring has been resized
memsize is now : 6
length is now : 0

end of alloc()...

mystring = length: 0

end of copy()...


back to main()...
str =
str2 =

Appuyez sur une touche pour continuer...

我刚刚意识到您不需要以下代码:

 protected :

          inline bool success()   { failbit = false;  return true; }
          inline bool fail()      { failbit = true; return false; }

       public :

          bool failbit;

所以我推迟了这两个函数和这个变量,猜猜是什么......一切正常,没有bug 。它们甚至没有使用过一次。 我把它放回去,问题也回来了。你怎么解释这个?!我已经失去了我的头发。

1 个答案:

答案 0 :(得分:0)

你可以“显示”一个字符串的事实说不出任何事。取消分配字符串仍然可以打印,很可能直到它被新的llocation和初始化覆盖。

只需尝试在delete[]之后打印字符串并查看。