计算器减法导致无限循环

时间:2012-12-03 01:58:22

标签: python expression infinite-loop calculator

我正在研究一种能接受用户输入的计算器。 它必须解决如下表达式:

  

1 + 38 *(!2)-5%37

我一直致力于加法和减法,但我遇到了一个问题。

我有一个寻找“+”或“ - ”符号的循环。 对于“+”它起作用,但对于“ - ”,每当我解决像

这样的表达式时
  

1-38

它让我进入一个无限循环,因为该表达式的结果是

  

-37

并且循环将“ - ”符号识别为减法,但是为负37。

如何解决此问题?

def symbols_exist(exp, symbols_list):
    """ Gets an expression string and a symbols list and returns true if any symbol
        exists in the expression, else returns false. """
    for s in symbols_list:
        if s in exp:
            return True
    return False

def BinaryOperation(exp, idx):
    """ Gets an expression and an index of an operator and returns a tuple with (first_value, operator, second_value). """
    first_value = 0
    second_value = 0

    #Get first value
    idx2 = idx -1
    while (idx2 > 0) and (exp[idx2] in string.digits):
        idx2 -=1

    first_value = exp[idx2:idx]

    #Get second value
    idx2 = idx +1
    while (idx2 < len(exp)) and (exp[idx2] in string.digits):
        idx2 += 1

    second_value = exp[idx+1:idx2]

    return (first_value, exp[idx], second_value)

def solve(exp):
    if not symbols_exist(exp, all_symbols):
        return exp

    idx = 0

    while idx < len(exp):
        if exp[idx] in string.digits:
            #Digit
            idx +=1
        elif exp[idx] in ("+", "-"):
            #Addition and Subtraction
            sub_exp = BinaryOperation(exp, idx)
            if sub_exp[1] == "+":
                value = int(sub_exp[0]) + int(sub_exp[2])
            else:
                value = int(sub_exp[0]) - int(sub_exp[2])

            value = str(value)

            exp = exp.replace(''.join(sub_exp), value)
            print exp

        return solve(exp)

1 个答案:

答案 0 :(得分:0)

结合原始示例中的三个功能的可能解决方案。 (编辑:刚刚意识到我发布的原始答案可以简化很多)

all_symbols = '+-'
def solve(expres):
    lhs, symbol, rhs = expres[0], None, ''
    for ch in expres[1:]:
        if symbol:
            rhs += ch
        elif ch in all_symbols:
            symbol = ch
        else:
            lhs += ch
    if symbol is '+':
        return int(lhs) + solve(rhs)
    if symbol is '-':
        return int(lhs) - solve(rhs)
    return int(expres)

print solve('1+5')

另一种可能有用的解决方案

operations = [
    ('+', lambda a, b: a + b),
    ('-', lambda a, b: a - b)
    ]
def solve(exp):
    for symbol, operation in operations:
        p = exp.rfind(symbol)
        if p > 0:
            return operation(solve(exp[:p]), solve(exp[p + 1:]))
    return int(exp)