Question

/**
     * Sort an array in ascending order
     * @param arr array to sort
     */
    public static void quickSort(int[] arr){
        qs(arr, 0, arr.length);
    }

/**
     * Sort a region of an array in ascending order.
     * Elements outside the given region are unchanged.
     * requires: 0 <= start <= end <= arr.length
     * @param arr   array to sort
     * @param start start of region (inclusive)
     * @param end   end of region (exclusive)
     */
    private static void qs(int[] arr, int start, int end){
        if (end <= start+1){    //region of length 0 or 1
            return;
        }
        int x = arr[start];
        int p = partition(arr, start+1, end, x);
            //now swap arr[start] with arr[p-1]
        arr[start] = arr[p-1];
        arr[p-1] = x;
        qs(arr, start, p-1);
        qs(arr, p, end);



    }

    /**
     * Partition a region of an array.
     * Rearranges elements in region so that small ones
     *   all have smaller indexes than the big ones.
     * Elements outside the region are unchanged.
     * requires: 0 <= start <= end <= arr.length
     * @param arr   array to partition
     * @param start start of region (inclusive)
     * @param end   end of region (exclusive)
     * @param x     pivot - "small" and "big" are <x, >=x.
     * @return      start index (inclusive) of big elements
     *              in region after partition.
     */
    private static int partition(
        int[] arr, int start, int end, int x)
    {

        int l = start -1, r = end+1;
        while (true) {
            while (l < end && arr[++l] < x) ;

            while(r> l && arr[--r] >x);// find smaller item

                if(l >= r) // if pointers cross,
                    break; // partition done
                    else  {
                        int temp;
                temp = arr[l];
                arr[l] = arr[r];
                arr[r] = temp;
            }
        }
        return l;
        }


    public static void main(String[] args) {
        int[] a = {15,8,9,6,2,8,8,5,8,4,2};
        quickSort(a);
        for (int i = 0; i < a.length; i++){
            System.out.print(" "+a[i]);
        }
    }
}

partition方法有什么错误？

Answer 1

让我强调一些重要的事实：

 * @param end   end of region (exclusive)
                               ^^^^^^^^^

 * @param x     pivot - "small" and "big" are <x, >=x.
 * @return      start index (inclusive) of big elements
 *              in region after partition.
 */
private static int partition(
    int[] arr, int start, int end, int x)
{

    int l = start -1, r = end+1;
                      ^^^^^^^^^^

    while (true) {
        while (l < end && arr[++l] < x) ;
               ^^^^^^^^^^^^^^^^^^^^^^^

        while(r> l && arr[--r] >x);// find smaller item
                      ^^^^^^^^

整个阵列分区后，end为arr.length。然后设置end = arr.length + 1并在循环获取之后递增较低索引l，如果没有引发ArrayIndexOutOfBoundsException（尝试访问arr[end]，如果pivot是例如数组中的最大元素），您尝试在下一个循环中访问的第一个数组元素是arr[arr.length]。这会引发ArrayIndexOutOfBoundsException。

因此，您可以保证在partition中获得AIOBE。

您可以设置r = end并将循环控件更改为

while(++l < r && arr[l] < x)

和

while(r-- > l && arr[r] > x)

或者您也可以将更高的索引包含在内，并从qs(arr, 0, arr.length -1)致电main。

JAVA quicksort，分区方法有什么错误？

1 个答案: