Rails教程(Michael Hartl),第9课,无法登录

时间:2012-11-14 05:28:27

标签: ruby-on-rails ruby ruby-on-rails-3 railstutorial.org

我查看了类似的错误,但不仅我的测试不会通过,脚本也不会登录用户。

  

故障:

     

以0.41649秒完成31例,2次失败

     

失败的例子:

     

rspec ./spec/controllers/sessions_controller_spec.rb:48#   SessionsController获取'新'POST'创建'成功应签署   用户在rspec ./spec/controllers/sessions_controller_spec.rb:54#   SessionsController GET'新'POST'create'成功应该重定向到   用户显示页面

     

完成。

     

登录时出错:SessionsController中的NoMethodError #create

     

未定义的方法`authenticate'for#   Rails.root:/ Users / lancevelasco / Development / appsample

     

应用程序跟踪|框架跟踪|完整追踪   app / controllers / sessions_controller.rb:10:在'create'

代码

user.rb

# == Schema Information
#
# Table name: users
#
#  id                 :integer          not null, primary key
#  name               :string(255)
#  email              :string(255)
#  created_at         :datetime         not null
#  updated_at         :datetime         not null
#  encrypted_password :string(255)
#  salt               :string(255)
#

class User < ActiveRecord::Base
  attr_accessor   :password
  attr_accessible :email, :name, :password, :password_confirmation

  email_regex = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i

  validates :name,  :presence => true,
                    :length   => { :maximum => 50 }
  validates :email, :presence   => true,
                    :format     => { :with => email_regex },
                    :uniqueness => { :case_sensitive => false }    
  validates :password, :presence => true,
                        :confirmation => true,
                        :length => { :within => 6..40 }

  before_save :encrypt_password

  def has_password?(submitted_password)
    encrypted_password == encrypt(submitted_password)
  end


  def User.authenticate(email, submitted_password)
    user = find_by_email(email)
    return nil  if user.nil?
    return user if user.has_password?(submitted_password) 
  end

  def authenticate_with_salt(id, cookie_salt)
    user = find_by_id(id)
    (user && user.salt == cookie_salt ) ? user : nil
  end

  private
  def encrypt_password
    self.salt = make_salt if new_record?
    self.encrypted_password = encrypt(password)
  end

  def encrypt(string)
      secure_hash("#{salt}--#{string}")
      end   

  def make_salt
    secure_hash("#{Time.now.utc}--#{password}")
  end

  def secure_hash(string)
    Digest::SHA2.hexdigest(string)
  end     
end  

sessions_controller.rb

 class SessionsController < ApplicationController

  def new
    @title = "Sign in"
  end

  def create
    user = User.authenticate(params[:session][:email],
                             params[:session][:password])
    if user.nil?
      flash.now[:error] = "Invalid email/password combination."
      render 'new'
    else
      sign_in user
      redirect_back_or user
    end
  end

  def destroy
    sign_out
    redirect_to root_path
  end
end

sessions_helper.rb

module SessionsHelper

  def sign_in_(user)
    cookies.permanent.signed[:remember_token] = [user.id, user.salt]
    current_user = user
  end

  def current_user=(user)
    @current_user = user
  end

  def current_user
    @current_user || user_from_remember_token    
  end

  private

    def user_from_remember_token
      User.authenticate_with_salt()
    end

    def remember_token
      cookies.signed[:remember_token] || [nil,nil]
    end
end

user_controller_spec.rb

require 'spec_helper'

describe SessionsController do

  render_views

    describe "GET 'new'" do
    it "returns http success" do
      get 'new'
      response.should be_success
    end

    it "should have the right title" do
       get :new
       response.should have_selector('title', :content => "Sign in")
     end

     describe "POST 'create'" do

       describe "failure" do

          before(:each) do
            @attr = { :email => "", :password => ""}
          end 

          it "should re-render the new page" do
            post :create,  :session => @attr 
            response.should render_template('new')
          end

          it "should have the right title" do
            post :create, :session => @attr
          end

          it "should have an error message" do
            post :create, :session => @attr
            flash.now[:error].should =~ /invalid/i
          end
       end

       describe "success" do

         before(:each) do
           @user= Factory(:user)
           @attr = { :email => @user.email, :password => @user.password }
         end

         it "should sign the user in" do
           post :create, :session => @attr
           controller.current_user.should == @user
           controller.should  be_signed_in
         end

         it "should redirect to the user show page" do
           post :create, :session => @attr
           response.should redirect_to(user_path(@user))
         end

       end

     end
  end

end

4 个答案:

答案 0 :(得分:1)

现在你在User的对象上调用authenticate,但是如果我没记错的话,你声明authenticate是User类的方法(例如java中的静态方法),而不是User的对象。这就是为什么你得到NoM​​ethodError,所以你应该使用类似Kubee方法调用的东西:

user = User.authenticate(params[:session][:email], params[:session][:password])

答案 1 :(得分:0)

根据我的理解,Michael Hartl曾经使用bcrypt来处理他的身份验证(has_secure_password“)。看起来他选择放弃这个并编写自己的身份验证(看起来是为了添加一个盐..非常好。)

你有user.rb:

def User.authenticate(email, submitted_password)
  user = find_by_email(email)
  return nil  if user.nil?
  return user if user.has_password?(submitted_password) 
end

正如您所看到的,您还需要将电子邮件传递给authenticate方法,并且由于它还会抓取用户,因此您可以简化会话#create方法。试试这个:

def create
  user = User.authenticate(params[:session][:email], params[:session][:password])
  if user.nil?
    flash.now[:error] = 'Invalid email/password combination'
    render 'new'
  else
    sign_in user
    redirect_back_or user
  end
end

答案 2 :(得分:0)

这是一个相当简单的修复。

在session_helper

def sign_in_(用户)

应阅读

def sign_in(用户)

在application_controller中

添加   包括SessionsHelper

答案 3 :(得分:0)

是的,我成功了,谢谢。 我用过这个

def User.authenticate(email, submitted_password)
user = find_by_email(email)
return nil if user.nil?
return user if user.has_password?(submitted_password)
end

然后

def create
user= User.authenticate(params[:session][:email]
params[:session][:password])
if user.nil?
flash.now[:error] ="Invalid email/password combination."
@title = "sign in"
render 'new'
else
sign_in user
redirect_to user
end
end