观察以下代码:
var handler = GetTheRightHandler();
var bw = new BackgroundWorker();
bw.RunWorkerCompleted += OnAsyncOperationCompleted;
bw.DoWork += OnDoWorkLoadChildren;
bw.RunWorkerAsync(handler);
现在假设我要等到bw
完成工作。这样做的正确方法是什么?
我的解决方案是:
bool finished = false;
var handler = GetTheRightHandler();
var bw = new BackgroundWorker();
bw.RunWorkerCompleted += (sender, args) =>
{
OnAsyncOperationCompleted(sender, args);
finished = true;
});
bw.DoWork += OnDoWorkLoadChildren;
bw.RunWorkerAsync(handler);
int timeout = N;
while (!finished && timeout > 0)
{
Thread.Sleep(1000);
--timeout;
}
if (!finished)
{
throw new TimedoutException("bla bla bla");
}
但我不喜欢它。
我考虑过用同步事件替换finished
标志,在RunWorkerCompleted
处理程序中设置它并稍后阻塞它而不是执行while-sleep循环。
唉,这是错误的,因为代码可能在WPF或WindowsForm同步上下文中运行,在这种情况下,我会阻止与RunWorkerCompleted
处理程序运行相同的线程,这显然不是很聪明的举动。
我想知道一个更好的解决方案。
感谢。
修改
P.S。
Thread.Join
,Delegate.BeginInvoke
,ThreadPool.QueueUserWorkItem
等等......问题具体针对BackgroundWorker
。编辑2:
好的,我想如果我解释这个场景会容易得多。
我有一个单元测试方法,它调用一些异步代码,这反过来最终会使BackgroundWorker
与我能够传递完成处理程序。所有的代码都是我的,所以如果我愿意,我可以改变实现。
但是,我不会替换BackgroundWorker
,因为它会自动使用正确的同步上下文,因此当在UI线程上调用代码时,将在同一UI线程上调用完成回调,这非常好。
无论如何,单元测试方法有可能在BW完成其工作之前结束,这是不好的。所以我希望等到BW完成并想知道最好的方法。
它有更多的部分,但总体情况或多或少与我刚才描述的一样。
答案 0 :(得分:41)
尝试使用AutoResetEvent类,如下所示:
var doneEvent = new AutoResetEvent(false);
var bw = new BackgroundWorker();
bw.DoWork += (sender, e) =>
{
try
{
if (!e.Cancel)
{
// Do work
}
}
finally
{
doneEvent.Set();
}
};
bw.RunWorkerAsync();
doneEvent.WaitOne();
警告:无论发生什么情况,都应确保调用doneEvent.Set()
。您还可以为doneEvent.WaitOne()
提供一个指定超时时间的参数。
注意:此代码几乎是对Fredrik Kalseth的similar question回复的副本。
答案 1 :(得分:18)
要等待后台工作线程(单个或多个),请执行以下操作:
创建以编程方式创建的后台工作者列表:
private IList<BackgroundWorker> m_WorkersWithData = new List<BackgroundWorker>();
在列表中添加后台工作程序:
BackgroundWorker worker = new BackgroundWorker();
worker.DoWork += new DoWorkEventHandler(worker_DoWork);
worker.ProgressChanged += new ProgressChangedEventHandler(worker_ProgressChanged);
worker.WorkerReportsProgress = true;
m_WorkersWithData.Add(worker);
worker.RunWorkerAsync();
使用以下函数等待List中的所有worker:
private void CheckAllThreadsHaveFinishedWorking()
{
bool hasAllThreadsFinished = false;
while (!hasAllThreadsFinished)
{
hasAllThreadsFinished = (from worker in m_WorkersWithData
where worker.IsBusy
select worker).ToList().Count == 0;
Application.DoEvents(); //This call is very important if you want to have a progress bar and want to update it
//from the Progress event of the background worker.
Thread.Sleep(1000); //This call waits if the loop continues making sure that the CPU time gets freed before
//re-checking.
}
m_WorkersWithData.Clear(); //After the loop exits clear the list of all background workers to release memory.
//On the contrary you can also dispose your background workers.
}
答案 2 :(得分:7)
BackgroundWorker有一个完成事件。而不是等待,从完成处理程序调用剩余的代码路径。
答案 3 :(得分:2)
这个问题很陈旧,但我认为作者没有得到他想要的答案。
这有点脏,它在vb.NET中但对我有用
Private Sub MultiTaskingForThePoor()
Try
'Start background worker
bgwAsyncTasks.RunWorkerAsync()
'Do some other stuff here
For i as integer = 0 to 100
lblOutput.Text = cstr(i)
Next
'Wait for Background worker
While bgwAsyncTasks.isBusy()
Windows.Forms.Application.DoEvents()
End While
'Voila, we are back in sync
lblOutput.Text = "Success!"
Catch ex As Exception
MsgBox("Oops!" & vbcrlf & ex.Message)
End Try
End Sub
答案 4 :(得分:2)
While BackgroundWorker1.IsBusy()
Windows.Forms.Application.DoEvents()
End While
您可以使用它来链接多个事件。 (要跟随的sudo代码)
download_file("filepath")
While BackgroundWorker1.IsBusy()
Windows.Forms.Application.DoEvents()
End While
'Waits to install until the download is complete and lets other UI events function install_file("filepath")
While BackgroundWorker1.IsBusy()
Windows.Forms.Application.DoEvents()
End While
'Waits for the install to complete before presenting the message box
msgbox("File Installed")
答案 5 :(得分:2)
使用backgrWorker.IsBusy
检查循环中的Application.DoEvents()
并不是一个好方法。
我同意@JohannesH,你应该明确地使用AutoResetEvent作为一个优雅的解决方案。但是不在UI Thread中使用它,它会导致主线程被阻塞;它应该来自另一个后台工作者线程。
AutoResetEvent aevent = new AutoResetEvent(false);
private void button1_Click(object sender, EventArgs e)
{
bws = new BackgroundWorker();
bws.DoWork += new DoWorkEventHandler(bw_work);
bws.RunWorkerCompleted += new RunWorkerCompletedEventHandler(bw_complete);
bws.RunWorkerAsync();
bwWaiting.DoWork += new DoWorkEventHandler(waiting_work);
bwWaiting.RunWorkerCompleted += new RunWorkerCompletedEventHandler(waiting_complete);
bwWaiting.RunWorkerAsync();
}
void bw_work(object sender, DoWorkEventArgs e)
{
Thread.Sleep(2000);
}
void bw_complete(object sender, RunWorkerCompletedEventArgs e)
{
Debug.WriteLine("complete " + bwThread.ToString());
aevent.Set();
}
void waiting_work(object sender, DoWorkEventArgs e)
{
aevent.WaitOne();
}
void waiting_complete(object sender, RunWorkerCompletedEventArgs e)
{
Debug.WriteLine("complete waiting thread");
}
答案 6 :(得分:0)
不太确定等待你的意思。你是说你希望做完其他事情之后想要完成某些事情(由BW完成)吗? 像你一样使用bw.RunWorkerCompleted(使用一个单独的函数来提高可读性),并在那个回调函数中做下一个东西。 启动计时器以检查工作是否花费太长时间。
var handler = GetTheRightHandler();
var bw = new BackgroundWorker();
bw.RunWorkerCompleted += (sender, args) =>
{
OnAsyncOperationCompleted(sender, args);
});
bw.DoWork += OnDoWorkLoadChildren;
bw.RunWorkerAsync(handler);
Timer Clock=new Timer();
Clock.Interval=1000;
Clock.Start();
Clock.Tick+=new EventHandler(Timer_Tick);
public void Timer_Tick(object sender,EventArgs eArgs)
{
if (bw.WorkerSupportsCancellation == true)
{
bw.CancelAsync();
}
throw new TimedoutException("bla bla bla");
}
在OnDoWorkLoadChildren:
if ((worker.CancellationPending == true))
{
e.Cancel = true;
//return or something
}
答案 7 :(得分:0)
我也在寻找合适的解决方案。我用独家锁解决了等待。代码中的关键路径是写入公共容器(此处为控制台)并增加或减少工作者。写入此变量时,没有线程会干扰,否则不再保证计数。
public class Program
{
public static int worker = 0;
public static object lockObject = 0;
static void Main(string[] args)
{
BackgroundworkerTest backgroundworkerTest = new BackgroundworkerTest();
backgroundworkerTest.WalkDir("C:\\");
while (backgroundworkerTest.Worker > 0)
{
// Exclusive write on console
lock (backgroundworkerTest.ExclusiveLock)
{
Console.CursorTop = 4; Console.CursorLeft = 1;
var consoleOut = string.Format("Worker busy count={0}", backgroundworkerTest.Worker);
Console.Write("{0}{1}", consoleOut, new string(' ', Console.WindowWidth-consoleOut.Length));
}
}
}
}
public class BackgroundworkerTest
{
private int worker = 0;
public object ExclusiveLock = 0;
public int Worker
{
get { return this.worker; }
}
public void WalkDir(string dir)
{
// Exclusive write on console
lock (this.ExclusiveLock)
{
Console.CursorTop = 1; Console.CursorLeft = 1;
var consoleOut = string.Format("Directory={0}", dir);
Console.Write("{0}{1}", consoleOut, new string(' ', Console.WindowWidth*3 - consoleOut.Length));
}
var currentDir = new System.IO.DirectoryInfo(dir);
DirectoryInfo[] directoryList = null;
try
{
directoryList = currentDir.GetDirectories();
}
catch (UnauthorizedAccessException unauthorizedAccessException)
{
// No access to this directory, so let's leave
return;
}
foreach (var directoryInfo in directoryList)
{
var bw = new BackgroundWorker();
bw.RunWorkerCompleted += (sender, args) =>
{
// Make sure that this worker variable is not messed up
lock (this.ExclusiveLock)
{
worker--;
}
};
DirectoryInfo info = directoryInfo;
bw.DoWork += (sender, args) => this.WalkDir(info.FullName);
lock (this.ExclusiveLock)
{
// Make sure that this worker variable is not messed up
worker++;
}
bw.RunWorkerAsync();
}
}
}
答案 8 :(得分:0)
您可以创建任意数量的任务并将其添加到任务列表中。 工作人员将在添加任务时启动,如果在工作人员IsBusy中添加任务则重新启动,并在没有其他任务时停止。
这将允许您根据需要异步更新GUI,而不会冻结它。
这对我有用。
// 'tasks' is simply List<Task> that includes events for adding objects
private ObservableCollection<Task> tasks = new ObservableCollection<Task>();
// this will asynchronously iterate through the list of tasks
private BackgroundWorker task_worker = new BackgroundWorker();
public Form1()
{
InitializeComponent();
// set up the event handlers
tasks.CollectionChanged += tasks_CollectionChanged;
task_worker.DoWork += task_worker_DoWork;
task_worker.RunWorkerCompleted += task_worker_RunWorkerCompleted;
task_worker.WorkerSupportsCancellation = true;
}
// ----------- worker events
void task_worker_RunWorkerCompleted(object sender, RunWorkerCompletedEventArgs e)
{
if (tasks.Count != 0)
{
task_worker.RunWorkerAsync();
}
}
void task_worker_DoWork(object sender, DoWorkEventArgs e)
{
try
{
foreach (Task t in tasks)
{
t.RunSynchronously();
tasks.Remove(t);
}
}
catch
{
task_worker.CancelAsync();
}
}
// ------------- task event
// runs when a task is added to the list
void tasks_CollectionChanged(object sender,
System.Collections.Specialized.NotifyCollectionChangedEventArgs e)
{
if (!task_worker.IsBusy)
{
task_worker.RunWorkerAsync();
}
}
现在您只需要创建一个新任务并将其添加到List&lt;&gt;中。它将由工作人员按其放入List&lt;&gt;
的顺序运行Task t = new Task(() => {
// do something here
});
tasks.Add(t);
答案 9 :(得分:-1)
在OpenCV中存在函数WaitKey。 Ir允许以这种方式解决这个问题:
while (this->backgroundWorker1->IsBusy) {
waitKey(10);
std::cout << "Wait for background process: " << std::endl;
}
this->backgroundWorker1->RunWorkerAsync();