新用户创建脚本错误

时间：2012-10-25 05:12:45

标签： bash ubuntu

我有下面列出的脚本，我似乎无法解决问题。我正在尝试为我所在的UNIX类创建一个交互式登录脚本。我基本上构建了一个命令来传递给useradd。我在传递到命令行时所做的命令（在添加sudo时）按预期工作，但是当我尝试从我的脚本运行它时（生成我复制/粘贴到命令行的文本）它给了我一些错误......在这一点上，我不知道接下来要尝试解决这个问题。

错误： 

useradd -m --user-group jaredm2 #command that is attempting to run...
useradd: invalid option -- ' '
Usage: useradd [options] LOGIN
....rest of useradd error text....

SCRIPT： 

#!/bin/bash
#Add a new user

FINALCOMMAND="-m"

#import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]
do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME   
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND="$FINALCOMMAND ""-s $SHELL"
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND="$FINALCOMMAND --user-group"
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND="$FINALCOMMAND -g $newPrimaryGroup"
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND="$FINALCOMMAND --user-group"
    fi
fi
useradd -m --user-group jaredm2
#ASK about additional groups
echo "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=""
IFS=","
for g in $extraGroups
do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done
FINALEXTRAGROUPS=$(echo "$FINALEXTRAGROUPS" | tail -c +2)
if [ ${#FINALEXTRAGROUPS} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -G $FINALEXTRAGROUPS"
fi

#ASK about the home directory
echo "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -d $NEWHOME"
fi

#ADD the username to the command
FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`
echo "useradd $FINALCOMMAND"
#PASSCOMMAND="sudo passwd $USERNAME"
#ADD THE USER
`useradd $FINALCOMMAND`

`passwd $USERNAME`

`chfn $USERNAME`

更新：添加了调试内容 

+ '[' 0 -ge 1 ']'
++ sed 's/^ *//g'
++ sed 's/ *$//g'
++ echo '/usr/sbin/useradd -m -U JaredM'
+ FINALCOMMAND='/usr/sbin/useradd -m -U JaredM'
++ '/usr/sbin/useradd -m -U JaredM'
./addnewuser.sh: line 89: /usr/sbin/useradd -m -U JaredM: No such file or directory

5 个答案:

答案 0 :(得分：2)

如果man -s8 useradd未提及--user-group选项可供使用，则-U将无效。还有另一个值得尝试的解决方案：

  

默认行为（如果未指定-g，-N和-U选项）   由/etc/login.defs中的USERGROUPS_ENAB变量定义。

另一种方法是，您必须使用useradd命令将groupadd命令链接，并将相同的用户名作为参数提供给两个命令。

修改 这必须奏效。首先创建组，然后创建用户并将此新用户添加到组中。因为，你在脚本中这样做，这应该很好地完成这项工作。

这样做：

groupadd jaredm2
useradd -m -g jaredm2 jaredm2

而不是：

useradd -m --user-group jaredm2

请注意，您的操作系统中安装的某些其他程序可能已更改了二进制文件或访问它，甚至为其创建了别名。您的which输出表明它已链接到bin目录中的useradd二进制文件，正是它应该位于的位置。

所以我想：

  • 二进制文件可能已被进程，包安装程序或其他内容更改或替换
  • 二进制版本和手册页版本之间存在一些不匹配（最有可能的情况是，如果您在某个时间点不正确地升级了操作系统）

我认为，唯一的解决方案是使用上面的一对命令或更改您手动使用的useradd二进制文件。

答案 1 :(得分：2)

问题是由您的脚本使用魔术引号`...`来执行shell命令引起的。

仅当您想要在变量中存储命令的返回时，才应使用这些引号： 示例如下：

FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`

否则没有必要使用这个引用，它们可能会产生像你这样的错误。

你可以放入你的剧本：

useradd $FINALCOMMAND
passwd $USERNAME
chfn $USERNAME

而不是：

`useradd $FINALCOMMAND`
`passwd $USERNAME`
`chfn $USERNAME`

答案 2 :(得分：2)

通过使用数组，您可以在命令行中防止与IFS相关的错误，并且它更清晰。这个已经过测试了。我也对代码进行了一些清理。

#!/bin/bash

#Add a new user

FINALCOMMAND=("-m")

#Import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]; do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-s" "$SHELL")
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND=("${FINALCOMMAND[@]}" "-g" "$newPrimaryGroup")
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND=("${FINALCOMMAND[@]}" "--user-group")
    fi
fi

#ASK about additional groups
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$extraGroups"
for g in "${TEMP[@]}"; do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done

if [ ${#FINALEXTRAGROUPS[@]} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi


#ASK about the home directory
echo -n "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND=("${FINALCOMMAND[@]}" "-d" "$NEWHOME")
fi

#ADD the username to the command
FINALCOMMAND=("${FINALCOMMAND[@]}" "$USERNAME")

#PASSCOMMAND="sudo passwd $USERNAME"

#ADD THE USER
echo "useradd ${FINALCOMMAND[@]}"

useradd "${FINALCOMMAND[@]}"

passwd "$USERNAME"

chfn "$USERNAME"

注意：在较新版本的bash中，您可以使用+ =将值附加到数组，例如ARRAY + =（“值”）

另外，根据我的其他偏好，我会以这种方式进一步改进代码，但这还不是最好的：

#!/bin/bash

shopt -s extglob

# Check if running as root.
if [[ "$(id -u)" != 0 ]]; then
    echo "This script must be ran as root."
    exit 1
fi

# Initialize useradd command variable.
USERADDCOMMAND=("useradd" "-m")

# Import useradd defaults.
. /etc/default/useradd

# Get the new user's name.
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read NAME

# Get the new users username.
echo "The username must be 4-20 characters."
while :; do
    read -p "Please enter the user's requested username and press [ENTER]: " USERNAME
    [[ ${#USERNAME} -ge 4 && ${#USERNAME} -le 20 && $USERNAME == +([[:alpha:]])*([[:alnum:]_-]) ]] || {
        echo "Error: Username is invalid. Please enter a different username."
        continue
    }
    [[ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ]] && {
        echo "Error: Username is in use. Please enter a different username."
        continue
    }
    break
done

# Ask about the default shell.
read -p "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: " SHELL_
if [[ ${#SHELL_} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL_")
else
    # We use this if we really are to use SHELL specified in $SHELL but it still needs further workarounds like checking if $SHELL is valid. Those could be easily done but it depends if this one's really necessary.
    #USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-s" "$SHELL")
    :
fi

# Ask about a different primary group.
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username."
echo -n "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read NEWPRIMARYGROUP

if [[ ${#NEWPRIMARYGROUP} -eq 0 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
else
    if [[ $(grep -c "^${NEWPRIMARYGROUP}" /etc/group) -ge 1 ]]; then
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-g" "$NEWPRIMARYGROUP")
    else
        echo "Invalid group specified reverting to default!"
        USERADDCOMMAND=("${USERADDCOMMAND[@]}" "--user-group")
    fi
fi

# Ask about additional groups.
echo -n "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read EXTRAGROUPS
# Remove spaces if the user entered any.
EXTRAGROUPS="${EXTRAGROUPS//[[:space:]]}"
FINALEXTRAGROUPS=''
IFS=, read -a TEMP <<< "$EXTRAGROUPS"
for G in "${TEMP[@]}"; do
    if [[ $(grep -c "^${g}" /etc/group) -ge 1 ]]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$G"
    else
        echo "$G is an invalid user and will not be added."
    fi
done
if [[ ${#FINALEXTRAGROUPS[@]} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-G" "${FINALEXTRAGROUPS:1}")
fi

# Ask about the home directory
read -p "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: " NEWHOME
if [[ ${#NEWHOME} -ge 1 ]]; then
    USERADDCOMMAND=("${USERADDCOMMAND[@]}" "-d" "$NEWHOME")
fi

# Add the username to the command
USERADDCOMMAND=("${USERADDCOMMAND[@]}" "$USERNAME")

# Add THE USER
echo "> ${USERADDCOMMAND[*]}"
"${USERADDCOMMAND[@]}"

echo "> passwd $USERNAME"
passwd "$USERNAME"

echo "> chfn $USERNAME"
chfn "$USERNAME"  # -f "$NAME"

答案 3 :(得分：1)

根据您对调试内容的更新判断，您所做的与您发布的脚本不同。

无论如何，从调试输出，我怀疑你正在尝试使用双引号运行adduser命令

"$FINALCOMMAND"

或者也可能包含在反引号中，因为这似乎是触发“无此类文件或目录”错误消息的唯一情况。

摆脱双引号应解决问题。

p / s ：不要使用命令替换（``），除非您实际使用输出（例如，用于测试或分配变量），或者像这样的东西可能会发生

$ `echo Just saying hi`
Just: command not found

答案 4 :(得分：0)

我修复了脚本中的错误，只需删除行IFS =“，”

滥用环境变量IFS（内部字段分隔符）

脚本变为：

#!/bin/bash
#Add a new user

FINALCOMMAND="-m"

#import useradd defaults...
. /etc/default/useradd

#Check if running as root
if [ "$(id -u)" != "0" ]; then
    echo "This script must be ran as root"
    exit 1
fi

#Get the new users Name
#echo -n "Please enter the users First and Last Name and press [ENTER]: "
#read Name

#Get the new users username
echo "The username must be 4-20 characters."
echo -n "Please enter the users requested username and press [ENTER]: "
read USERNAME
while [ $(grep -c "^${USERNAME}:" /etc/passwd) -ge 1 ] || [ ${#USERNAME} -le 3 ] || [ ${#USERNAME} -ge 21 ]
do
    echo " "
    echo "Error: Username is in use or invalid.  Please select a different username."
    echo " "
    echo -n "Please enter the users requested username and press [ENTER]: "
    read USERNAME   
done #USERNAME will be valid from this point

#ASK about the default shell now
echo -n "Enter the new shell if you would like one (currently $SHELL) or leave blank for the default and press [ENTER]: "
read tempSHELL
if [ ${#tempSHELL} -ge 1 ]; then
    SHELL="$tempSHELL"
    FINALCOMMAND="$FINALCOMMAND ""-s $SHELL"
fi

#ASK about a different primary group
echo "Would you like to enter a non-default primary user group? Defaults to creating a new group that matches the username"
echo "Enter a new Primary Group or leave blank for the default and press [ENTER]: "
read newPrimaryGroup

if [ ${#newPrimaryGroup} -eq 0 ]; then
    FINALCOMMAND="$FINALCOMMAND --user-group"
else
    if [ $(grep -c "^${newPrimaryGroup}" /etc/group) -ge 1 ]; then
        FINALCOMMAND="$FINALCOMMAND -g $newPrimaryGroup"
    else
        echo "Invalid group specified reverting to default!"
        FINALCOMMAND="$FINALCOMMAND --user-group"
    fi
fi
#useradd -m --user-group jaredm2
#ASK about additional groups
echo "Would you like the new user to be a part of any additional groups?  Leave blank if no additional groups are needed or enter additional groups in the format of GROUP1,GROUP2,... (NO SPACES) and press [ENTER]: "
read extraGroups
#remove spaces if the user entered any
extraGroups="${extraGroups//[[:space:]]}"
FINALEXTRAGROUPS=""
#IFS=","
for g in $extraGroups
do
    if [ $(grep -c "^${g}" /etc/group) -ge 1 ]; then
        FINALEXTRAGROUPS="$FINALEXTRAGROUPS,$g"
    else
        echo "$g is invalid user will not be added..."
    fi
done
FINALEXTRAGROUPS=$(echo "$FINALEXTRAGROUPS" | tail -c +2)
if [ ${#FINALEXTRAGROUPS} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -G $FINALEXTRAGROUPS"
fi

#ASK about the home directory
echo "Would you like to enter a new home directory for the user?  Leave blank to use the default of $HOME/$USERNAME or enter your own and press [ENTER]: "
read NEWHOME

if [ ${#NEWHOME} -ge 1 ]; then
    FINALCOMMAND="$FINALCOMMAND -d $NEWHOME"
fi

#ADD the username to the command
FINALCOMMAND=`echo "$FINALCOMMAND $USERNAME" | sed 's/ *$//g' | sed 's/^ *//g'`
echo "useradd $FINALCOMMAND"
#PASSCOMMAND="sudo passwd $USERNAME"
#ADD THE USER
useradd $FINALCOMMAND

passwd $USERNAME

chfn $USERNAME
相关问题
最新问题