我试图为LPTHW完成额外的信用练习，但我已经碰壁了。我不断得到一个值错误，我不知道为什么。我知道我应该使用dict和类，但我还没有达到书中的那一部分。
我的想法是，我希望获得此库存功能，从列表character_sheet中删除以前的武器，并将其替换为用户刚购买的武器。这就是我认为的相关代码，如果我遗漏任何东西，请告诉我。
提前感谢，堆栈溢出确实帮助了我，因为我从没有以前的经验学习python。
weapon_choice = raw_input(":> ")
if "sword" in weapon_choice:
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_zero_weapons)
这是相关代码的下一部分。
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
这是我正在处理的列表。
# Weapon lists
level_zero_weapons = ['short sword', 'club', 'dagger']
level_one_weapons = ['sword', 'mace', 'rapier']
level_two_weapons = ['long sword', 'morningstar', 'trident']
level_three_weapons = ['claymore', 'flail', 'sycthe']
level_four_weapons = ['bastard sword', 'dragon bone', 'crystal halbred']
这是我的输出，我不明白，请告诉我是否应该添加更多代码。
Please tell me your name brave soul. :> Ray
Lets now randomly generate brave gladiator Ray.
[ 'Name: Ray:',
'Gender: Male',
'Character Class: Warrior',
'Strength: 11',
'Dexterity: 7',
'Constitution: 8',
'Damage 1D6',
'Crit Chance 10%',
'Hit Points: 6/6']
Please Press Enter To Buy A Weapon
Please type in the weapon you want to buy.
short sword, price: 1 gold pieces
club, price: 1 gold pieces
dagger, price: 1 gold pieces.
:> dagger
Your current weapon is now a dagger. Press Enter To Continue
Type in the weapon you want to buy, type quit to return to the barracks.
sword, price: 3 gold pieces
mace, price: 4 gold pieces
rapier, price: 5 gold pieces.
:> sword
Traceback (most recent call last):
File "lodarena.py", line 399, in <module>
character_gen()
File "lodarena.py", line 394, in character_gen
buy_weapon(level_one_weapons)
File "lodarena.py", line 144, in buy_weapon
character_sheet.remove(current_weapon)
ValueError: list.remove(x): x not in list
Raymond-Weisss-MacBook-Pro:lodarena Raylug$
# Doing Stuff for weapons and the shopkeeper. #################################
def level_zero_price():
"""Generates the price for level one weapons"""
return randint(1, 3)
def level_one_price():
"""Generates the price for level two weapons"""
return randint(3, 6)
def level_two_price():
"""Generates the price for level three weapons"""
return randint(6, 9)
def level_three_price():
"""Generates the price for level four weapons"""
return randint(9, 12)
def level_four_price():
"Generates the price for level four weapons"""
return randint(12, 15)
### Major Buying Stuff / Inventory Code ##########################################
def buy_weapon(weapons):
"""big bit of code that allows you to buy a weapons from a weapon list.
The function acts a little differently after level zero weapons"""
global current_weapon
if weapons == level_zero_weapons:
sword_price = level_zero_price()
blunt_price = level_zero_price()
agile_price = level_zero_price()
print t.bright_yellow_on_magenta + """
Please type in the weapon you want to buy.
%s, price: %d gold pieces
%s, price: %d gold pieces
%s, price: %d gold pieces.
""" % (weapons[0], sword_price, weapons[1], blunt_price,weapons[2],
agile_price)
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_zero_weapons)
elif weapons == level_one_weapons:
sword_price = level_one_price()
blunt_price = level_one_price()
agile_price = level_one_price()
print"""
Type in the weapon you want to buy, type quit to return to the barracks.
%s, price: %d gold pieces
%s, price: %d gold pieces
%s, price: %d gold pieces.
""" % (weapons[0], sword_price, weapons[1], blunt_price, weapons[2],
agile_price)
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_one_weapons)
elif weapons == level_two_weapons:
sword_price = level_two_price()
blunt_price = level_two_price()
agile_price = level_two_price()
print"""
Type in the weapon you want to buy, type quit to return to the barracks.
%s, price: %d gold pieces
%s, price: %d gold pieces
%s, price: %d gold pieces.
""" % (weapons[0], sword_price, weapons[1], blunt_price,weapons[2],
agile_price)
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_two_weapons)
elif weapons == level_three_weapons:
sword_price = level_three_price()
blunt_price = level_three_price()
agile_price = level_three_price()
print"""
Type in the weapon you want to buy, type quit to return to the barracks.
%s, price: %d gold pieces
%s, price: %d gold pieces
%s, price: %d gold pieces.
""" % (weapons[0], sword_price, weapons[1], blunt_price,weapons[2],
agile_price)
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_three_weapons)
elif weapons == level_four_weapons:
sword_price = level_four_price()
blunt_price = level_four_price()
agile_price = level_four_price()
print"""
Type in the weapon you want to buy, type quit to return to the barracks.
%s, price: %d gold pieces
%s, price: %d gold pieces
%s, price: %d gold pieces.
""" % (weapons[0], sword_price, weapons[1], blunt_price,weapons[2],
agile_price)
weapon_choice = raw_input(":> ")
if weapons[0] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[0]
inventory(weapons[0])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[1] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[1]
inventory(weapons[1])
character_sheet.append("Current Weapon %s" % current_weapon)
elif weapons[2] in weapon_choice:
character_sheet.remove(current_weapon)
current_weapon = weapons[2]
inventory(weapons[2])
character_sheet.append("Current Weapon %s" % current_weapon)
else:
print "I dont know what %s means" % weapon_choice
buy_weapon(level_four_weapons)
else:
print"~~~There is a bug somwhere, forgot to assign (weapons)\n\n\n"
raw_input(t.white_on_red("""
Your current weapon is now a %s. Press Enter To Continue
""" % current_weapon))
答案 0 :(得分：3)
没有看到更多我无法肯定的代码，但看起来问题是当你添加武器时，你正在做character_sheet.append("Current Weapon %s" % current_weapon)但后来你试图{{1} }。
第一个操作会在列表中添加一个看起来像“Current Weapon dagger”的字符串。第二个操作将尝试从列表中删除字符串“dagger”。但确切的字符串“匕首”不在列表中 - “当前武器匕首”是。所以Python崩溃是因为它被告知要从列表中删除“匕首”，但它找不到它 - 它只能找到不匹配的“当前武器匕首”。
有很多方法可以解决这个问题，因为你的代码有很多奇怪的东西，大概是因为你正在努力按照学习Python的方式按顺序工作，而你却没有学会了如何将代码概括为函数，关于不要重复自己的原则（如果/ elif / elif块基本上做同样的事情，那么所有这些都是“重复自己”）以及如何将数据存储在适当的数据结构中
我建议您继续学习课程并将此项目放在一边，然后，如果您以后仍然对它感兴趣，请经常参考它，看看如何应用您学到的新内容走。每一课你都会学到一些新内容，可以让你简化这些代码 - 例如，使用对象代替字符串来获取武器;只有在查看时才将输出格式化为人类可读的文本，而不是在存储它时;将字符表转换为对象或字典而不是列表;并使用if / elif / elif块进行比较，并将从角色表添加和删除武器的业务逻辑概括为函数。
如果您只是想解决此问题，那么您需要使正在删除的字符串与列表中的字符串以某种方式匹配。要么将不同的东西放入列表中（只是character_sheet.remove(current_weapon)而不是更长的字符串），要么实际搜索更长的字符串本身。或者，如果您确定这将是current_weapon数据，您只需删除列表中的最后一项。