黄瓜'给定'步骤通过,但同样'应该'步骤失败

时间:2012-09-15 09:20:09

标签: ruby-on-rails cucumber

我一直在参加SaaS课程,在第4章我们应该使用Cucumber。我按照所有说明观看了屏幕直播,显示了一切是如何工作的,但我仍然坚持这个错误:

  Scenario: Add a movie                              # features/AddMovie.feature:3

    Given I am on the RottenPotatoes home page       # features/step_definitions/web_steps.rb:44

    When I follow "Add new movie"                    # features/step_definitions/web_steps.rb:56

    Then I should be on the Create New Movie page    # features/step_definitions/web_steps.rb:230

    When I fill in "Title" with "Men In Black"       # features/step_definitions/web_steps.rb:60

    And I select "PG-13" from "Rating"               # features/step_definitions/web_steps.rb:85

    And I press "Save Changes"                       # features/step_definitions/web_steps.rb:52

    Then I should be on the RottenPotatoes home page # features/step_definitions/web_steps.rb:230

      <"/movies"> expected but was
      <"/movies/1">. (MiniTest::Assertion)
      ./features/step_definitions/web_steps.rb:235:in `/^(?:|I )should be on (.+)$/'
      features/AddMovie.feature:10:in `Then I should be on the RottenPotatoes home page'
    And I should see "Men In Black"                  # features/step_definitions/web_steps.rb:105

Failing Scenarios:
cucumber features/AddMovie.feature:3 # Scenario: Add a movie

Feature: User can manually add movie

Scenario: Add a movie
    Given I am on the RottenPotatoes home page
    When I follow "Add new movie"
    Then I should be on the Create New Movie page
    When I fill in "Title" with "Men In Black"
    And I select "PG-13" from "Rating"
    And I press "Save Changes"
    Then I should be on the RottenPotatoes home page
    And I should see "Men In Black"

以及path.rb

中的代码段
  def path_to(page_name)
    case page_name

    when /^the home\s?page$/
      '/'
    when /^the RottenPotatoes home page/
        movies_path
    when /^the Create New Movie page/
        new_movie_path
  end

movies_controller.rb

class MoviesController < ApplicationController
def index
    @movies = Movie.all( :order => "title" )
end

def show
    id = params[ :id ] #    retrieve movie ID from URI route
    begin
        @movie = Movie.find( id )
    rescue
        flash[ :warning ] = "The movie was not found."
        redirect_to movies_path
    end
    #   will render app/views/movies/show.html.haml by default
end

def new
    #   default: render 'new' template
end

def create
    @movie = Movie.create( params[ :movie ] )
    flash[ :notice ] = "#{ @movie.title } was successfully created."
    redirect_to movie_path( @movie.id )
end

def edit
    id = params[ :id ]
    @movie = Movie.find_by_id( id )
end

def update
    @movie = Movie.find_by_id params[ :id ]
    @movie.update_attributes!( params[ :movie ] )
    flash[ :notice ] = "#{ @movie.title } was successfully updated."
    redirect_to movie_path( @movie )
end

def destroy
    @movie = Movie.find( params[ :id ] )
    @movie.destroy
    flash[ :notice ] = "Movie '#{ @movie.title }' deleted."
    redirect_to movies_path
end

end

1 个答案:

答案 0 :(得分:1)

根据您发布的内容判断,您的代码和测试看起来不一致。在测试中,您在保存新电影后指定:

Then I should be on the RottenPotatoes home page

从您的path.rb文件判断,看起来它应该转换为“应该在电影索引页面上”。但是,在您的代码中,您不会在创建操作结束时重定向到电影索引页面,而是重定向到刚刚创建的电影的显示页面。这可以解释为什么黄瓜抱怨它期望<"/movies">(电影索引页面)但得到<"/movies/1">(带有id = 1的电影的页面)。

这是你的创作动作:

def create
  @movie = Movie.create( params[ :movie ] )
  flash[ :notice ] = "#{ @movie.title } was successfully created."
  redirect_to movie_path( @movie.id )
end

在最后一行中查看redirect_to movie_path(@movie.id),告诉rails将您转到电影@movie的页面。这是有道理的,通常是你想要的(即在用户创建新记录后,向他们显示他们创建的记录),但是你也可能想要将它们重定向到索引页面,在那里他们可以看到他们添加的电影与所有其他电影。根据您想要的结果,解决方案会有所不同。

假设您的测试正确无误,则需要将create操作中的最后一行更改为:

redirect_to movies_path

希望有所帮助!