Javascript通过函数传递title属性

时间:2012-08-16 15:04:43

标签: javascript

我有一个获取选择菜单值的功能,这项工作很棒。但我正在尝试为该函数添加另一个值。所以我想我会使用title属性作为选项(请参阅下面的代码)。问题是我的JavaScript函数中的用户名参数是undefined

有没有人对我做错什么有任何想法?

FORM

<form action="">
    <select id="acyear" name="acyear" onchange="showyearlogdays(this.value, this.title)">
    <option value="" label="">- Year -</option>
<?php

$is_business_result = mysql_query('SELECT DISTINCT(academic_year)FROM holiday_entitlement_business_manual WHERE employee = \'' . $username . '\''); 


    while($acyear_filter = mysql_fetch_array($is_business_result)) {
    echo '<option value="'.$acyear_filter['academic_year'].'" title="'.$username.'"';

    $datestr = $acyear_filter['academic_year'];
    $currentyear = substr($datestr, 0, 4);

    if(intval(substr($datestr,4,2)) < 8){$ayear = ($currentyear - 1).'/'.$currentyear;}
    else{$ayear = ($currentyear).'/'.($currentyear + 1);}       
        echo '>';

    echo $ayear;

    echo '</option>';
    }

?>    
    </select>
</form>

的Javascript

   function showyearlogdays(str, username)
 {
 if (str=="")
   {
   document.getElementById("txtHint").innerHTML="";
   return;
   } 
 if (window.XMLHttpRequest)
   {// code for IE7+, Firefox, Chrome, Opera, Safari
   xmlhttp=new XMLHttpRequest();
   }
 else
   {// code for IE6, IE5
   xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
   }
 xmlhttp.onreadystatechange=function()
   {
   if (xmlhttp.readyState==4 && xmlhttp.status==200)
     {
     document.getElementById("txtHint").innerHTML=xmlhttp.responseText;
     }
   }
 xmlhttp.open("GET","days_yearlog.php?username="+username+"&q="+str,true);
 xmlhttp.send();
 }

1 个答案:

答案 0 :(得分:2)

您需要获取所选选项的title属性。您的代码指向title标记的select属性。进行以下更改:

showyearlogdays(this.value, this.options[this.selectedIndex].title)

您还应该解决评论中提到的安全问题。您的查询设置方式将导致非常简单的SQL注入攻击。如果您不想按照评论者建议的方式重新构建它,我至少会逃避$username,以便无法注入SQL。