重定向后登录用户时出现奇怪错误

时间:2012-06-20 02:12:42

标签: ruby-on-rails ruby authentication

我想在创建帐户后自动为用户签名。我的应用程序是一个多租户,其中帐户在子域级别实施:* account_name.myapp.com *

我有一个Account模型has_many :owners, through: :ownerships。我正在使用accepts_nested_attributes_for使用一个表单创建帐户和用户模型。

我写了一个before_filter来处理登录,但我收到wrong number of arguments (1 for 0)错误。我不知道如何调试它。

创建帐户和用户模型后,我会重定向到Accounts#show - 错误发生的位置。我正在通过一个sign_in_token param。使用before_filter,我从令牌加载用户并在其上调用sign_in方法。

class AccountsController < ApplicationController
  before_filter :sign_in,  only: :show

  def show
    @account ||= Account.find_by_subdomain!(request.subdomain)
  end

  def new
    @account = Account.new
    @owner   = @account.owners.build
  end

  def create
    @account = Account.new(params[:account])
    if @account.save
      redirect_to root_url(subdomain: @account.subdomain, sign_in_token: @account.owners.first.sign_in_token)
    else
      render 'new'
    end
  end

  private

  def sign_in
    if params[:sign_in_token]
      user = User.find_by_sign_in_token(params[:sign_in_token])
      sign_in user
    end
  end
end

我的sign_in方法正常工作,我已经编写了测试。它只会在这种情况下中断。

  def sign_in(user)
    cookies.permanent[:remember_token] = user.remember_token
    current_user = user
  end

错误:

ArgumentError in AccountsController#show

wrong number of arguments (1 for 0)

堆栈

app/controllers/accounts_controller.rb:31:in `sign_in'
app/controllers/accounts_controller.rb:34:in `sign_in'
activesupport (3.2.3) lib/active_support/callbacks.rb:429:in `_run__3150241459892085714__process_action__1436783733275598907__callbacks'
activesupport (3.2.3) lib/active_support/callbacks.rb:405:in `__run_callback'
activesupport (3.2.3) lib/active_support/callbacks.rb:385:in `_run_process_action_callbacks'
activesupport (3.2.3) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (3.2.3) lib/abstract_controller/callbacks.rb:17:in `process_action'
actionpack (3.2.3) lib/action_controller/metal/rescue.rb:29:in `process_action'
actionpack (3.2.3) lib/action_controller/metal/instrumentation.rb:30:in `block in process_action'
activesupport (3.2.3) lib/active_support/notifications.rb:123:in `block in instrument'
activesupport (3.2.3) lib/active_support/notifications/instrumenter.rb:20:in `instrument'
activesupport (3.2.3) lib/active_support/notifications.rb:123:in `instrument'
actionpack (3.2.3) lib/action_controller/metal/instrumentation.rb:29:in `process_action'
actionpack (3.2.3) lib/action_controller/metal/params_wrapper.rb:205:in `process_action'
activerecord (3.2.3) lib/active_record/railties/controller_runtime.rb:18:in `process_action'
actionpack (3.2.3) lib/abstract_controller/base.rb:121:in `process'
actionpack (3.2.3) lib/abstract_controller/rendering.rb:45:in `process'
actionpack (3.2.3) lib/action_controller/metal.rb:203:in `dispatch'
actionpack (3.2.3) lib/action_controller/metal/rack_delegation.rb:14:in `dispatch'
actionpack (3.2.3) lib/action_controller/metal.rb:246:in `block in action'
actionpack (3.2.3) lib/action_dispatch/routing/route_set.rb:73:in `call'
actionpack (3.2.3) lib/action_dispatch/routing/route_set.rb:73:in `dispatch'
actionpack (3.2.3) lib/action_dispatch/routing/route_set.rb:36:in `call'
actionpack (3.2.3) lib/action_dispatch/routing/mapper.rb:40:in `call'
journey (1.0.3) lib/journey/router.rb:68:in `block in call'
journey (1.0.3) lib/journey/router.rb:56:in `each'
journey (1.0.3) lib/journey/router.rb:56:in `call'
actionpack (3.2.3) lib/action_dispatch/routing/route_set.rb:600:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/best_standards_support.rb:17:in `call'
rack (1.4.1) lib/rack/etag.rb:23:in `call'
rack (1.4.1) lib/rack/conditionalget.rb:25:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/head.rb:14:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/params_parser.rb:21:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/flash.rb:242:in `call'
rack (1.4.1) lib/rack/session/abstract/id.rb:205:in `context'
rack (1.4.1) lib/rack/session/abstract/id.rb:200:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/cookies.rb:338:in `call'
activerecord (3.2.3) lib/active_record/query_cache.rb:64:in `call'
activerecord (3.2.3) lib/active_record/connection_adapters/abstract/connection_pool.rb:467:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
activesupport (3.2.3) lib/active_support/callbacks.rb:405:in `_run__1668768892136358850__call__837556511977231927__callbacks'
activesupport (3.2.3) lib/active_support/callbacks.rb:405:in `__run_callback'
activesupport (3.2.3) lib/active_support/callbacks.rb:385:in `_run_call_callbacks'
activesupport (3.2.3) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (3.2.3) lib/action_dispatch/middleware/callbacks.rb:27:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/reloader.rb:65:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/remote_ip.rb:31:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/debug_exceptions.rb:16:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'
railties (3.2.3) lib/rails/rack/logger.rb:26:in `call_app'
railties (3.2.3) lib/rails/rack/logger.rb:16:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/request_id.rb:22:in `call'
rack (1.4.1) lib/rack/methodoverride.rb:21:in `call'
rack (1.4.1) lib/rack/runtime.rb:17:in `call'
activesupport (3.2.3) lib/active_support/cache/strategy/local_cache.rb:72:in `call'
rack (1.4.1) lib/rack/lock.rb:15:in `call'
actionpack (3.2.3) lib/action_dispatch/middleware/static.rb:62:in `call'
railties (3.2.3) lib/rails/engine.rb:479:in `call'
railties (3.2.3) lib/rails/application.rb:220:in `call'
rack (1.4.1) lib/rack/content_length.rb:14:in `call'
railties (3.2.3) lib/rails/rack/log_tailer.rb:14:in `call'
rack (1.4.1) lib/rack/handler/webrick.rb:59:in `service'
/home/mohamad/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/httpserver.rb:138:in `service'
/home/mohamad/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/httpserver.rb:94:in `run'
/home/mohamad/.rvm/rubies/ruby-1.9.3-p0/lib/ruby/1.9.1/webrick/server.rb:191:in `block in start_thread'

2 个答案:

答案 0 :(得分:1)

您所使用的功能名称与

相同
def **sign_in**
  if params[:sign_in_token]
    user = User.find_by_sign_in_token(params[:sign_in_token])
    **sign_in user**
  end
end

所以sign_in用户试图调用它所定义的函数,但是带有参数。可能不是你的意思。

至于如何调试,一旦你发布了堆栈跟踪,它就变得很明显了。当没有人预期时,sign_in user被传递了一个参数(1/0)......原因是它上面有三行。 :)

答案 1 :(得分:1)

您在控制器中定义了一个sign_in方法,该方法隐藏了您使用的身份验证库提供的sign_in方法,因此您的sign_in不会使用参数一个。解决此问题的方法是将您的方法重命名为其他方法:

class AccountsController < ApplicationController
  before_filter :sign_in_user,  only: :show

  def show
    @account ||= Account.find_by_subdomain!(request.subdomain)
  end

  def new
    @account = Account.new
    @owner   = @account.owners.build
  end

  def create
    @account = Account.new(params[:account])
    if @account.save
      redirect_to root_url(subdomain: @account.subdomain, sign_in_token: @account.owners.first.sign_in_token)
    else
      render 'new'
    end
  end

  private

  def sign_in_user
    if params[:sign_in_token]
      user = User.find_by_sign_in_token(params[:sign_in_token])
      sign_in user
    end
  end
end

现在应该可以了。