内存泄漏sqlite iOS应用程序

时间:2012-06-13 15:35:30

标签: ios memory sqlite nsmutablearray memory-leaks

我目前正在努力解决一些内存泄漏问题,并且在解决我遗留的最后一个问题时遇到了一些麻烦。泄漏工具显示几个泄漏都来自同一方法,原因各种各样,主要归因于NSCFString,NSMutableArray和我称之为GraphData的类。我试图以几种不同的方式来解决这个问题,所以希望能够解决这个问题的一些亮点,希望这是我忽略的一些简单。

以下是一些代码:

// the offending, leaking method
-(NSMutableArray*)fillDataInArray:(NSInteger)keyphrase_id{

    NSLog(@"Keyphrase_id:%d", keyphrase_id);

    NSDate *startdate = [self getDateForApplicationInstalled];
    NSDate *enddate = [NSDate date];

    NSString *dateString1=[[NSString alloc] initWithString: [fmt stringFromDate:startdate]];
    NSString *dateString2=[[NSString alloc] initWithString: [fmt stringFromDate:enddate]];

    NSMutableArray *newDataNew = [[NSMutableArray alloc]init];
    self.newData = newDataNew;
    [newDataNew release];

    selStmt = nil;

    if (!selStmt)
    {
        const char *sql = "select distinct position, key_time from ranking where keyphrase_id = ? and key_time between ? and ? order by key_time";

        if (sqlite3_prepare_v2(database, sql, -1, &selStmt, NULL) != SQLITE_OK)
        {
            selStmt = nil;
        }

        NSInteger n = keyphrase_id;
        sqlite3_bind_int(selStmt, 1, n);

        sqlite3_bind_text(selStmt, 2, [dateString1 UTF8String] , -1, SQLITE_TRANSIENT);
        sqlite3_bind_text(selStmt, 3, [dateString2 UTF8String] , -1, SQLITE_TRANSIENT);

        NSLog(@"SQL query is: [%s]", sql);
    }
    if (!selStmt)
    {
        NSAssert1(0, @"Can't build SQL to read keyphrases [%s]", sqlite3_errmsg(database));
    }

    int ret;

    while ((ret=sqlite3_step(selStmt))==SQLITE_ROW) 
    { 
        GraphData *item = [[GraphData alloc]init];

        item.key = sqlite3_column_int(selStmt, 0);
        item.value = [NSString stringWithUTF8String:(char *)sqlite3_column_text(selStmt,1)];

        [newData addObject:item]; 

        [item release], item = nil;
    }

    sqlite3_reset(selStmt); // reset (unbind) statement

    [dateString2 release];
    [dateString1 release];

    return newData;
}

//GraphData.h
@interface GraphData : NSObject{
    NSInteger key;
    NSString *value;
}

@property (nonatomic, readwrite) NSInteger key;
@property (nonatomic, retain) NSString *value;

-(id)initWithPrimaryKey:(NSInteger) xid;
-(id)initWithName:(NSString *)n key:(NSInteger)i;

@end

//GraphData.m
#import "GraphData.h"

@implementation GraphData

@synthesize  key,value;

-(id)initWithPrimaryKey:(NSInteger) xid{

    self.key = xid;
    self.value = @"";

    return self;

}
-(id)initWithName:(NSString *)n key:(NSInteger)i{

    self.key = 0;
    self.value = n;

    return self;

}
-(void)dealloc{


    [value release], value = nil;
    [super dealloc];

}

@end

感谢您查看我的帖子!

1 个答案:

答案 0 :(得分:0)

泄漏工具会告诉您创建了泄漏对象的位置。由于NSCFString,NSMutableArray和GraphData对象都是从这个方法中泄露出来的,让我们来看看这是如何发生的。

只在NSMutableArray中插入GraphData对象(包含字符串对象),它们似乎已正确释放。因此,要泄漏在此方法中创建的GraphData对象,包含元素的数组必须是泄漏。

请检查方法的来电者。我假设其中一个保留(并且不释放)方法的返回值。

此外,您的初始化程序必须更改为调用super的init,但这与泄漏无关。一个例子:

-(id)initWithPrimaryKey:(NSInteger) xid
{
    self = [super init];
    if (self) {
        self.key = xid;
        self.value = @"";
    }
    return self;   
}