第一个更大(常见)的lisp程序 - > '随机'没有按预期工作

时间:2012-05-23 17:46:38

标签: lisp common-lisp clisp sbcl

为了好玩,我在Python中编写了"monty hall problem"的模拟。后来我尝试了Lua,并决定再次在Lua中编写它,看看它的外观如何。这是一个非常有趣的体验,即使程序看起来非常相似(Lua版本略短)。最近我开始用CL进行表演,并希望再次做同样的事情。但是当我运行它时,它的行为并不像预期的那样。出于某种原因,不稳定的球员(谁应该获得66%的获胜机会)与天真球员的得分几乎相同(有50%的机会获胜)。

有人可以给我一个暗示出了什么问题吗?这不是一个家庭作业或类似的东西,只是我第一次尝试用CL写一个更大的程序。除了上述问题的提示外,我还欢迎有关如何改进我的风格的建议。我猜它仍然是Python-ish(它或多或少是直接翻译)。

(defun choose-one (l)
  "Ramdomly chooses one element of the given list"
  (nth (random (length l)) l))

(defun remove-one (l)
  "Randomly removes one element of the given list"
  (remove (choose-one l) l))

(defun naive-player (initial-choice possible-choices)
  "The naive player randomly picks one choice. Should have a 50% chance to win."
  initial-choice ;keep compiler happy
  (choose-one possible-choices))

(defun stubborn-player (initial-choice possible-choices)
  "The stubborn player sticks with his initial choice. Should have a 33% chance to win."
  possible-choices ;keep compiler happy
  initial-choice)

(defun erratic-player (initial-choice possible-choices)
  "The erratic player will always change his choice. Should have a 66% chance to win."
  (choose-one (remove initial-choice possible-choices)))

(defun host-offer (prize possible-choices)
  "The host reveals one wrong choice."
  (let ((remaining (remove prize possible-choices)))
    (remove (choose-one remaining) possible-choices)))

(defun one-game (playerfn choices)
  "Simulates a single game with the given player. Evaluates to T if the player won."
  (let ((prize (choose-one choices))
        (player-choice (choose-one choices)))
    (eq (funcall playerfn player-choice (host-offer prize choices)) prize)))


(defun multiple-games (num-games)
  "Simulates the given number of games with all players. Evaluates to a result list."
  (let ((choices '(door_a door_b door_c))
        (naive-score 0)
        (stubborn-score 0)
        (erratic-score 0))
    ;(progn
      (dotimes (i num-games)
        ;(progn
          (if (one-game #'naive-player choices)
              (incf naive-score))
          (if (one-game #'stubborn-player choices)
              (incf stubborn-score)) 
          (if (one-game #'erratic-player choices)
              (incf erratic-score)));)
      (list 
       (list 'naive-player naive-score) 
       (list 'stubborn-player stubborn-score)
       (list 'erratic-player erratic-score))));)

;; Run simulation and display results
(defparameter *num-games* 10000)
(format *standard-output* "--- Monty Hall ---~%")
(format *standard-output* "Simulating ~D games...~%" *num-games*)
(let ((result (multiple-games *num-games*)))
  (format *standard-output* "~{~{~A score: ~D~}~%~}" result))

输出(例如):

--- Monty Hall ---
Simulating 10000 games...
NAIVE-PLAYER score: 5014
STUBBORN-PLAYER score: 3333
ERRATIC-PLAYER score: 4968

1 个答案:

答案 0 :(得分:6)

主机提供功能有误。在定义的Monty Hall问题中,主机永远不会打开玩家选择的门,但是你的程序并没有考虑到这一点。如果修复了,程序将返回预期的结果。