includeViewParams = true不能与迭代集合的复合组件结合使用

时间:2012-01-31 11:53:26

标签: java jsf-2 post-redirect-get

注意:这个问题经过大量编辑,因为人们发现了一个人为的例子。但是,问题仍然与基本相同,人为的例子似乎有效。

考虑以下JSF页面:

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
    xmlns:h="http://java.sun.com/jsf/html"
    xmlns:f="http://java.sun.com/jsf/core" xmlns:ui="http://java.sun.com/jsf/facelets">
    <f:view contentType="text/html">
        <h:head>
            <title>Page</title>
        </h:head>
        <h:body>
            <ui:composition template="/WEB-INF/templates/myLayout.xhtml">
                <ui:define name="metadata">
                    <f:metadata>
                        <f:viewParam name="foobar" value="#{pageBean.foo}"/>
                    </f:metadata>
                </ui:define>
                <ui:define name="content">
                    <h:form>
                        <h:commandLink value="Click"
                                    action="#{util.currentPageAction()}"/>
                    </h:form>
                </ui:define>
            </ui:composition>
        </h:body>
    </f:view>
</html>

这些豆子:

@Named
@RequestScoped
public class PageBean implements Serializable
{
    public String getFoo()
    {
        return foo;
    }

    public void setFoo(String foo)
    {
        this.foo = foo;
    }

    private String foo;
}
@Named
@ApplicationScoped
public class Util implements Serializable
{
    public String currentPageAction()
    {
        return FacesContext.getCurrentInstance().getViewRoot().getViewId() +
                   "?faces-redirect=true&includeViewParams=true";
    }
}

这个设计的示例实际上按预期执行 - 特别是,它在重定向时将视图参数的原始值传递给URL。因此,例如,如果原始网址为http://localhost:8080/faces/pages/test.xhtml?foo=bar,当我点击<h:commandLink/>时,完整网址(包括视图参数)将在重定向后继续存在。

问题是,当我从这个人为的例子变成更真实的东西(在我的例子中是一个搜索页面)时,视图参数不会在重定向中存活。

这是它不起作用的真实世界页面。对不起,典型的stackoverflow问题有点冗长。

<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:ui="http://java.sun.com/jsf/facelets"
      xmlns:f="http://java.sun.com/jsf/core"
      xmlns:p="http://primefaces.org/ui"
      xmlns:search="http://java.sun.com/jsf/composite/components/search"
      xmlns:oc="http://java.sun.com/jsf/composite/components/mysite"
      xmlns:fn="http://www.mysite.com.au/jsf">
    <h:head>
        <title></title>
    </h:head>
    <h:body>
        <ui:composition template="/WEB-INF/templates/myLayout.xhtml">
            <ui:define name="metadata">
                <f:metadata>
                    <f:viewParam name="address" value="#{searchBean.address}"/>
                    <f:viewParam name="lng" value="#{searchBean.longitude}" required="#{!facesContext.postback}" requiredMessage="Longitude is required" validatorMessage="Longitude is invalid">
                        <f:validateDoubleRange minimum="-180" maximum="180"/>
                    </f:viewParam>
                    <f:viewParam name="lat" value="#{searchBean.latitude}" required="#{!facesContext.postback}" requiredMessage="Latitude is required" validatorMessage="Latitude is invalid">
                        <f:validateDoubleRange minimum="-90" maximum="90"/>
                    </f:viewParam>
                    <f:viewParam name="gender" value="#{searchBean.gender}"/>
                    <f:viewParam name="language" value="#{searchBean.spokenLanguageId}"/>
                    <f:viewParam name="service" value="#{searchBean.serviceId}"/>
                    <f:viewParam name="rangeKm" value="#{searchBean.rangeKm}" validatorMessage="Range (km) is invalid">
                        <f:validateLongRange minimum="1"/>
                    </f:viewParam>
                    <f:viewParam name="weeksOffset" value="#{searchBean.weeksOffset}"/>
                    <f:event type="preRenderView" listener="#{searchBean.preRender(e)}"/>
                </f:metadata>
            </ui:define>
            <ui:define name="windowTitle">#{searchBean.address}</ui:define>
            <ui:define name="scripts">
                <script type="text/javascript">
                    var mysite = mysite || {};
                    mysite.longitude      = #{searchBean.longitude};
                    mysite.latitude       = #{searchBean.latitude};
                    mysite.defaultAddress = "#{applicationBean.defaultAddress}";
                    mysite.region         = "#{applicationBean.region}";
                    mysite.baseUrl        = "#{applicationBean.baseUrl}";
                </script>
                <h:outputScript library="javascript" name="map2.js"/>
                <h:outputScript name="geocode.js" library="javascript" target="head"/>
                <h:outputScript name="search.js" library="javascript" target="head"/>
            </ui:define>

            <ui:define name="rightSidebar">
                <div class="ocSearch_sidebarSection">
                    <oc:map styleClass="search"/>
                    <div>
                        <a style="font-size:11px;text-decoration:underline;" href="#" onclick="mysite.resetMap();return false;">Reset</a>
                    </div>
                </div>

                <oc:context-menu-container isFirstChild="false">
                    <oc:context-menu title="Search Options">
                        <form id="searchForm" method="get" onsubmit="return mysite.geocode(this);">
                            <div style="clear:both;float:left;">
                                <label for="ocSearchRadius">Service Providers within</label>
                                <div id="ocSearchRadius">
                                    <input type="text" id="ocRangeKm" name="rangeKm" value="#{searchBean.rangeKm}" style="width:20px;float:left;"/>
                                    <div style="width:40px;margin-top:5px;float:left;overflow:hidden;text-align:center;vertical-align:bottom;">km of</div>
                                    <input type="text" id="ocAddress" name="address" value="#{searchBean.address}" style="width:104px;float:left;"/>
                                </div>
                            </div>
                            <div style="float:left;">
                                <div style="width:60px;margin-right:10px;float:left;">
                                    <label for="ocGender" style="display:block;">Gender</label>
                                    <select id="ocGender" name="gender" style="width:50px;">
                                        <h:panelGroup rendered="#{searchBean.gender eq 'any'}">
                                            <option value="any" selected="selected">Any</option>
                                            <option value="female">Female</option>
                                            <option value="male">Male</option>
                                        </h:panelGroup>
                                        <h:panelGroup rendered="#{searchBean.gender eq 'female'}">
                                            <option value="any">Any</option>
                                            <option value="female" selected="selected">Female</option>
                                            <option value="male">Male</option>
                                        </h:panelGroup>
                                        <h:panelGroup rendered="#{searchBean.gender eq 'male'}">
                                            <option value="any">Any</option>
                                            <option value="female">Female</option>
                                            <option value="male" selected="selected">Male</option>
                                        </h:panelGroup>
                                    </select>
                                </div>
                                <div style="float:left;">
                                    <label for="ocLanguage">Language</label>
                                    <select id="ocLanguage" name="language" style="width:176px;">
                                        <ui:repeat value="#{commonRequestBean.spokenLanguageItems}" var="item">
                                            <h:panelGroup rendered="#{searchBean.spokenLanguageId eq item.value}">
                                                <option value="#{item.value}" selected="yes">#{item.label}</option>
                                            </h:panelGroup>
                                            <h:panelGroup rendered="#{searchBean.spokenLanguageId ne item.value}">
                                                <option value="#{item.value}">#{item.label}</option>
                                            </h:panelGroup>
                                        </ui:repeat>
                                    </select>
                                </div>
                            </div>
                            <div style="float:left;">
                                <label for="ocService">Reason for visit</label>
                                <select id="ocService" name="service" style="width:176px;" >
                                    <ui:repeat value="#{commonRequestBean.serviceItems}" var="item">
                                        <h:panelGroup rendered="#{searchBean.serviceId eq item.value}">
                                            <option value="#{item.value}" selected="yes">#{item.label}</option>
                                        </h:panelGroup>
                                        <h:panelGroup rendered="#{searchBean.serviceId ne item.value}">
                                            <option value="#{item.value}">#{item.label}</option>
                                        </h:panelGroup>
                                    </ui:repeat>
                                </select>
                            </div>

                            <div style="float:left;">
                                <label for="ocStartDate">From</label>
                                <select id="ocStartDate" name="weeksOffset" style="width:176px;">
                                    <ui:repeat value="#{fn:selectableDates(13)}" var="date" varStatus="dateStatus">
                                        <h:panelGroup rendered="#{date.value eq searchBean.weeksOffset}">
                                            <option value="#{date.value}" selected="yes">#{date.label}</option>
                                        </h:panelGroup>
                                        <h:panelGroup rendered="#{date.value ne searchBean.weeksOffset}">
                                            <option value="#{date.value}">#{date.label}</option>
                                        </h:panelGroup>
                                    </ui:repeat>
                                </select>
                            </div>

                            <div style="margin-top:8px;float:left;">
                                <p:button id="searchAgainButton" value="Search Again"/>
                                <script type="text/javascript">
                                    //<![CDATA[
                                    $(function(){
                                        // Replace the Search Again button with a clone whose type is submit.
                                        var oldButton = $('#searchAgainButton');
                                        var newButton = oldButton.clone(true);
                                        newButton.attr("type","submit");
                                        newButton.attr("id","searchAgainButtonClone");
                                        newButton.removeAttr("onclick");
                                        newButton.insertBefore(oldButton);
                                        oldButton.remove();
                                        newButton.attr("id","searchAgainButton");
                                    });
                                    //]]>
                                </script>
                            </div>

                            <input type="hidden" id="ocLng"     name="lng"     value="#{searchBean.longitude}"/>
                            <input type="hidden" id="ocLat"     name="lat"     value="#{searchBean.latitude}"/>
                        </form>
                        <script>
                            // Ensure the form fields are set to the current values. (Webkit bug workaround.)
                            $(function(){
                                $('#ocRangeKm').val('#{searchBean.rangeKm}');
                                $('#ocAddress').val('#{searchBean.address}');
                                $('#ocGender').val('#{searchBean.gender}');
                                $('#ocLanguage').val('#{searchBean.spokenLanguageId}');
                                $('#ocService').val('#{searchBean.serviceId}');
                                $('#ocStartDate').val('#{searchBean.weeksOffset}');
                            });
                        </script>
                    </oc:context-menu>
                </oc:context-menu-container>
            </ui:define>

            <ui:define name="content">
                <div id="ocSearchResultsHeader" class="fixed">
                    <div style="margin-left:10px;">
                        <h3 style="margin:8px 0 4px 0;">#{searchBean.searchResultsTitle}</h3>
                        <span class="help">Click a time to book #{searchBean.service.indefiniteArticle} #{searchBean.service.name}</span>
                    </div>
                </div>
                <div class="ocSearch_resultSet">
                    <h:form>
                        <h:commandLink value="Foobar" action="#{util.currentPageAction}"/>
                    </h:form>
                    <search:result resultSet="#{searchBean.results}" startDate="#{searchBean.startDate}"/>
                </div>
            </ui:define>
        </ui:composition>
    </h:body>
</html>

底层bean searchBean是请求作用域,就像人为的例子一样。

更新:如果我删除了<search:result/>复合组件实例,它现在可以正常运行了。这完全出乎意料。类似地,如果我将组件实例留在那里并剥离组件本身,它就可以工作。因此组件中的某些东西会干扰其他内容。奇怪的。我会看看能不知道它是什么。

更新:这看起来像个错误。如果我用这个替换复合组件:

<ui:repeat value="#{searchBean.results} var="item" varStatus="itemStatus">
    <h:outputText value="#{item.mapMarker}"/>
    <br/>
</ui:repeat>

它也会失败,就像复合组件一样。

同样,这也失败了:

<h:dataTable value="#{searchBean.results}" var="item">
    <h:column>
        <h:outputText value="#{item.mapMarker}"/>
        <br/>
    </h:column>
</h:dataTable>

在我的特定情况下,有三个结果,所以我可以手动迭代它们:

<ui:param name="results" value="#{searchBean.results}"/>
<br/>
<h:outputText value="#{results.get(0).mapMarker}"/>
<br/>
<h:outputText value="#{results.get(1).mapMarker}"/>
<br/>
<h:outputText value="#{results.get(2).mapMarker}"/>
<br/>

它有效。

因此有一些关于迭代结果的事情正在与<h:commandLink/>紧密相关。

究竟什么可能出错?另一个Mojarra bug,一个简单的用例失败了吗?

最终更新:使用人为的示例缩小问题并移动问题here

1 个答案:

答案 0 :(得分:1)

这是一个错误,我无法弄清楚它是JDK7,Mojarra,EJB容器,GlassFish,还是两个或更多这些错误的混合。

考虑SearchBean的以下代码段:

public List<NormalizedSearchResult> getResults()
{
    return searchEjb.findByLocation(getRangeKm(),
                                    getLongitude(),
                                    getLatitude(),
                                    gender,
                                    getSpokenLanguageId(),
                                    getServiceId(),
                                    1,
                                    99,
                                    getStartDate().toDateMidnight().toDate(),
                                    7);
}

public List<NormalizedSearchResult> getResults2()
{
    float lng = longitude;
    float lat = latitude;
    return searchEjb.findByLocation(getRangeKm(),
                                    lng,
                                    lat,
                                    gender,
                                    getSpokenLanguageId(),
                                    getServiceId(),
                                    1,
                                    99,
                                    getStartDate().toDateMidnight().toDate(),
                                    7);
}

public List<NormalizedSearchResult> getResults3()
{
    float lng = getLongitude();
    float lat = getLatitude();
    return searchEjb.findByLocation(getRangeKm(),
                                    lng,
                                    lat,
                                    gender,
                                    getSpokenLanguageId(),
                                    getServiceId(),
                                    1,
                                    99,
                                    getStartDate().toDateMidnight().toDate(),
                                    7);
}

public List<NormalizedSearchResult> getResults4()
{
    float lng = longitude;
    float lat = latitude;
    return searchEjb.findByLocation(getRangeKm(),
                                    138.5999594f,
                                    -34.9286212f,
                                    gender,
                                    getSpokenLanguageId(),
                                    getServiceId(),
                                    1,
                                    99,
                                    getStartDate().toDateMidnight().toDate(),
                                    7);
}

public List<NormalizedSearchResult> getResults5()
{
    float lng = 138.5999594f;
    float lat = -34.9286212f;
    return searchEjb.findByLocation(getRangeKm(),
                                    lng,
                                    lat,
                                    gender,
                                    getSpokenLanguageId(),
                                    getServiceId(),
                                    1,
                                    99,
                                    getStartDate().toDateMidnight().toDate(),
                                    7);
}

public Float getLongitude()
{
    return longitude;
}

public void setLongitude(Float longitude)
{
    this.longitude = longitude;
}

public Float getLatitude()
{
    return latitude;
}

public void setLatitude()
{
    this.latitude = latitude;
}

private Float longitude;
private Float latitude;

如果search.xhtml中包含这些片段,导致includeViewParams=true导致<h:commandLink/>失败:

<ui:repeat value="#{searchBean.results}"/>
<ui:repeat value="#{searchBean.results2}"/>
<ui:repeat value="#{searchBean.results3}"/>
<ui:repeat value="#{searchBean.results4}"/>

然而,这个不具有相同的不良影响:

<ui:repeat value="#{searchBean.results5}"/>

这也不是:

<ui:param name="results" value="#{pageBean.results}"/>
<h:outputText value="#{results.get(0).mapMarker}"/>
<br/>
<h:outputText value="#{results.get(1).mapMarker}"/>
<br/>
<h:outputText value="#{results.get(2).mapMarker}"/>
<br/>

当然,includeViewParams=true在没有使用这些xhtml代码段的情况下有效。

然后,我将longitudelatitude私有变量的类型从Float更改为float,并且不再针对上述任何情况发生这些失败。

WTF?严重?

在渲染视图的早期阶段,有人可能会想到取消装箱视图参数会中断includeViewParams=true吗?

JAVASERVERFACES-2260的评论。