使用Richfaces ExtendedDataTable的ConcurrentModificationException

时间:2012-01-31 08:00:06

标签: java jsf synchronization richfaces

我为一个冗长的问题道歉,但我真的需要你的帮助。作为我们项目的一部分,我目前正在开发一个搜索引擎,可以即时更新结果列表:用户输入前4个字符及以上字符,当他输入时,结果列表会发生变化。搜索值在文本框中键入,而结果显示在Richfaces组件rich:extendedDataTable下面。如果删除搜索值,则结果列表为空。我能够让它工作,但是,经过几次尝试后,我得到了ConcurrentModificationException,由组件本身抛出。我正在搜索的初始列表来自属性文件(因为我不希望每次用户输入内容时搜索都会命中数据库)。几个月来我一直在敲打它。我错过了什么?让我告诉你我做了什么:

这是应该触发搜索逻辑的输入文本(我确保当值小于4个字符时,或者如果用户按下键,如箭头,移位和ctrl,表格不会更新 - 此功能是“returnunicode(event)”):

   <h:inputText id="firmname" value="#{ExtendedTableBean.searchValue}">
       <a4j:support reRender="resultsTable" onsubmit="
           if ((this.value.length<4 && this.value.length>0) || !returnunicode(event)) {
               return false;
           }" actionListener="#{ExtendedTableBean.searchForResults}" event="onkeyup" />
   </h:inputText>

动作侦听器应该更新列表。这是extendedDataTable,位于inputText:

的正下方
   <rich:extendedDataTable tableState="#{ExtendedTableBean.tableState}" var="item"
                           id="resultsTable" value="#{ExtendedTableBean.dataModel}">

            ... <%-- I'm listing columns here --%>

   </rich:extendedDataTable>

现在,如果没问题,我想向您展示后端代码。我只留下了对我的问题很重要的逻辑。

 /*
  * To change this template, choose Tools | Templates
  * and open the template in the editor.
  */

 package com.beans;

 import java.io.FileInputStream;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.ConcurrentModificationException;
 import java.util.List;
 import java.util.Properties;
 import java.util.concurrent.CopyOnWriteArrayList;
 import javax.faces.context.FacesContext;
 import javax.faces.event.ActionEvent;
 import org.richfaces.model.DataProvider;
 import org.richfaces.model.ExtendedTableDataModel;

 public class ExtendedTableBean {      
     private String sortMode="single";
     private ExtendedTableDataModel<ResultObject> dataModel;
     //ResultObject is a simple pojo and getResultsPerValue is a method that 
     //read the data from the properties file, assigns it to this pojo, and
     //adds a pojo to the list 

     private Object tableState;
     private List<ResultObject> results = new CopyOnWriteArrayList<ResultObject>();
     private List<ResultObject> selectedResults = 
                                          new CopyOnWriteArrayList<ResultObject>();

     private String searchValue;

     /**
      * This is the action listener that the user triggers, by typing the search value
      */
     public void searchForResults(ActionEvent e) {
        synchronized(results) {
           results.clear();
        }        

        //I don't think it's necessary to clear results list all the time, but here
        //I also make sure that we start searching if the value is at least 4 
        //characters long
        if (this.searchValue.length() > 3) {
           results.clear();
           updateTableList();
        } else {
           results.clear();
        }

        dataModel = null; // to force the dataModel to be updated.
     }

     public List<ResultObject> getResultsPerValue(String searchValue) {
        List<ResultObject> resultsList = new CopyOnWriteArrayList<ResultObject>();

        //Logic for reading data from the properties file, populating ResultObject
        //and adding it to the list

        return resultsList;
     }

     /**
      * This method updates a firm list, based on a search value
      */
     public void updateTableList() {
         try {              
            List<ResultObject> searchedResults = getResultsPerValue(searchValue);

            //Once the results have been retrieved from the properties, empty 
            //current firm list and replace it with what was found.

            synchronized(firms) {
                firms.clear();
                firms.addAll(searchedFirms);
            }
         } catch(Throwable xcpt) {
            //Exception handling
         }
     }

     /**
      * This is a recursive method, that's used to constantly keep updating the 
      * table list.
      */
     public synchronized ExtendedTableDataModel<ResultObject> getDataModel() {
        try {
            if (dataModel == null) {
                dataModel = new ExtendedTableDataModel<ResultObject>(
                            new DataProvider<ResultObject>() {
                               public ResultObject getItemByKey(Object key) {
                                  try {
                                     for(ResultObject c : results) {
                                        if (key.equals(getKey(c))){
                                           return c;
                                        }
                                     }
                                  } catch (Exception ex) {
                                     //Exception handling
                                  }
                                  return null;
                               }

                               public List<ResultObject> getItemsByRange(
                                                     int firstRow, int endRow) {
                                    return Collections.unmodifiableList(results.subList(firstRow, endRow));
                               }

                               public Object getKey(ResultObject item) {
                                     return item.getResultName();
                               }

                               public int getRowCount() {
                                     return results.size();
                               }
                            });
            }
         } catch (Exception ex) {
            //Exception handling    
         }

         return dataModel;
     }

     //Getters and setters 

 }

就像我说的,它工作正常,但是当用户快速键入或快速删除时(很难准确捕获它),会引发ConcurrentModificationException。这就是它的样子:

WARNING: executePhase(RENDER_RESPONSE 6,com.sun.faces.context.FacesContextImpl@4406b8) threw exception
java.util.ConcurrentModificationException
    at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:372)
    at java.util.AbstractList$Itr.next(AbstractList.java:343)
    at org.richfaces.model.ExtendedTableDataModel.walk(ExtendedTableDataModel.java:108)
    at org.ajax4jsf.component.UIDataAdaptorBase.walk(UIDataAdaptorBase.java:1156)
    at org.richfaces.renderkit.AbstractExtendedRowsRenderer.encodeRows(AbstractExtendedRowsRenderer.java:159)
    at org.richfaces.renderkit.AbstractExtendedRowsRenderer.encodeRows(AbstractExtendedRowsRenderer.java:142)
    at org.richfaces.renderkit.AbstractExtendedRowsRenderer.encodeChildren(AbstractExtendedRowsRenderer.java:191)
    at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:812)
    at org.ajax4jsf.renderkit.RendererBase.renderChild(RendererBase.java:277)
    at org.ajax4jsf.renderkit.AjaxChildrenRenderer.encodeAjaxComponent(AjaxChildrenRenderer.java:166)
    at org.ajax4jsf.renderkit.AjaxChildrenRenderer.encodeAjaxChildren(AjaxChildrenRenderer.java:83)
    at org.ajax4jsf.renderkit.AjaxChildrenRenderer.encodeAjaxComponent(AjaxChildrenRenderer.java:157)
    ...

Java代码的同步从来就不是我最强的一面,我不知道会导致错误的原因,最重要的是,我怎样才能摆脱它。我知道,Richfaces 4.0已经对rich:extendedDataTable组件进行了很多更改,我听说这是一个问题,现在已经解决了。但是,我没有时间将整个应用程序升级到Richfaces 4.0(它将在第2阶段完成),这只是整个项目的一小部分。如果没有办法解决上面描述的问题,那么可能有一个解决方法?或者,也许还有其他方法来实现类似的搜索,使用普通的JSF(前提是它足够快速实现)。我将很感激对此事的任何帮助或建议。我希望代码是可以理解的,但如果没有,请告诉我,我会进一步解释。提前感谢您,非常感谢您的帮助。

1 个答案:

答案 0 :(得分:2)

问题是并发ajax调用服务器。在a4j:support中使用属性“eventsQueue”。通常,您应该始终在任何ajax组件中使用“eventsQueue”,同一页面中的所有“eventsQueue”引用相同的队列,除非您有充分的理由不这样做。

此外,您可能想要查看另一个ajax属性:“ajaxSingle”。