试图模拟返回IDataReader的数据服务

时间:2011-11-04 15:52:40

标签: c# unit-testing mocking rhino-mocks

我正在尝试模拟(使用Rhino.Mocks)一个返回IDataReader的DataService。我可以模拟IDataReader(StackOverFlow Q 1792984)但是如果我然后Stub out A Data Service返回这个DataReader并将其注入到我试图测试它的方法中,则stub只返回一个null数据读取器。

IDataService

public interface IDataService
{
 SqlDataReader ExecuteReader(string cmdText, CommandType commandType);
 <rest of definition ommited
}

单元测试

    [TestMethod]
    public void GetCustomer_Pass()
    {
        //Arrange
        var customer = new Customer()
                       {
                         Id = 1, FirstName = "Patrick",
                         LastName = "Hastings", ProfilePictureURL = ""
                       };

        var mockDataService = MockRepository.GenerateStub<IDataService>();

        var reader = MockRepository.GenerateStub<IDataReader>();
        reader.Stub(x => x.Read()).Repeat.Once().Return(true);
        reader.Stub(x => x.Read()).Return(false);
        reader.Stub(x => x["Id"]).Return(customer.Id);
        reader.Stub(x => x["FirstName"]).Return(customer.FirstName);
        reader.Stub(x => x["LastName"]).Return(customer.LastName);
        reader.Stub(x => x["ProfilePictureURL"]).Return(customer.ProfilePictureURL);

        mockDataService.Stub( s =>
            s.ExecuteReader(string.Format("select FirstName, LastName,ProfilePictureURL from customer where Id = {0}", customer.Id),
                            CommandType.Text))
                            .Return(reader as SqlDataReader);

        var custRepository = new CustomerRepository(mockDataService);

        //Act
        var customer2 = custRepository.GetCustomer(1);
        //Assert
        Assert.AreEqual(customer.FirstName, customer2.FirstName,"FirstName Mismatch");
        Assert.AreEqual(customer.LastName, customer2.LastName, "LastName Mismatch");
    }

方法UnderTest

    public CustomerRepository(IDataService dataService) //Constructor
    {
        if (dataService == null) throw new ArgumentNullException("dataService", "dataService cannot be null.");
        this.dataService = dataService;
    }

    public Customer GetCustomer(int id)
    {
        var sql =string.Format("select FirstName, LastName, ProfilePictureURL from customer where Id = {0}",id);
        var dr = dataService.ExecuteReader(sql, CommandType.Text);
        Customer customer ;
        using (dr)
        {
            if (!dr.Read()){return null;}
            customer = new Customer
                         {
                             FirstName = dr["FirstName"].ToString(),
                             LastName = dr["LastName"].ToString(),
                             ProfilePictureURL = dr["ProfilePictureURL"].ToString()
                         };
        }
        return customer;
    }

我得到的这个问题是当“dataService.ExecuteReader(sql,CommandType.Text);”时应该返回模拟的IDataReader但是返回Null - 任何关于我做错的指针都将非常感激。

1 个答案:

答案 0 :(得分:1)

第一点:

我相信因为传递给ExecuteReader()方法的参数不同:

设定期望:

"select FirstName, LastName,ProfilePictureURL...

实际通话时通过:(逗号和ProfilePictureURL之间的额外空格)

"select FirstName, LastName, ProfilePictureURL...

当论证本身无关紧要时,有时IgnoreArguments()非常有用

第二点:

.Return(reader as SqlDataReader);

这是无效的转换,因为reader是由RhinoMock创建的模拟对象。

我相信你不需要SqlDataReader类型,所以只需返回阅读器本身

 .Return(reader)

PS:另外我建议存储值重复为常量,您可以将customerId = 1存储为常量,以避免此类问题。