eslint返回错误,但Github操作仍然成功

时间:2020-07-31 10:33:30

标签: eslint github-actions

我设置了以下Github操作:

name: Node.js CI

on: pull_request

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [12.x]

    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - name: Install scraper dependencies
      working-directory: ./scraper
      run: npm ci
    - name: Run linting in scraper
      working-directory: ./scraper
      run: npm run lint

该操作在创建PR时运行,但是尽管eslint返回错误,但检查成功: enter image description here

如果短毛绒出现错误,如何使操作失败?

1 个答案:

答案 0 :(得分:2)

问题是npm run lint调用的命令是eslint . || true。因此,|| true导致命令总是成功完成(退出代码0)。通过删除它,退出代码将是eslint返回的值,当有错误时,退出代码是非零的退出代码。