减少用相同的行内可编辑字段呈现项目列表的查询次数

时间:2019-04-23 19:02:33

标签: python django django-rest-framework django-forms django-templates

呈现项目表时,如果未定义字段X的值,则将其呈现为选择元素。

Django对每个选择元素进行查询,这些查询可能加起来并导致大表延迟。

减少查询数量的最佳方法是什么?

views.py

from rest_framework import renderers
from rest_framework.response import Response

class ItemViewSet(viewsets.ModelViewSet):
  queryset = models.Item.objects.select_related("bought_by")
  serializer_class= serializers.ItemSerializer
  filterset_fields = ("bought_by")
  renderer_classes = [renderers.JSONRenderer, renderers.BrowsableAPIRenderer, renderers.TemplateHTMLRenderer]

  def list(self, request, *args, **kwargs):
    queryset = self.filter_queryset(self.get_queryset())

    if request.accepted_renderer.format == "html":
      items = list()
      for item in queryset:
        items.append({"serializer": self.get_serializer(item), "item": item})


      return Response(
        {
          "items_info": items,
          "style": {"template_pack": "rest_framework/inline/"},
        },
        template_name="myapp/items_list.html",
      )
    else:
     page = self.paginate_queryset(queryset)
     if page is not None:
       serializer = self.get_serializer(page, many=True)
       return self.get_paginated_response(serializer.data)

      serializer = self.get_serializer(queryset, many=True)

    return Response(serializer.data)

items_list.html

{% load static %}
{% load rest_framework %}

{% if items_info %}
  {% csrf_token %}

  <table id="Items_Table" class="table">
    <thead>
      <tr>
       <th scope="col">Name</th>
       <th scope="col">Active</th>
       <th scope="col">Bought By</th>
      </tr>
    </thead>

    <tbody>
      {% for pair in items_info %}

        <tr scope="row">
          <td>{{ pair.item.name }}</td>
          <td>{{ pair.item.active }}</td>
          <td>
            <form action="{{ item.url }}" method="PATCH">
            {% render_field pair.serializer.bought_by style=style %}
            </form>
          </td>
        </tr>

      {% endfor %}
    </tbody>
  </table>

{% else %}
  <p class="text-center">No items to show.</p>
{% endif %}

如果有三个项目,将分别查询一个以获取serializer.bought_by。我以为Django / DRF会重用该值,但是它在查询每个循环。

尝试在响应中传递"serializer-bought-by": self.get_serializer().bought_by时,我得到了AttributeError: 'ItemSerializer' object has no attribute'bought_by'

打印序列化程序,我可以看到:

>>>print(self.get_serializer())
ItemSerializer(context={'request': <rest_framework.request.Request object>, 'format': None, 'view': <myapp.views.ItemViewSet object>}):
    url = HyperlinkedIdentityField(view_name='myapp:item-detail')
    name= CharField(unique=True, max_length=50)
    active = BooleanField(required=False)
    bought_by = SlugRelatedField(allow_null=True, queryset=<QuerySet [<Buyer: James>, <Buyer: John>, ...]>, required=False, slug_field='name')

有没有办法将buy_by传递给模板? 还是我必须使用JS?在循环外渲染表单字段并以某种方式克隆/复制?

---编辑---

根据Endre的要求: models.py

class Buyer(models.Model):
  name = models.CharField(unique=True, max_length = 20)

class Item(models.Model):
  name = models.CharField(unique=True, max_length = 50)
  active = models.BooleanField(default=True)
  bought_by = models.ForeignKey(Buyer, null=True, blank=True, to_field="name",)

1 个答案:

答案 0 :(得分:0)

您不能直接在序列化器中访问字段的值。您应该改用serializer.data['bought_by']。更好的是,不要将序列化器传递给模板,而应传递serializer.data。 至于模板中的查询,由于已包含在序列化程序数据中,因此无需查询数据库即可获取bought_by。您只显示了bought_by中的一个字段名,该字段名已预装载在序列化器数据中。您应用的select_related还可以确保在序列化过程中不会进行多个查询来提取bought_by