Question

我正在尝试简化我的代码并使搜索更快一些。现在，视情况而定，填充DataGridView需要花费15秒以上的时间。

我试图将2个SQL语句连接在一起，但是失败了。另外，我也不知道如何简化库存等的检查。我试图将所有信息输入一个数组，然后将其作为DataGridView源传递，而不是逐行插入，但对搜索项无效。

conn.Open();
MySqlTransaction trans = conn.BeginTransaction();

// Getting the Product
string sql = "SELECT id, typ, generation, configuration, revision"
           + " FROM product"
           + " WHERE typ = '" + comboBox_type.SelectedValue.ToString() + "'";

MySqlCommand cmd = new MySqlCommand(sql, conn, trans);
MySqlDataReader rdr = cmd.ExecuteReader();

List<KeyValuePair<int, string>> productList = new List<KeyValuePair<int, string>>();

while (rdr.Read())
{
   string produkt = rdr[1] + "-" + string.Format("{0:X2}", rdr[2]) + string.Format("{0:X2}", rdr[3]) + string.Format("{0:X2}", rdr[4]);
   int id = Convert.ToInt32(rdr[0]);               
   productList.Add(new KeyValuePair<int, string>(id, produkt));
}
rdr.Close();

foreach (KeyValuePair<int, string> productKeyValue in productList)
{
   sql = "SELECT COUNT(c.id)"
       + " FROM component_product ctp"
       + " JOIN component c ON ctp.id = c.id"
       + " WHERE ctp.product = " + productKeyValue.Key + " AND c.`status` = 3 AND ctp.outdated = 0";

   cmd = new MySqlCommand(sql, conn, trans);
   rdr = cmd.ExecuteReader();

   int stock = Convert.ToInt32(rdr[0]);

   rdr.Close();

   int stockDiff = stock, ordered = 0, reserved = 0;

   List<string> shortage = new List<string>();
   List<string> deliveries = new List<string>();
   List<string> planing = new List<string>();

   List<CommonHelper.DeliveryEntry> pm_dict = ch.GetProductMovement(productKeyValue.Key, conn, trans);

   foreach (CommonHelper.DeliveryEntry de in pm_dict)
   {
      int amount = de.Amount;
      string strDate = CommonHelper.MaterialText.DeliveryTimestamp(de.Timestamp);
      bool confirmed = (de.Confirmed == CommonHelper.DeliveryState.Confirmed);
      stockDiff += amount;
      if (amount >= 0)
      {
         ordered += amount;
         deliveries.Add(CommonHelper.MaterialText.Deliveries(confirmed, amount, stockDiff, strDate));
         planing.Add("+" + String.Format("{0,5}", amount) + " (" + strDate + ")                                    Stand: " + stockDiff.ToString());
      }
      else
      {
         reserved += amount;
         if (stockDiff < 0)
         {
            shortage.Add(CommonHelper.MaterialText.Shortages(amount, stockDiff, strDate));
         }

         planing.Add("                           " + String.Format("{0,5}", amount) + " (" + strDate + ")            Stand: " + stockDiff.ToString());
      }
   }

   string[] rowDate = new string[] {
   productKeyValue.Value,
   stock.ToString(),
   ordered.ToString(),
   reserved.ToString(),
   string.Join(" \r\n", shortage),
   string.Join(" \r\n", deliveries),
   string.Join("\r\n", planing)
   };

   dataGridView_inventorylist.Rows.Add(rowDate);
}

Answer 1

您可能应该通过联接操作合并两个查询。您可以将子查询用作虚拟表。

此汇总（GROUP BY）子查询为每个c.id值返回一行。

                 SELECT COUNT(*) count, c.id
                   FROM component_product ctp
                   JOIN component c ON ctp.id = c.id
                  WHERE c.status = 3
                    AND ctp.outdated = 0
                  GROUP BY c.id

然后，将其加入另一个查询。我使用了LEFT JOIN，因此整个查询将报告没有计数的项目。普通的JOIN禁止显示没有计数的行。

尝试这样的事情：

 SELECT count.count,
        p.id, p.typ, p.generation, p.configuration, p.revision
   FROM product p
   LEFT JOIN (
                 SELECT COUNT(*) count, c.id
                   FROM component_product ctp
                   JOIN component c ON ctp.id = c.id
                  WHERE c.status = 3
                    AND ctp.outdated = 0
                 GROUP BY c.id 
        ) count ON p.id = count.id
  WHERE typ = '" + comboBox_type.SelectedValue.ToString() + "'";

然后，仅使用此查询的行填充网格。完全摆脱productlist集合，并摆脱对该集合的每个元素运行查询的循环。换句话说，只用一个查询就可以检索您需要的内容，而不是每个产品都要加上一个查询。这样可以解决您的性能问题。

如何提高数据库查询的性能？

1 个答案: