使用递归比较两个String(不区分大小写)

时间:2018-09-30 06:17:39

标签: java string if-statement recursion string-comparison

我需要编写一个递归方法来使用字母顺序比较两个字符串,而不使用compareTo。

string1 comes before string2 returns an integer less than 0
string1 == (or indistinguishable from) string2 returns 0
string1 comes after string2 returns an integer greater than 0

我编写了一种效果很好的方法,问题是,如果我将两个相似的字符串或一个字符串与其自身进行比较,它将返回1而不是0。

有什么主意我该如何优化我的方法,以便它不会太长并且不会比较两个相同的字符串?

我认为部分问题是因为我将变量声明为静态的,但是不确定如何在方法内声明它们。

代码:

     public class test{

            public static String s1 = "alpha";
            public static String s2 = "delta";
            public static String s3 = "omega";
            public static String s4 = "alpha";
            public static int  result;

            public static void main (String[]args){

                System.out.println(recursiveCompare(s1,s2));  // -1  good
                System.out.println(recursiveCompare(s3,s1));  //  1  good
                System.out.println(recursiveCompare(s4,s1));  //  1  FAIL!!! should be 0
                System.out.println(recursiveCompare(s2,s3));  // -1  good
                System.out.println(recursiveCompare(s1,s1));  // -1  FAIL!!! should be 0

                }

                public static int recursiveCompare(String s1, String S2){
                        if  (s1.length() ==0 || s2.length()==0){
                                if ((s1.length() ==0 && s2.length()==0)){result = 0;}
                                else if ((s1.length() !=0 || s2.length()==0)){result =  1;}
                                else if ((s1.length() ==0 || s2.length()!=0)){result = -1;}
                        }

                        else 
                        {
                            recursiveCompareHelper(s1, s2,0);
                        }
                return result;
                }

            public static int recursiveCompareHelper(String s1,String s2, int index){

                    try{

                        if (s1.regionMatches(true,index,s2,index,1)){
                                result = recursiveCompareHelper(s1,s2,(index+1));}

                            else {
                                    if (s1.charAt(index) > s2.charAt(index)){
                                        result =1;
                                    }

                                    else if (s1.charAt(index) < s2.charAt(index)){
                                        result =-1;
                                    }

                                    else if (s1.charAt(index) == s2.charAt(index)){ 
                                        result = recursiveCompareHelper(s1,s2,(index+1));
                                    }
                                }

                        } catch (StringIndexOutOfBoundsException e){
                                if      (s1.charAt(index)==0 && s2.charAt(index)== 0){result = 0;}
                                else if (s1.charAt(index)==0 && s2.charAt(index)!= 0){result = 1;}
                                else if (s1.charAt(index)!=0 && s2.charAt(index)== 0){result =-1;}
                        }

                        return result;
            }
        }

3 个答案:

答案 0 :(得分:2)

首先,请注意,您将S2作为参数传递给recursiveCompare,而不是s2, 所以实际上您将所有内容都与“ delta”进行比较,因为s2是静态变量。 第二,比较字符串时,一旦发现差异,您就可以返回答案,这是错误的,只是改变结果的值,因为以后可以再次更改并返回错误的答案。

这是我的解决方案,在每个递归调用中,我都会比较前几个字母和 如果它们相等,我将递归地调用该函数,而无需输入字符串的首字母

public class test {

    public static String s1 = "alpha";
    public static String s2 = "delta";
    public static String s3 = "omega";
    public static String s4 = "alpha";

    public static void main(String[] args) {

        System.out.println(recursiveCompare(s1, s2));  // -1  good
        System.out.println(recursiveCompare(s3, s1));  //  1  good
        System.out.println(recursiveCompare(s4, s1));  //  1  FAIL!!! should be 0
        System.out.println(recursiveCompare(s2, s3));  // -1  good
        System.out.println(recursiveCompare(s1, s1));  // -1  FAIL!!! should be 0

    }

    public static int recursiveCompare(String s1, String s2) {
        if (s1.length() == 0 || s2.length() == 0) {
            if ((s1.length() == 0 && s2.length() == 0)) {
                return 0;
            } else if (s1.length() != 0) {
                return 1;
            } else {
                return -1;
            }
        }
        if (s1.charAt(0) < s2.charAt(0)) {
            return -1;
        } else if (s1.charAt(0) > s2.charAt(0)) {
            return 1;
        } else if (s1.charAt(0) == s2.charAt(0)) {
            return 0;
        } else {
            return recursiveCompare(s1.substring(1), s2.substring(1));
        }
    }

}

输出:

-1
1
0
-1
0

答案 1 :(得分:0)

您不需要使用.langth()方法。要比较字符串,您需要使用.equals()

public static int recursiveCompare(String s1, String s2){
    if  (s1.equals(s2)) {
        return 0;
    }

    else
    {
        recursiveCompareHelper(s1, s2,0);
    }
    return result;
}

在recursiveCompare(字符串s1,字符串S2)中,您拥有S2的s2。

答案 2 :(得分:0)

您在程序中犯的主要错误是在函数recursiveCompare中,您已将参数设为S2,并在使用变量s2的函数中将其声明为static变量,因此您的函数无法提供正确的结果。请记住,java是区分大小写的语言,在这种情况下,S2s2不同。

下面是我修改过的程序,用于您的理解。

    public class Test{

 /*    public static String s1 = "alpha";
        public static String s2 = "delta";
        public static String s3 = "omega";
        public static String s4 = "alpha";*/
        public static int  result;


        public static void main (String[]args){

              String s1 = "alpha";
              String s2 = "delta";
              String s3 = "omega";
              String s4 = "alpha";

             System.out.println(recursiveCompare(s1,s2));  // -1  good
             System.out.println(recursiveCompare(s3,s1));  //  1  good
            System.out.println(recursiveCompare(s4,s1));  //  1  FAIL!!! should be 0
            System.out.println(recursiveCompare(s2,s3));  // -1  good
            System.out.println(recursiveCompare(s1,s1));  // -1  FAIL!!! should be 0

            }



            public static int recursiveCompare(String s1, String S2){ 
                    if  (s1.length() ==0 || S2.length()==0){ // here you have to use S2 and not s1
                            if ((s1.length() ==0 && S2.length()==0)){result = 0;}
                            else if ((s1.length() !=0 || S2.length()==0)){result =  1;}
                            else if ((s1.length() ==0 || S2.length()!=0)){result = -1;}
                    }

                    else 
                    {
                        recursiveCompareHelper(s1, S2,0);
                    }
            return result;
            }



        public static int recursiveCompareHelper(String s1,String s2, int index){


                             // System.out.println("String are" + s1+"   "+ s2 + " index is "+ index);

                              if(index<s1.length()) {

                                 // System.out.println("Characters at  index : "+ s1.charAt(index)+ "  "+ s2.charAt(index));

                                if (s1.charAt(index) > s2.charAt(index)){
                                    //System.out.println("In the if condition");
                                    result= 1;
                                }

                                else if (s1.charAt(index) < s2.charAt(index)){
                                    //System.out.println("In the else if condition");
                                    result =-1;
                                }

                                else if (s1.charAt(index) == s2.charAt(index)){
                                    //System.out.println("Character at "+index);
                                    result = recursiveCompareHelper(s1,s2,(index+1));
                                }
                              }
                              else return 0;

                            return result;



        }
    }