Uncaught TypeError:无法读取未定义的属性“ length” ...?

时间:2018-08-20 03:57:28

标签: javascript debugging undefined-behavior

我意识到所提出的问题。但是我不确定为什么我仍然会收到此错误。

Ucaught TypeError: Cannot read property 'length' of undefined
    at Object.addItem

我看不到长度是如何定义的,当我检查长度是否大于0时,我是否无法正确访问data对象?

我有一个预算控制程序IIFE,它具有收益addItem函数。在此函数中,我在此行出现错误:

     if (data.allItems[type].length > 0) {

这是全部功能。

// BUDGET CONTROLLER
var budgetController = (function() {

    var Expense = function(id, description, value) {
        this.id = id;
        this.description  = description;
        this.value = value;
    };
    var Income = function(id, description, value) {
        this.id = id;
        this.description  = description;
        this.value = value;
    };

    var data = {
        allItems: {
            exp: [],
            inc: []            
        },

        totals: {
          exp: 0,
            inc: 0
        }    
    };

    return {
        addItem: function(type, des, val) {
            var newItem, ID;

            //[1 2 3 4 5], next ID = 6
            //[1 2 4 6 8], next ID = 9
            // ID = last ID + 1

            // Create new ID
             if (data.allItems[type].length > 0) {
                ID = data.allItems[type][data.allItems[type].length - 1].id + 1;
            } else {
                ID = 0;
            }

            // Create new item based on 'inc' or 'exp' type
            if (type === 'exp') {
                newItem = new Expense(ID, des, val);
            } else if (type === 'inc') {
                newItem = new Income(ID, des, val);
            }

            // Push it into our data structure
            data.allItems[type].push(newItem);

            // Return the new element
            return newItem;
        },

        testing: function() {
            console.log(data);
        }
    }

})();

我也在这里称呼它。

var ctrlAddItem = function() {
        var input, newItem;

       // 1. Get the FIELD input data
       input = UICtrl.getinput();

        // 2. Add the item to the budget controler
        newItem = budgetCtrl.addItem(input.type, input.description, input.value);

       // 3. add the item to the UI

       // 4. Calculate the budget 

       // 5. Display the budget on the UI


    }

UI控制器-我从哪里获得输入。

// UI CONTROLLER
var UIController =  (function() {
    // some code
    var DOMstrings = {
        inputType: '.add__type',
        inputDescription: '.add__description',
        inputValue: '.add__value',
        inputBtn: '.add__btn'
    }

    return {
        getinput: function() {
            // will be either inc or exp
            return {
                type: document.querySelector(DOMstrings.inputType).value,
                description: document.querySelector(DOMstrings.inputDescription).value,
                value: document.querySelector(DOMstrings.inputValue).value               
            }
        },

        getDOMstrings: function() {
            return DOMstrings;
        }
    }
})();




// GLOBAL APP CONTROLLER
var controller = (function(budgetCtrl, UICtrl) {

    var setupEventListerners = function() {
         var DOM = UICtrl.getDOMstrings();
        document.querySelector(DOM.inputBtn).addEventListener('click', ctrlAddItem);

        document.addEventListener('keypress', function(event) {
             if(event.keyCode == 13 || event.which == 13) {
                 ctrlAddItem();
             }
        });        
    };

    var ctrlAddItem = function() {
        var input, newItem;

       // 1. Get the FIELD input data
       input = UICtrl.getinput();

        // 2. Add the item to the budget controler
        newItem = budgetCtrl.addItem(input.type, input.description, input.value);

       // 3. add the item to the UI

       // 4. Calculate the budget 

       // 5. Display the budget on the UI


    }

    return {
        init: function() {
            console.log('application start');
            setupEventListerners();
        }
    }

})(budgetController, UIController);


controller.init();

有任何想法吗?

2 个答案:

答案 0 :(得分:1)

看起来变量input(来自input = UICtrl.getinput()),具有属性.type既不是exp也不是inc,或者没有拥有.type(即undefined)。

这将导致data.allItems[type]undefined,而undefined没有length

答案 1 :(得分:0)

项目的Starter文件夹和Final文件夹中的Index.html文件之间存在差异。因此,出于某些原因,在第44和45行的启动文件夹的index.html文件中,它说的是“收入”而不是“ inc”,是“费用”而不是“ exp”。

<option value="income" selected>+</option> 
<option value="expenses">-</option>

因此打开html文件并将其更改为:

<option value="inc" selected>+</option>
<option value="exp">-</option>