单元测试不会运行:由于StackOverflowException,进程终止

时间:2018-06-09 22:18:38

标签: c# unit-testing

我正在进行单元测试以测试我编写的算法,不幸的是,由于这个错误,这些测试甚至无法运行:

  

[10-6-2018 00:12:00信息] ==========运行测试完成:0运行(0:00:06,5685302)========= =   [10-6-2018 00:12:04信息] ------运行测试开始------   [10-6-2018 00:12:09错误]活动测试运行中止。原因:由于StackOverflowException,进程终止。

这些都是我的单元测试:

namespace AlgoritmeTest
{
    [TestClass]
    public class AlgoritmeTests
    {
        [TestMethod]
        public void TestAddingWagonToTrain()
        {
            Train train = new Train();
            Wagon wagon = new Wagon(10);

            List<Wagon> expected = new List<Wagon>();
            expected.Add(wagon);

            train.AddWagon(wagon);
            List<Wagon> actual = train.GetWagons();
            Assert.AreEqual(expected, actual, "Failed to add wagon to train");

        }

        [TestMethod]
        public void TestAddingAnimalToWagon()
        {
            Train train = new Train();
            Wagon wagon = new Wagon(10);
            Animal animal = new Animal("Goudvis", AnimalFood.Meat, AnimalSize.Big);


            List<Animal> expected = new List<Animal>();
            expected.Add(animal);

            wagon.AddAnimal(animal);
            List<Animal> actual = wagon.GetAnimals();

            Assert.AreEqual(expected, actual, "Failed to add animal to wagon");
        }
        [TestMethod]
        public void TestIfAnimalsAreReturned()
        {
            Animal animal = new Animal();

            Animal goudvis = new Animal("Goudvis", AnimalFood.Meat, AnimalSize.Big);
            Animal visstick = new Animal("Visstick", AnimalFood.Meat, AnimalSize.Big);
            animal.animalsFromTheCircus.Add(goudvis);
            animal.animalsFromTheCircus.Add(new Animal("Potvis", AnimalFood.Plants, AnimalSize.Medium));
            animal.animalsFromTheCircus.Add(new Animal("Zalm", AnimalFood.Meat, AnimalSize.Small));
            animal.animalsFromTheCircus.Add(visstick);
            animal.animalsFromTheCircus.Add(new Animal("Varkenshaasje", AnimalFood.Plants, AnimalSize.Big));

            List<Animal> expected = new List<Animal>();
            expected.Add(goudvis);
            expected.Add(visstick);

            List<Animal> actual = animal.GetAllBigMeatEaters();

            Assert.AreEqual(expected, actual, "Failed to get all animals which meet criteria");
        }
        [TestMethod]
        public void TestIfAlgorithmStepWorks()
        {
            Program program = new Program();
            Animal animal = new Animal();

            Wagon wagon = new Wagon(10);
            Wagon wagon2 = new Wagon(10);

            Animal goudvis = new Animal("Goudvis", AnimalFood.Meat, AnimalSize.Big);
            Animal visstick = new Animal("Visstick", AnimalFood.Meat, AnimalSize.Big);

            animal.animalsFromTheCircus.Add(goudvis);
            animal.animalsFromTheCircus.Add(visstick);
            animal.animalsFromTheCircus.Add(new Animal("Potvis", AnimalFood.Plants, AnimalSize.Medium));
            animal.animalsFromTheCircus.Add(new Animal("Zalm", AnimalFood.Meat, AnimalSize.Small));
            animal.animalsFromTheCircus.Add(new Animal("Varkenshaasje", AnimalFood.Plants, AnimalSize.Big));

            wagon.AddAnimal(goudvis);
            wagon2.AddAnimal(visstick);

            Train expected = new Train();

            expected.AddWagon(wagon);
            expected.AddWagon(wagon2);



            program.SetUpProgram(animal.animalsFromTheCircus);
            Train actual = program.AddAllMeatEaters();

            Assert.AreEqual(expected, actual, "Failed to get all animals which meet criteria and place them in train according to alogrithm");
        }
    }
}

Animal.cs

public class Animal
{
    private string animalName;
    private AnimalFood animalFood;
    private AnimalSize animalSize;

    public Animal(string animalName, AnimalFood animalFood, AnimalSize animalSize)
    {
        this.animalName = animalName;
        this.animalFood = animalFood;
        this.animalSize = animalSize;
    }
    public Animal()
    {

    }

    public List<Animal> animalsFromTheCircus = new DataGenerator().GenerateAnimals(100);

    public List<Animal> GetallAnimals()
    {
        return animalsFromTheCircus;
    }

    public List<Animal> GetAllBigMeatEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Big && animal.getAnimalFood() == AnimalFood.Meat).ToList();
    }
    public List<Animal> GetAllBigMeatEaters(List<Animal> animalsFromTheCircus)
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Big && animal.getAnimalFood() == AnimalFood.Meat).ToList();
    }
    public List<Animal> GetAllSmallMeatEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Small && animal.getAnimalFood() == AnimalFood.Meat).ToList();
    }
    public List<Animal> GetAllBigPlantEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Big && animal.getAnimalFood() == AnimalFood.Plants).ToList();
    }

    public List<Animal> GetAllMediumMeatEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Medium && animal.getAnimalFood() == AnimalFood.Meat).ToList();
    }
    public List<Animal> GetAllMediumPlantEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Medium && animal.getAnimalFood() == AnimalFood.Plants).ToList();
    }

    public List<Animal> GetAllSmallPlantEaters()
    {
        return animalsFromTheCircus.Where(animal => animal.getAnimalSize() == AnimalSize.Small && animal.getAnimalFood() == AnimalFood.Plants).ToList();
    }

    public string getAnimalName()
    {
        return this.animalName;
    }

    public AnimalFood getAnimalFood()
    {
        return this.animalFood;
    }

    public AnimalSize getAnimalSize()
    {
        return this.animalSize;
    }
}

Wagon.cs

   public class Wagon
{
    private List<Animal> animals;
    private int maxSize;

    public Wagon(int maxSize)
    {
        this.animals = new List<Animal>();
        this.maxSize = maxSize;
    }

    public void AddAnimal(Animal animal)
    {
        this.animals.Add(animal);
    }

    public List<Animal> GetAnimals()
    {
        return this.animals;
    }
}

Train.cs

    public class Train
{
    private List<Wagon> wagons;

    public Train()
    {
        this.wagons = new List<Wagon>();
    }

    public void AddWagon(Wagon wagon)
    {
        this.wagons.Add(wagon);
    }

    public List<Wagon> GetWagons()
    {
        return this.wagons;
    }
}

我的测试有什么问题,为什么他们不会跑?

1 个答案:

答案 0 :(得分:4)

你所展示的代码中没有循环引用,我的蜘蛛般的感官告诉我问题在这里

public List<Animal> animalsFromTheCircus = new DataGenerator().GenerateAnimals(100);

<强>更新

每当你制造动物时,它就会产生动物,从而产生动物,奇点就会发生。

让整个宇宙陷入困境

更新2

此处还有一个严重的“关注点分离问题,我的意思是为什么这类动物甚至还有一个动物清单,而不是很多动物,我知道它们有子动物(在任何动物中都是如此)正常意义)..