Question

我想将所有*.bk文件从给定路径移动/覆盖到一个文件夹，该文件夹具有作为名称运行的日期。我目前正在执行以下操作：

string startingPath = @"D:\test\Jobs";
DateTime today = DateTime.Today;
string _date = today.ToString("dd-MM-yyyy");
string newPath = @"D:";
string destPath = newPath + "\\" + _date;
if (!Directory.Exists(newPath + "\\" + _date))
    {
    Directory.CreateDirectory(newPath + "\\" + _date);
    }
string[] files = Directory.GetFiles(startingPath, "*.bk", SearchOption.AllDirectories);

// Move the files and overwrite destination files if they already exist.
foreach (string file in files)
    {
    // Use static Path methods to extract only the file name from the path.
    string fileName = Path.GetFileName(file);
    string destFile = Path.Combine(destPath, fileName);
    if (File.Exists(destFile))
    {
        File.Delete(destFile);
    }
    File.Move(file, destFile);
   }

但这对于这样一个基本任务感觉太多代码，是否有办法缩短此代码或使该程序更快？

Answer 1

你写的很多内容都可以简化：

void MoveAllBk(string from_path)
{
    string to_path = @"D:\" + Today.ToString("dd-MM-yyyy");
    Directory.CreateDirectory(to_path);
    foreach (string file in Directory.GetFiles(from_path, "*.bk", SearchOption.AllDirectories))
    {
        string new_file = System.IO.Path.Combine(to_path, new System.IO.FileInfo(file).Name);
        if (System.IO.File.Exists(new_file)) { System.IO.File.Delete(new_file); }
        System.IO.File.Move(file, new_file);
    }
}

新路径可以在一行中声明。

创建目录只有在指定的路径不存在时才会这样做。

可以使用foreach语句内联声明迭代变量。

这应该会有所加快，并且根据要求，需要更少的代码。

编辑：还应该注意，搜索选项'AllDirectories'很可能需要更长时间（取决于from_path目录的内容），如果可能的话，使用'TopLevelOnly'。

Answer 2

以下是递归浏览文件夹的示例代码：

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Xml;
using System.Xml.Linq;
using System.IO;

namespace ConsoleApplication19
{
    class Program
    {
        const string FILENAME = @"c:\temp\test.xml";
        const string FOLDER = @"c:\temp";
        static XmlWriter writer = null;
        static void Main(string[] args)
        {
            XmlWriterSettings settings = new XmlWriterSettings();
            settings.Indent = true;

            writer = XmlWriter.Create(FILENAME, settings);
            writer.WriteStartDocument(true);

            DirectoryInfo info = new DirectoryInfo(FOLDER);
            WriteTree(info);

            writer.WriteEndDocument();
            writer.Flush();
            writer.Close();


        }
        static long WriteTree(DirectoryInfo info)
        {
            long size = 0;
            writer.WriteStartElement("Folder");
            try
            {
                writer.WriteAttributeString("name", info.Name);
                writer.WriteAttributeString("numberSubFolders", info.GetDirectories().Count().ToString());
                writer.WriteAttributeString("numberFiles", info.GetFiles().Count().ToString());
                writer.WriteAttributeString("date", info.LastWriteTime.ToString());


                foreach (DirectoryInfo childInfo in info.GetDirectories())
                {
                    size += WriteTree(childInfo);
                }

            }
            catch (Exception ex)
            {
                string errorMsg = string.Format("Exception Folder : {0}, Error : {1}", info.FullName, ex.Message);
                Console.WriteLine(errorMsg);
                writer.WriteElementString("Error", errorMsg);
            }

            FileInfo[] fileInfo = null;
            try
            {
                fileInfo = info.GetFiles();
            }
            catch (Exception ex)
            {
                string errorMsg = string.Format("Exception FileInfo : {0}, Error : {1}", info.FullName, ex.Message);
                Console.WriteLine(errorMsg);
                writer.WriteElementString("Error", errorMsg);
            }

            if (fileInfo != null)
            {
                foreach (FileInfo finfo in fileInfo)
                {
                    try
                    {
                        writer.WriteStartElement("File");
                        writer.WriteAttributeString("name", finfo.Name);
                        writer.WriteAttributeString("size", finfo.Length.ToString());
                        writer.WriteAttributeString("date", info.LastWriteTime.ToString());
                        writer.WriteEndElement();
                        size += finfo.Length;
                    }
                    catch (Exception ex)
                    {
                        string errorMsg = string.Format("Exception File : {0}, Error : {1}", finfo.FullName, ex.Message);
                        Console.WriteLine(errorMsg);
                        writer.WriteElementString("Error", errorMsg);
                    }
                }
            }

            writer.WriteElementString("size", size.ToString());
            writer.WriteEndElement();
            return size;

        }
    }
}

以最快的方式将某些文件移动到文件夹中？

2 个答案: