从Oracle中的触发器调用过程时收到错误

Question

我有以下代码摘录，它将使用触发器和存储过程将数据插入到三个表中，以便触发器调用。触发器和过程都已成功编译。

   CREATE OR REPLACE TRIGGER trigger_insert_attr AFTER
    INSERT ON BSCS_WORK_SYNC_INFO FOR EACH ROW BEGIN 
    bscs_rateplan_sync(:new.project_id , :new.tmcode);
   update BSCS_WORK_SYNC_INFO set comp_date=SYSDATE where 
    project_id=:new.project_id;
  END trigger_insert_attr;
  /


   CREATE OR REPLACE
  PROCEDURE bscs_rateplan_sync
  (
    tmcode_list IN VARCHAR2,
    project_id  IN VARCHAR2
  )
  AS
  BEGIN
  EXECUTE IMMEDIATE 'delete from  ecm_mpulktm1 where 
  project_id='||project_id ;
  EXECUTE IMMEDIATE 'delete from  ecm_mpulktm2 where 
  project_id='||project_id ;
  EXECUTE IMMEDIATE 'delete from  ecm_fup_tariff_work where 
  project_id='||project_id ;
  EXECUTE immediate 'insert into ecm_mpulktm1 select '||project_id||' , m1.* 
  from sysadm.mpulktm1@to_bscsprd_rpt m1 where tmcode in 
  ('||tmcode_list||')' 
   ;
  EXECUTE immediate 'insert into ecm_mpulktm2 select '||project_id||' , m1.* 
  from sysadm.mpulktm2@to_bscsprd_rpt m1 where tmcode in 
  ('||tmcode_list||')' 
  ;
  EXECUTE immediate 'insert into ecm_fup_tariff_work select '||project_id||' 
 , m1.* from sysadm.fup_tariff_work@to_bscsprd_rpt m1 where tmcode in 
 ('||tmcode_list||')' ;
  END;
  /

但是，当数据被插入表BSCS_WORK_SYNC_INFO时，我得到了     以下错误：

  

SQL错误：ORA-00933：SQL命令未正确结束       ORA-06512：在“ECMREPORT.BSCS_RATEPLAN_SYNC”，第6行       ORA-06512：在“ECMREPORT.TRIGGER_INSERT_ATTR”，第2行       ORA-04088：执行触发器'ECMREPORT.TRIGGER_INSERT_ATTR'时出错

有人可以帮忙解决错误吗？我是PL / SQL的新手，因此会请求帮助来解决上述错误。表BSCS_WORK_SYNC_INFO中的数据将由Web服务填充。此外，执行过程后要在表中更新的数据。

Answer 1

A＆＃34;快速而肮脏＆＃34;修复

CREATE OR REPLACE TRIGGER trigger_insert_attr
    AFTER INSERT ON BSCS_WORK_SYNC_INFO FOR EACH ROW
BEGIN
    bscs_rateplan_sync(:new.project_id, :new.tmcode);
    update bscs_work_sync_info set comp_date = SYSDATE where project_id = :new.project_id;
END trigger_insert_attr;
/

CREATE OR REPLACE
PROCEDURE bscs_rateplan_sync
    ( tmcode_list   IN VARCHAR2
    , project_id    IN VARCHAR2 )
AS
BEGIN
    delete from ecm_mpulktm1 where project_id = bscs_rateplan_sync.project_id;
    delete from ecm_mpulktm2 where project_id = bscs_rateplan_sync.project_id;
    delete from ecm_fup_tariff_work where project_id = bscs_rateplan_sync.project_id;

    execute immediate '
        insert into ecm_mpulktm1
        select :project_id, m1.*
        from sysadm.mpulktm1@to_bscsprd_rpt m1
        where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')'
    using in bscs_rateplan_sync.project_id;

    execute immediate '
        insert into ecm_mpulktm2
        select :project_id, m1.*
        from sysadm.mpulktm2@to_bscsprd_rpt m1
        where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')'
    using in bscs_rateplan_sync.project_id;

    execute immediate '
        insert into ecm_fup_tariff_work
        select :project_id, m1.*
        from sysadm.fup_tariff_work@to_bscsprd_rpt m1
        where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')'
    using in bscs_rateplan_sync.project_id;
END;
/

正确修复

......将是

• 通过将bscs_rateplan_sync.tmcode_list中的值列表解析为集合并将集合绑定到静态SQL来完全删除动态SQL，
• 将bscs_work_sync_info.comp_date的更新移动到更新bscs_work_sync_info()存储过程，并声明触发器调用存储过程而不是匿名PLSQL块。