Question

我试图理解为什么以下单元测试不执行回调。如果我修改代码，以便UpdateWorklowInstanceState方法只包含2个参数（Guid和IList），它可以工作。但是，有3个参数会干扰。

干扰的意思是Callback似乎没有被执行。没有错误消息。我希望看到＆＃34;错误发生＆＃34;消息，而是接收＆＃34;元素更新＆＃34; message表示Callback没有使用NotificationMessage填充resultMessages。

public void BusinessObjectReturnsErrorNotification_ReturnErrorMessage()
        {
            var workflowInstanceGuid = Guid.NewGuid();

            var workflowElementModel = new WorkflowElementModel
            {
                ElementName = "ValidName",
                WorkflowInstanceId = workflowInstanceGuid.ToString()
            };

            var workflowElementInstance = new WorkflowElementInstance
            {
                ElementName = workflowElementModel.ElementName,
                FullDescription = "Full Description",
                SummaryDescription = "Summary Description",
                RefTime = DateTime.Now,
                ElementType = "ElementType"
            };

            var mockWebApiBusinessObject = new Mock<IWebApiBusinessObject>();
            mockWebApiBusinessObject.Setup(m => m.UpdateWorkflowInstanceState(workflowInstanceGuid, workflowElementInstance, It.IsAny<List<NotificationMessage>>()))
                .Callback<Guid, WorkflowElementInstance, IList<NotificationMessage>>(
                    (workflowInstanceId, elementDetails, resultMessages) =>
                    {
                        resultMessages.Add(new NotificationMessage("An Error Occured!", MessageSeverity.Error));
                    });

            var controller = new WorkflowElementController(mockWebApiBusinessObject.Object);
            var result = controller.UpdateWorkflowElement(workflowElementModel);

            Assert.AreEqual("An Error Occured!", result.Content.ReadAsStringAsync().Result);
        }

待测方法：

[HttpPost]
    [ActionName("UpdateWorkflowElement")]
    public HttpResponseMessage UpdateWorkflowElement(WorkflowElementModel workflowElementModel)
    {
        if (!ModelState.IsValid || workflowElementModel == null)
        {
            return new HttpResponseMessage(HttpStatusCode.BadRequest);
        }

        var response = new HttpResponseMessage(HttpStatusCode.OK);
        string responseMessage;

        if (workflowElementModel.RefTime == DateTime.MinValue)
        {
            workflowElementModel.RefTime = DateTime.UtcNow;
        }

        var resultMessages = new List<NotificationMessage>();
        var instanceId = new Guid();

        if (string.IsNullOrWhiteSpace(workflowElementModel.WorkflowInstanceId) ||
            string.IsNullOrWhiteSpace(workflowElementModel.ElementName))
        {
            responseMessage = "WorkflowInstanceId or ElementName are null or empty";
        }
        else if (!Guid.TryParse(workflowElementModel.WorkflowInstanceId, out instanceId))
        {
            responseMessage = "WorkflowInstanceId is not a valid Guid";
        }
        else
        {
            var element = new WorkflowElementInstance
            {
                ElementName = workflowElementModel.ElementName,
                RefTime = workflowElementModel.RefTime,
                SummaryDescription = workflowElementModel.SummaryDescription ?? "",
                FullDescription = workflowElementModel.FullDescription ?? ""
            };

            _webApiBusinessObject.UpdateWorkflowInstanceState(instanceId, element, resultMessages);

            responseMessage = "Element Updated";
        }

        if (NotificationMessage.HasErrors(resultMessages))
        {
            responseMessage = resultMessages.Find(m => m.Status == MessageSeverity.Error).Message;
        }

        response.Content = new StringContent(responseMessage);
        return response;
    }

Answer 1

对于3个参数，它不起作用，因为您正在混合表达式参数类型。

It.IsAny<List<NotificationMessage>>()

在设置中

，与

相对应

IList<NotificationMessage>

在回调参数中。

这意味着setup表达式参数与回调表达式参数不匹配，因此不会调用回调。

坚持使用一种类型，所以要么同时使用List<NotificationMessage>

您还在测试方法中创建参数的新实例，这与实例中使用的实例不同。这就是回叫不起作用的原因。为了证明这一点。对所有参数使用It.IsAny<>()，它应该可以正常工作

mockWebApiBusinessObject
    .Setup(m => m.UpdateWorkflowInstanceState(It.IsAny<Guid>(), It.IsAny<WorkflowElementInstance>(), It.IsAny<List<NotificationMessage>>()))
    .Callback<Guid, WorkflowElementInstance, List<NotificationMessage>>(
                (workflowInstanceId, elementDetails, resultMessages) =>
                {
                    resultMessages.Add(new NotificationMessage("An Error Occured!", MessageSeverity.Error));
                });

或更通用的界面

mockWebApiBusinessObject
    .Setup(m => m.UpdateWorkflowInstanceState(It.IsAny<Guid>(), It.IsAny<WorkflowElementInstance>(), It.IsAny<IList<NotificationMessage>>()))
    .Callback<Guid, WorkflowElementInstance, IList<NotificationMessage>>(
                (workflowInstanceId, elementDetails, resultMessages) =>
                {
                    resultMessages.Add(new NotificationMessage("An Error Occured!", MessageSeverity.Error));
                });

您还应该花一些时间来审核Moq Quickstart，以便更好地了解如何使用模拟框架。

Answer 2

请考虑在单元测试中的次要位置进行更新。在模拟IWebApiBusinessObject对象之前添加：

 List<NotificationMessage> messages = new List<NotificationMessage>();

此外，请更新Callback：

var mock = new Mock<IWebApiBusinessObject>();
            mock.
            Setup(m => m.UpdateWorkflowInstanceState(It.IsNotNull<Guid>(), It.IsNotNull<WorkflowElementInstance>(),It.IsAny<List<NotificationMessage>>() )).
            Callback(() => 
                {
                    messages.Add(new NotificationMessage("error msg", MessageSeverity.Severe));
                    messages.Add(new NotificationMessage("Ignore Message", MessageSeverity.Normal)); // this is optional... u can remove it if u want.
                });

需要将源代码方法UpdateWorkflowElement(WorkflowElementModel model)更新为

UpdateWorkflowElement(WorkflowElementModel model, List<NotificationMessage> messages);

考虑调用UpdateWorkflowElement到

的单元测试代码的更改

var result = controller.UpdateWorkflowElement(workflowElementModel, messages);

如果我已正确理解您的UpdateWorkflowInstanceState()方法，然后您使用IWebApiBusinessObject来调用UpdateWorkflowInstanceState( , , )方法。在单元测试期间执行UpdateWorkflowInstanceState( , , )时，它会在您的单元测试中触发Callback，并在NotificationMessage列表中添加消息。

Moq Callback不使用3参数方法

2 个答案: